https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 133549 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133549&action=edit Bug 30579: Disentangle multi-hold and single bib forms This patch simply groups the forms so that multi-hold and single hold are each in their own section While there is some duplication from this, it makes the sections easier to read and allows for more variation in the two forms To test: 1 - Place a single bib and multi bib hold in staff client 2 - Apply this patch 3 - Repeat and confirm nothing changes with this patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com | |, oleonard@myacpl.org Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | Depends on| |30577 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30577 [Bug 30577] Item specific holds location can be missed when placing title level holds -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133550|0 |1 is obsolete| | --- Comment #5 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 133575 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133575&action=edit Bug 30579: Group next available hold options, and disable when item is chosen This patch rearranges options that only apply to next available holds and disables them when an item is checked. This is intended to make it more obvious which parts of the form apply to this selection To test: 1 - Apply patches 2 - Confirm you can successfully place single or multiple items on hold 3 - Confirm that when placing a single hold the next available options are grouped 4 - Confirm pickup location, specific item type, and number of holds all work for next available 5 - Confirm item level holds save pickup location correctly Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133575|0 |1 is obsolete| | --- Comment #7 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 133690 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133690&action=edit Bug 30579: Group next available hold options, and disable when item is chosen This patch rearranges options that only apply to next available holds and disables them when an item is checked. This is intended to make it more obvious which parts of the form apply to this selection To test: 1 - Apply patches 2 - Confirm you can successfully place single or multiple items on hold 3 - Confirm that when placing a single hold the next available options are grouped 4 - Confirm pickup location, specific item type, and number of holds all work for next available 5 - Confirm item level holds save pickup location correctly Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133689|0 |1 is obsolete| | --- Comment #11 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 134491 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134491&action=edit Bug 30579: Disentangle multi-hold and single bib forms This patch simply groups the forms so that multi-hold and single hold are each in their own section While there is some duplication from this, it makes the sections easier to read and allows for more variation in the two forms To test: 1 - Place a single bib and multi bib hold in staff client 2 - Apply this patch 3 - Repeat and confirm nothing changes with this patch Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134469|0 |1 is obsolete| | --- Comment #13 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 134493 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134493&action=edit Bug 30579: (follow-up) Update layout to make hold any vs. hold item clearer This patch alters the structure of the hold for a little more in order to make it clear that "Hold next available" and "Hold specific item" are two mutually-exclusive options. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). Perform the same tests as before: - Confirm you can successfully place single or multiple items on hold - Confirm that when placing a single hold the next available options are grouped - Confirm pickup location, specific item type, and number of holds all work for next available - Confirm item level holds save pickup location correctly -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134493|0 |1 is obsolete| | --- Comment #15 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 134893 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134893&action=edit Bug 30579: (follow-up) Update layout to make hold any vs. hold item clearer This patch alters the structure of the hold for a little more in order to make it clear that "Hold next available" and "Hold specific item" are two mutually-exclusive options. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). Perform the same tests as before: - Confirm you can successfully place single or multiple items on hold - Confirm that when placing a single hold the next available options are grouped - Confirm pickup location, specific item type, and number of holds all work for next available - Confirm item level holds save pickup location correctly -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk Status|Needs Signoff |Failed QA --- Comment #17 from Sally <sally.healey@cheshiresharedservices.gov.uk> --- I really like the redesign - it's very clear and user friendly. It all works perfectly, except if the staff make a mistake and do the following: - Place a hold for a patron - Choose 'Place a hold on a specific item' - Fail to choose an item - Just press the 'Place hold' button beneath 'Place a hold on a specific item' (#hold_item_btn) The hold is now placed for pick up at a blank library. If you check an item in to fill the hold, Koha presents an error page, e.g. Can't call method "branchcode" on an undefined value at /kohadevbox/koha/Koha/Item.pm line 683 On the current version of Koha, if the staff press this button (#hold_item_btn) without selecting an item, the hold defaults to being a bib level hold where the pick up library is the logged in library (as if they'd pressed: #hold_any_btn) It'd be good if the 'Place hold' button for 'Place a hold on a specific item' could be blanked out until a specific item has been chosen. Alternatively, maybe the pick up location drop down could go back into the 'Hold details' section at the top of the page - so then it can still fall back to a bib level hold if it's pressed without selection, but it would still be given a location. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31579 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579 --- Comment #19 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 140952 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140952&action=edit Bug 30579: Whitespace -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579 --- Comment #21 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 140954 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140954&action=edit Bug 30579: (follow-up) Update layout to make hold any vs. hold item clearer This patch alters the structure of the hold for a little more in order to make it clear that "Hold next available" and "Hold specific item" are two mutually-exclusive options. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). Perform the same tests as before: - Confirm you can successfully place single or multiple items on hold - Confirm that when placing a single hold the next available options are grouped - Confirm pickup location, specific item type, and number of holds all work for next available - Confirm item level holds save pickup location correctly -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134270|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148835|0 |1 is obsolete| | --- Comment #25 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 148898 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148898&action=edit Bug 30579: Disentangle multi-hold and single bib forms This patch alters the structure of the hold request page to make it clear that "Hold next available", "Hold item group", and "Hold specific item" are mutually-exclusive options. While there is some duplication from this, it makes the sections easier to read and allows for more variation in the two forms To test: 1 - Find a bib with multiple items 2 - Enable item groups and item group holds in system preferences 3 - Load the records detail page 4 - Add an item group on the item groups tab 5 - Select two items and add to the group 6 - Place a hold for a patron 7 - Confirm the three levels of holds are clear 8 - Confirm checking the radio next to one disables the others 9 - Confirm you can successfully place all 3 types of holds 10 - Confirm if placing a second hold that the type is forced correctly -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579 --- Comment #27 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 149271 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149271&action=edit Bug 30579: (follow-up) Update form checker for each form -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus@libriotech.no Status|Needs Signoff |Failed QA --- Comment #29 from Magnus Enger <magnus@libriotech.no> --- I don't think this works as intended for me. 1. When I load the page, the radio button to the right of "Hold next available item" is active/selected. - Under "Hold next available item from an item group", the dropdown and the radio button is disabled. The dropdown is "greyed out" and nothing happens if I click on either of them. - But under "Place a hold on a specific item" the dropdown for "Allowed pickup locations" is not "greyed out" and I can interact with it. I can click on the radio buttons under "Hold", and if I do, the radio button to the right of "Hold next available item" is no longer active/selected. In fact, none of the three radio buttons to the right of the headings are active/selected. 2. If i click on the radio button for "Hold next available item from an item group" - I can interact with the "Hold" radio button and the "Allowed pickup locations" dropdown under "Place a hold on a specific item". - If i click on a radio button under "Hold", then the radio button to the right of "Hold next available item from an item group" remains active/selected (this is different from what happens under 1 above). -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579 Hinemoea Viault <hinemoea.viault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150767|0 |1 is obsolete| | --- Comment #32 from Hinemoea Viault <hinemoea.viault@inlibro.com> --- Created attachment 150786 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150786&action=edit Bug 30579: Disentangle multi-hold and single bib forms This patch alters the structure of the hold request page to make it clear that "Hold next available", "Hold item group", and "Hold specific item" are mutually-exclusive options. While there is some duplication from this, it makes the sections easier to read and allows for more variation in the two forms To test: 1 - Find a bib with multiple items 2 - Enable item groups and item group holds in system preferences 3 - Load the records detail page 4 - Add an item group on the item groups tab 5 - Select two items and add to the group 6 - Place a hold for a patron 7 - Confirm the three levels of holds are clear 8 - Confirm checking the radio next to one disables the others 9 - Confirm you can successfully place all 3 types of holds 10 - Confirm if placing a second hold that the type is forced correctly Signed-off-by: Hinemoea Viault <hinemoea.viault@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |samalau@gmail.com --- Comment #34 from Sam Lau <samalau@gmail.com> --- CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150786|0 |1 is obsolete| | --- Comment #35 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 151483 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151483&action=edit Bug 30579: Disentangle multi-hold and single bib forms This patch alters the structure of the hold request page to make it clear that "Hold next available", "Hold item group", and "Hold specific item" are mutually-exclusive options. While there is some duplication from this, it makes the sections easier to read and allows for more variation in the two forms To test: 1 - Find a bib with multiple items 2 - Enable item groups and item group holds in system preferences 3 - Load the records detail page 4 - Add an item group on the item groups tab 5 - Select two items and add to the group 6 - Place a hold for a patron 7 - Confirm the three levels of holds are clear 8 - Confirm checking the radio next to one disables the others 9 - Confirm you can successfully place all 3 types of holds 10 - Confirm if placing a second hold that the type is forced correctly Signed-off-by: hinemoea <hinemoea@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151483|0 |1 is obsolete| | --- Comment #36 from Sam Lau <samalau@gmail.com> --- Created attachment 151493 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151493&action=edit Bug 30579: Disentangle multi-hold and single bib forms This patch alters the structure of the hold request page to make it clear that "Hold next available", "Hold item group", and "Hold specific item" are mutually-exclusive options. While there is some duplication from this, it makes the sections easier to read and allows for more variation in the two forms To test: 1 - Find a bib with multiple items 2 - Enable item groups and item group holds in system preferences 3 - Load the records detail page 4 - Add an item group on the item groups tab 5 - Select two items and add to the group 6 - Place a hold for a patron 7 - Confirm the three levels of holds are clear 8 - Confirm checking the radio next to one disables the others 9 - Confirm you can successfully place all 3 types of holds 10 - Confirm if placing a second hold that the type is forced correctly Signed-off-by: hinemoea <hinemoea@inlibro.com> Signed-off-by: Sam Lau <samalau@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #38 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- That's better but we should do better in my opinion. First would be to have only 1 "place hold" button maybe? And hide the form when the related radio is not checked? Owen, what do you think? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #40 from Owen Leonard <oleonard@myacpl.org> --- I could see us using a Bootstrap Collapse to show the options, with the "next available" section displayed by default. I could also see us keeping this version with the addition of making sure that all form fields are disabled when the section isn't "active." We could even set the opacity of the inactive fieldsets to .5 or something like that in order to indicate that the controls are not available. I find that the pickup location dropdowns are not populating, and the form doesn't prevent me from placing the hold without selecting one. That must be resolved. I agree that a more detailed test plan would be helpful. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579 --- Comment #42 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 154882 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154882&action=edit Bug 30579: Add missing for attribute on label -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579 --- Comment #44 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Marcel de Rooy from comment #39)

I am not sure if this (simple) test plan covers all edge cases.

Test plan updated

Should this be marked as an enhancment?

Done (In reply to Owen Leonard from comment #40)

I could see us using a Bootstrap Collapse to show the options, with the "next available" section displayed by default.

I could also see us keeping this version with the addition of making sure that all form fields are disabled when the section isn't "active." We could even set the opacity of the inactive fieldsets to .5 or something like that in order to indicate that the controls are not available.

Follow-up patch will be attached

I find that the pickup location dropdowns are not populating, and the form doesn't prevent me from placing the hold without selecting one. That must be resolved.

I cannot recreate, can you retest? Can you confirm API is loading content on other pages like http://localhost:8081/cgi-bin/koha/admin/branches.pl -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579 --- Comment #45 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 154886 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154886&action=edit Bug 30579: (follow-up) Add fieldsets and style disabled elements This patch surrounds each section with a fieldset which allow enabling/disabling all the elements in one go. CSS is added to make it clear which fields are disabled. Button for item specific is moved form the multi-hold section Javascript is simplified to use the new fieldsets To test: 1 - Repeate test plan on earlier commit 2 - Additionally, search and select multiple records and place hold 3 - Confirm multi-hold placing works :-) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #46 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- I really like where this is going! I found a few more bugs in testing, but it seems to be nearly there. The only two that are definite blockers for me are some odd behavior with hold policy limits: - When trying to place a hold on an item group, I always got the prompt: "None of these items can normally be put on hold for this patron. Place hold?" although there should be nothing forbidding that hold. (with item group holds enabled and regardless of patron or AllowHoldPolicyOverride value) - The circ rule for maximum number of items allowed per record was not enforced for item-level holds. i.e. with a limit of 2, it was possible to place 3 item-level holds for the same patron even if overrides were not allowed. If overrides are allowed, there should be a warning at the top of the page, but the warning does not appear for a patron with the max number of item-level holds. Not necessarily blockers but would be nice to fix: - The select2's for pickup location are not actually disabled when the fieldset is disabled. (They are greyed out, and the data selected is not used, but they're still clickable.) Is this an oversight, or is it an unfortunate characteristic of select2's? (not necessarily a blocker for me because the visual cue and actual processing of data are correct) - When enforcing that a patron with an existing item-level hold may only place item-level holds, the heading for item-level holds says (Required) in bright red. Same thing for item group holds. However, the heading for record-level holds does not say (Required). (this is the case in master, but if it's easy to add in here for consistency, I'd say do it) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154881|0 |1 is obsolete| | Attachment #154882|0 |1 is obsolete| | Attachment #154883|0 |1 is obsolete| | Attachment #154886|0 |1 is obsolete| | --- Comment #47 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 157787 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157787&action=edit Bug 30579: Disentangle multi-hold and single bib forms This patch alters the structure of the hold request page to make it clear that "Hold next available", "Hold item group", and "Hold specific item" are mutually-exclusive options. While there is some duplication from this, it makes the sections easier to read and allows for more variation in the two forms To test: 1 - Find a bib with multiple items 2 - Enable item groups and item group holds in system preferences 3 - Load the records detail page 4 - Add an item group on the item groups tab 5 - Select two items and add to the group 6 - Click the 'Holds' tab and search for/select a patron 7 - Confirm the three levels of holds are clear 8 - Confirm checking the radio next to one disables the others 9 - Check 'Hold next available item from an item group' 10 - Do not select an item group 11 - Click 'Place hold' and confirm you are notified of need to select an item group NOTE: if you are overrirding you may also have an alert that the items cannot normally be put on hold 12 - Click 'Place hold on a specific item' - but do not select an item 13 - Click place hold and confirm there is an alert and you cannot continue 14 - Click 'Hold next available item' and place hold 15 - Hold is successfully placed 16 - Place another hold for the same patron 17 - Only the 'Hold next available item' form is enabled 18 - Confirm you cannot switch hold type 19 - Place hold 20 - Select a new patron and place an item group hold 21 - Select the same patron and place another hold - you are forced to place an item group hold 22 - Select a new patron and place a hold on a specific item 23 - Place a second hold, confirm you can only place it on a specific item Signed-off-by: hinemoea <hinemoea@inlibro.com> Signed-off-by: Sam Lau <samalau@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579 --- Comment #49 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 157789 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157789&action=edit Bug 30579: Remove doubled notes field -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579 --- Comment #51 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 157791 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157791&action=edit Bug 30579: (follow-up) Use same conditions on item groups place hold button as on other options -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579 --- Comment #53 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Emily Lamancusa from comment #46)

I really like where this is going! I found a few more bugs in testing, but it seems to be nearly there.

The only two that are definite blockers for me are some odd behavior with hold policy limits:

- When trying to place a hold on an item group, I always got the prompt: "None of these items can normally be put on hold for this patron. Place hold?" although there should be nothing forbidding that hold. (with item group holds enabled and regardless of patron or AllowHoldPolicyOverride value)

Button updated to fix this

- The circ rule for maximum number of items allowed per record was not enforced for item-level holds. i.e. with a limit of 2, it was possible to place 3 item-level holds for the same patron even if overrides were not allowed. If overrides are allowed, there should be a warning at the top of the page, but the warning does not appear for a patron with the max number of item-level holds.

I don't recreate this one

Not necessarily blockers but would be nice to fix:

- The select2's for pickup location are not actually disabled when the fieldset is disabled.

I don't see a way to accomplish this, I think it's just select2

- When enforcing that a patron with an existing item-level hold may only place item-level holds, the heading for item-level holds says (Required) in bright red.

Added -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157788|0 |1 is obsolete| | --- Comment #55 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 157938 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157938&action=edit Bug 30579: Add missing for attribute on label Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157790|0 |1 is obsolete| | --- Comment #57 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 157940 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157940&action=edit Bug 30579: (follow-up) Add fieldsets and style disabled elements This patch surrounds each section with a fieldset which allow enabling/disabling all the elements in one go. CSS is added to make it clear which fields are disabled. Button for item specific is moved form the multi-hold section Javascript is simplified to use the new fieldsets To test: 1 - Repeate test plan on earlier commit 2 - Additionally, search and select multiple records and place hold 3 - Confirm multi-hold placing works :-) Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157792|0 |1 is obsolete| | --- Comment #59 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 157942 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157942&action=edit Bug 30579: (follow-up) Add required label and warning when hold levels required Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579 --- Comment #61 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- Awesome, just tested the fixes and they all seem to be working! Adding a tiny follow-up patch to fix what I assume is a copy/paste error, though. In the "Use same conditions..." follow-up, shouldn't the button id still be "hold_grp_btn" though? (the patch changed it to "hold_any_btn")

...

- The circ rule for maximum number of items allowed per record was not enforced for item-level holds. i.e. with a limit of 2, it was possible to place 3 item-level holds for the same patron even if overrides were not allowed. If overrides are allowed, there should be a warning at the top of the page, but the warning does not appear for a patron with the max number of item-level holds.

I don't recreate this one

I'm not recreating it anymore either. Maybe it was just something weird on my end. I don't follow Koha's template logic well enough yet to be confident QAing this one, but I added an additional sign-off since I confirm everything worked as expected in my testing. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157937|0 |1 is obsolete| | Attachment #157938|0 |1 is obsolete| | Attachment #157939|0 |1 is obsolete| | Attachment #157940|0 |1 is obsolete| | Attachment #157941|0 |1 is obsolete| | Attachment #157942|0 |1 is obsolete| | Attachment #157943|0 |1 is obsolete| | --- Comment #63 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 163260 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163260&action=edit Bug 30579: Disentangle multi-hold and single bib forms This patch alters the structure of the hold request page to make it clear that "Hold next available", "Hold item group", and "Hold specific item" are mutually-exclusive options. While there is some duplication from this, it makes the sections easier to read and allows for more variation in the two forms To test: 1 - Find a bib with multiple items 2 - Enable item groups and item group holds in system preferences 3 - Load the records detail page 4 - Add an item group on the item groups tab 5 - Select two items and add to the group 6 - Click the 'Holds' tab and search for/select a patron 7 - Confirm the three levels of holds are clear 8 - Confirm checking the radio next to one disables the others 9 - Check 'Hold next available item from an item group' 10 - Do not select an item group 11 - Click 'Place hold' and confirm you are notified of need to select an item group NOTE: if you are overrirding you may also have an alert that the items cannot normally be put on hold 12 - Click 'Place hold on a specific item' - but do not select an item 13 - Click place hold and confirm there is an alert and you cannot continue 14 - Click 'Hold next available item' and place hold 15 - Hold is successfully placed 16 - Place another hold for the same patron 17 - Only the 'Hold next available item' form is enabled 18 - Confirm you cannot switch hold type 19 - Place hold 20 - Select a new patron and place an item group hold 21 - Select the same patron and place another hold - you are forced to place an item group hold 22 - Select a new patron and place a hold on a specific item 23 - Place a second hold, confirm you can only place it on a specific item Signed-off-by: hinemoea <hinemoea@inlibro.com> Signed-off-by: Sam Lau <samalau@gmail.com> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579 --- Comment #65 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 163262 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163262&action=edit Bug 30579: Remove doubled notes field Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579 --- Comment #67 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 163264 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163264&action=edit Bug 30579: (follow-up) Use same conditions on item groups place hold button as on other options Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579 --- Comment #69 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 163266 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163266&action=edit Bug 30579: (follow-up) fix button id Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |kyle@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hammat.wele@inlibro.com --- Comment #71 from Hammat wele <hammat.wele@inlibro.com> --- This patch and bz31579 have different logics This patch completely changes the form, with this patch you can either use “Hold next available item” (containing the “Pickup at” field), or “Place to hold on a specific item” since selecting one disables the other. However, bz31579 needs the “Pickup at” and “Place a hold on a specific item” fields to all be active since we configure the “Place a hold on a specific item” fields according to the value chosen in the field “Pickup at” which means that it is impossible to use both patches at the same time, we will have to make a choice between the two. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579 --- Comment #72 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Poke me in mattermost or slack when this is rebased and I'll jump straight on it. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163260|0 |1 is obsolete| | --- Comment #73 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 166012 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166012&action=edit Bug 30579: Disentangle multi-hold and single bib forms This patch alters the structure of the hold request page to make it clear that "Hold next available", "Hold item group", and "Hold specific item" are mutually-exclusive options. While there is some duplication from this, it makes the sections easier to read and allows for more variation in the two forms To test: 1 - Find a bib with multiple items 2 - Enable item groups and item group holds in system preferences 3 - Load the records detail page 4 - Add an item group on the item groups tab 5 - Select two items and add to the group 6 - Click the 'Holds' tab and search for/select a patron 7 - Confirm the three levels of holds are clear 8 - Confirm checking the radio next to one disables the others 9 - Check 'Hold next available item from an item group' 10 - Do not select an item group 11 - Click 'Place hold' and confirm you are notified of need to select an item group NOTE: if you are overrirding you may also have an alert that the items cannot normally be put on hold 12 - Click 'Place hold on a specific item' - but do not select an item 13 - Click place hold and confirm there is an alert and you cannot continue 14 - Click 'Hold next available item' and place hold 15 - Hold is successfully placed 16 - Place another hold for the same patron 17 - Only the 'Hold next available item' form is enabled 18 - Confirm you cannot switch hold type 19 - Place hold 20 - Select a new patron and place an item group hold 21 - Select the same patron and place another hold - you are forced to place an item group hold 22 - Select a new patron and place a hold on a specific item 23 - Place a second hold, confirm you can only place it on a specific item Signed-off-by: hinemoea <hinemoea@inlibro.com> Signed-off-by: Sam Lau <samalau@gmail.com> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163262|0 |1 is obsolete| | --- Comment #75 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 166014 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166014&action=edit Bug 30579: Remove doubled notes field Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163264|0 |1 is obsolete| | --- Comment #77 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 166016 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166016&action=edit Bug 30579: (follow-up) Use same conditions on item groups place hold button as on other options Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163266|0 |1 is obsolete| | --- Comment #79 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 166018 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166018&action=edit Bug 30579: (follow-up) fix button id Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579 --- Comment #81 from Nick Clemens <nick@bywatersolutions.com> --- Looks like there was an addition when using item groups to list the items and to list (disabled) groups with no items - so should define an item group with no items for testing -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166013|0 |1 is obsolete| | --- Comment #83 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 166035 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166035&action=edit Bug 30579: Add missing for attribute on label Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166015|0 |1 is obsolete| | --- Comment #85 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 166037 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166037&action=edit Bug 30579: (follow-up) Add fieldsets and style disabled elements This patch surrounds each section with a fieldset which allow enabling/disabling all the elements in one go. CSS is added to make it clear which fields are disabled. Button for item specific is moved form the multi-hold section Javascript is simplified to use the new fieldsets To test: 1 - Repeate test plan on earlier commit 2 - Additionally, search and select multiple records and place hold 3 - Confirm multi-hold placing works :-) Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166017|0 |1 is obsolete| | --- Comment #87 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 166039 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166039&action=edit Bug 30579: (follow-up) Add required label and warning when hold levels required Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166019|0 |1 is obsolete| | --- Comment #89 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 166041 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166041&action=edit Bug 30579: (follow-up) Remove unnecessary nested form elements Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134468|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166034|0 |1 is obsolete| | --- Comment #91 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 166074 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166074&action=edit Bug 30579: Disentangle multi-hold and single bib forms This patch alters the structure of the hold request page to make it clear that "Hold next available", "Hold item group", and "Hold specific item" are mutually-exclusive options. While there is some duplication from this, it makes the sections easier to read and allows for more variation in the two forms To test: 1 - Find a bib with multiple items 2 - Enable item groups and item group holds in system preferences 3 - Load the records detail page 4 - Add an item group on the item groups tab 5 - Select two items and add to the group 6 - Click the 'Holds' tab and search for/select a patron 7 - Confirm the three levels of holds are clear 8 - Confirm checking the radio next to one disables the others 9 - Check 'Hold next available item from an item group' 10 - Do not select an item group 11 - Click 'Place hold' and confirm you are notified of need to select an item group NOTE: if you are overrirding you may also have an alert that the items cannot normally be put on hold 12 - Click 'Place hold on a specific item' - but do not select an item 13 - Click place hold and confirm there is an alert and you cannot continue 14 - Click 'Hold next available item' and place hold 15 - Hold is successfully placed 16 - Place another hold for the same patron 17 - Only the 'Hold next available item' form is enabled 18 - Confirm you cannot switch hold type 19 - Place hold 20 - Select a new patron and place an item group hold 21 - Select the same patron and place another hold - you are forced to place an item group hold 22 - Select a new patron and place a hold on a specific item 23 - Place a second hold, confirm you can only place it on a specific item Signed-off-by: hinemoea <hinemoea@inlibro.com> Signed-off-by: Sam Lau <samalau@gmail.com> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166036|0 |1 is obsolete| | --- Comment #93 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 166076 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166076&action=edit Bug 30579: Remove doubled notes field Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166038|0 |1 is obsolete| | --- Comment #95 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 166078 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166078&action=edit Bug 30579: (follow-up) Use same conditions on item groups place hold button as on other options Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166040|0 |1 is obsolete| | --- Comment #97 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 166080 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166080&action=edit Bug 30579: (follow-up) fix button id Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579 --- Comment #99 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 166082 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166082&action=edit Bug 30579: Fix rebase issue -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #101 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Tiny bit torn about this one, it makes things clearer, but it adds a click... but yes, I can see why we are doing this. Still... sadly found some blockers that prevent me from pushing this right now. Please follow-up quickly! If not marked as blocker, it's also good for a later follow-up. 1) Standardize headings We have: Hold next available item Place a hold on a specific item We could do: Hold on next available item Hold on a specific item OR Place hold on next available item Place hold on a specific item Tend to the first, because it's a little shorter. 2) Usability I know that I can click on the text instead of into the radio box, but from the formatting that is not visually clear. Could we think about replacing the checkboxes for an element that makes for a bigger "click target" visually? 3) Multi-holds result in a CSRF error (blocker) Programming error - No CSRF token passed for POST http://localhost:8081/intranet/reserve/placerequest.pl (referer: http://localhost:8081/cgi-bin/koha/reserve/request.pl?biblionumber=262&biblionumber=5&biblionumber=13&biblionumber=146&biblionumber=191&biblionumber=11&biblionumber=126&biblionumber=139&biblionumber=165&biblionumber=255&biblionumber=115&multi_hold=1&borrowernumber=19) 4) Multi-holds missing pick-up location and other options (blocker) If you do a lot of holds at once, the pick-up location at the top allowed you to set them all at once. now this option and others, like "hold expires on" and "notes" are completely gone. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579 --- Comment #103 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Andrew Fuerste-Henry from comment #102)

(In reply to Katrin Fischer from comment #101)

...

4) Multi-holds missing pick-up location and other options (blocker)

If you do a lot of holds at once, the pick-up location at the top allowed you to set them all at once. now this option and others, like "hold expires on" and "notes" are completely gone.

I can't recreate this. Or maybe it's more a question of clarity of interface? Anything I set in the top "Hold details" section of the page is applied to all holds created, regardless of choices lower in the page. When I entered notes and hold expiration date, those values were applied to all holds created via multi-hold, just as they were applied to individual bib- or item-level holds.

Maybe I should have been more clear: I am placing multiple holds on different records by selecting them in the staff interface result list. The hold details section is completely missing on top of the table. Can you check if that is the same thing you were looking at? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579 --- Comment #105 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I know people are keen on this from the activity - it's still on the table, but we will need to hurry a little. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166074|0 |1 is obsolete| | Attachment #166075|0 |1 is obsolete| | Attachment #166076|0 |1 is obsolete| | Attachment #166077|0 |1 is obsolete| | Attachment #166078|0 |1 is obsolete| | Attachment #166079|0 |1 is obsolete| | Attachment #166080|0 |1 is obsolete| | Attachment #166081|0 |1 is obsolete| | Attachment #166082|0 |1 is obsolete| | --- Comment #106 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 166264 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166264&action=edit Bug 30579: Disentangle multi-hold and single bib forms This patch alters the structure of the hold request page to make it clear that "Hold next available", "Hold item group", and "Hold specific item" are mutually-exclusive options. While there is some duplication from this, it makes the sections easier to read and allows for more variation in the two forms To test: 1 - Find a bib with multiple items 2 - Enable item groups and item group holds in system preferences 3 - Load the records detail page 4 - Add an item group on the item groups tab 5 - Select two items and add to the group 6 - Click the 'Holds' tab and search for/select a patron 7 - Confirm the three levels of holds are clear 8 - Confirm checking the radio next to one disables the others 9 - Check 'Hold next available item from an item group' 10 - Do not select an item group 11 - Click 'Place hold' and confirm you are notified of need to select an item group NOTE: if you are overrirding you may also have an alert that the items cannot normally be put on hold 12 - Click 'Place hold on a specific item' - but do not select an item 13 - Click place hold and confirm there is an alert and you cannot continue 14 - Click 'Hold next available item' and place hold 15 - Hold is successfully placed 16 - Place another hold for the same patron 17 - Only the 'Hold next available item' form is enabled 18 - Confirm you cannot switch hold type 19 - Place hold 20 - Select a new patron and place an item group hold 21 - Select the same patron and place another hold - you are forced to place an item group hold 22 - Select a new patron and place a hold on a specific item 23 - Place a second hold, confirm you can only place it on a specific item Signed-off-by: hinemoea <hinemoea@inlibro.com> Signed-off-by: Sam Lau <samalau@gmail.com> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579 --- Comment #108 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 166266 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166266&action=edit Bug 30579: Remove doubled notes field Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579 --- Comment #110 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 166268 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166268&action=edit Bug 30579: (follow-up) Use same conditions on item groups place hold button as on other options Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579 --- Comment #112 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 166270 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166270&action=edit Bug 30579: (follow-up) fix button id Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579 --- Comment #114 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 166272 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166272&action=edit Bug 30579: Fix rebase issue -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579 --- Comment #116 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 166274 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166274&action=edit Bug 30579: (follow-up) Standardize labels: This patch changes the heading for specific item holds, so the three options are now: Hold next available item Hold next available item from an item group Hold a specific item -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579 --- Comment #118 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am not persuaded by the current "design" of the radiobox buttons, but maybe we can get some help there if we ask really nicely as a follow-up? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579 --- Comment #120 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #118)

I am not persuaded by the current "design" of the radiobox buttons, but maybe we can get some help there if we ask really nicely as a follow-up?

Agree. Also, inputs as children of a button creates invalid HTML. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |36899 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36899 [Bug 36899] Further improvements to holds request page, part 2 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #121 from Fridolin Somers <fridolin.somers@biblibre.com> --- Not backported to 23.11.x -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|martin.renvoize@ptfs-europe | |.com | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |Needs documenting Resolution|FIXED |--- --- Comment #123 from David Nind <david@davidnind.com> --- Changing the status to "Needs documenting" - these changes need reflecting in the manual. -- You are receiving this mail because: You are watching all bug changes.