[Bug 8408] New: Odd OPAC message when OPAC Renewals are disabled and OPACFineNoRenewals is set to blank
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8408 Priority: P5 - low Change sponsored?: --- Bug ID: 8408 Assignee: oleonard@myacpl.org Summary: Odd OPAC message when OPAC Renewals are disabled and OPACFineNoRenewals is set to blank Severity: enhancement Classification: Unclassified OS: All Reporter: kyle.m.hall@gmail.com Hardware: All Status: NEW Version: master Component: OPAC Product: Koha If OpacRenewalAllowed is set to "Don't allow" and OPACFineNoRenewals is set to blank ( i.e. disabled ). A user who owes any fines, when logged in to the OPAC will receive the following message: Please note: You have more than 0.00 in fines. This is a rather odd message, and is not very sensible. The message should either be modified or removed altogether. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8408 --- Comment #1 from Kyle M Hall <kyle.m.hall@gmail.com> --- Created attachment 10750 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10750&action=edit Bug 8408 - Odd OPAC message when OPAC Renewals are disabled and OPACFineNoRenewals is set to blank If OpacRenewalAllowed is set to "Don't allow" and OPACFineNoRenewals is set to blank ( i.e. disabled ). A user who owes any fines, when logged in to the OPAC will receive the following message: Please note: You have more than 0.00 in fines. This is a rather odd message, and is not very sensible. The message should either be modified or removed altogether. This patch modifies the message to the following: Please note: You currently owe $fines in fines where $fines in the formatted amount the borrower currently owes in fines. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8408 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8408 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |veron@veron.ch --- Comment #2 from Marc Véron <veron@veron.ch> --- Wanted to sign-off, patch does not apply, sorry. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8408 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10750|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 11200 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11200&action=edit [SIGNED-OFF] Bug 8408 - Odd OPAC message when OPAC Renewals are disabled and OPACFineNoRenewals is set to blank If OpacRenewalAllowed is set to "Don't allow" and OPACFineNoRenewals is set to blank ( i.e. disabled ). A user who owes any fines, when logged in to the OPAC will receive the following message: Please note: You have more than 0.00 in fines. This is a rather odd message, and is not very sensible. The message should either be modified or removed altogether. This patch modifies the message to the following: Please note: You currently owe $fines in fines where $fines in the formatted amount the borrower currently owes in fines. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8408 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off Assignee|oleonard@myacpl.org |kyle@bywatersolutions.com --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- The patch applied fine for me, and works to fix the problem described. Looking at the way that message is constructed makes me worry about its translatability, but that can be addressed in another bug. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8408 --- Comment #5 from Marc Véron <veron@veron.ch> --- Was about to sign off as well :-) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8408 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart@biblibre.co | |m --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- This patch fixes the reported issue. Marking as Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8408 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain@biblibre.com Version|master |rel_3_8 Severity|enhancement |minor --- Comment #7 from Paul Poulain <paul.poulain@biblibre.com> --- More a minor bugfix than an ENH I think, bumping severity -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8408 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |In Discussion CC| |chris@bigballofwax.co.nz --- Comment #8 from Chris Cormack <chris@bigballofwax.co.nz> --- This changes the behaviour, Now instead of telling them they are blocked from renewing because they owe over the fine threshold, it just tells them how much they owe. (which they can see on their user page) So they don't know how much they have to pay to be able to renew again. I don't know if this is a good thing or not, or to change the behaviour was a conscious decision? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8408 --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to comment #8)
This changes the behaviour,
Now instead of telling them they are blocked from renewing because they owe over the fine threshold, it just tells them how much they owe.
This message never told the user they were blocked from renewing, it is the message given if OpacRenewalAllowed is disabled. The previous message was "Please note: You have more than X.XX in fines." I don't think this is radically different. If you think is should mention renewing items, I can add that. On another not, it appears that this patch has been pushed to master. I just noticed this patch breaks the OpacRenewalAllowed version of the message. I will write a followup to address this issue. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8408 --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 11323 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11323&action=edit Bug 8408 - Followup - Fix broken messages. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8408 --- Comment #11 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 11324 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11324&action=edit Bug 8408 - Followup 2 - Add reference to renewing items. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8408 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8408 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8408 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11200|0 |1 is obsolete| | Attachment #11323|0 |1 is obsolete| | Attachment #11324|0 |1 is obsolete| | --- Comment #12 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Created attachment 11555 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11555&action=edit Bug 8408 - Followup - Fix broken messages. Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8408 --- Comment #13 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Created attachment 11556 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11556&action=edit Bug 8408 - Followup 2 - Add reference to renewing items. Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8408 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #14 from Jonathan Druart <jonathan.druart@biblibre.com> --- Last patches just change strings. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8408 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #15 from Paul Poulain <paul.poulain@biblibre.com> --- Follow-up pushed to master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8408 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #16 from Chris Cormack <chris@bigballofwax.co.nz> --- Released in 3.10.0 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org