[Bug 31117] New: Cloning standard circulation rules for all libraries show up as from '*'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31117 Bug ID: 31117 Summary: Cloning standard circulation rules for all libraries show up as from '*' Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: florian.bontemps@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Created attachment 137327 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137327&action=edit Picture for exemple When cloning circulation and fine rules using the "Standard rules for all libraries" default option to another library, the confirmation title after wards shows up as : Cloning circulation and fine rules from "" to "Centerville" Because the default option has no real label, it doesn't show up. This doesn't affect the cloning feature, this is purely an text issue. You can see an exemple on the attached picture. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31117 --- Comment #1 from Florian <florian.bontemps@biblibre.com> --- Created attachment 137328 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137328&action=edit Bug 31117: New message for cloning standard rules This commit adds a different message when cloning circulation and fine rules if you use the Standard rules for all libraries option. Test plan : 1. Go to the Circulation and fine rules page in the Admin tab. 2. Check that the 'Select a library' menu is on 'Standard rules for all libraries'. 3. Check that you also have some random rules to clone, or create some. 4. Clone these rules to the library of your choice. 5. Confirm that the message 'Clone circulation and fine rules from "" to (library of your choice)' appears. 6. Now clone rules from a specific library to another one, and repeat steps 3-4. 7. Confirm that this time, the message will displays both libraries properly. 8. Apply patch. 9. Repeat steps 2 to 4 and 6 to 7. Confirm that this time, the message in the first case will be 'Cloning circulation and fine rules to "(library of your choice)"'. 10. Kindly sign off. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31117 Emmanuel Bétemps <e.betemps@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |e.betemps@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31117 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137328|0 |1 is obsolete| | --- Comment #2 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 137329 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137329&action=edit Bug 31117: New message for cloning standard rules This commit adds a different message when cloning circulation and fine rules if you use the Standard rules for all libraries option. Test plan : 1. Go to the Circulation and fine rules page in the Admin tab. 2. Check that the 'Select a library' menu is on 'Standard rules for all libraries'. 3. Check that you also have some random rules to clone, or create some. 4. Clone these rules to the library of your choice. 5. Confirm that the message 'Clone circulation and fine rules from "" to (library of your choice)' appears. 6. Now clone rules from a specific library to another one, and repeat steps 3-4. 7. Confirm that this time, the message will displays both libraries properly. 8. Apply patch. 9. Repeat steps 2 to 4 and 6 to 7. Confirm that this time, the message in the first case will be 'Cloning circulation and fine rules to "(library of your choice)"'. 10. Kindly sign off. Signed-off-by: Emmanuel Bétemps <e.betemps@gmail.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31117 --- Comment #3 from Emmanuel Bétemps <e.betemps@gmail.com> --- Actually, the message for the 1st case AFTER applying the patch is : Cloning circulation and fine rules from standard rules to "(library of your choice)" Your testplan says : Cloning circulation and fine rules to "(library of your choice)" But I think the typo is in the test plan because the sentence displayed (when patch applies) really fits. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31117 Emmanuel Bétemps <e.betemps@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31117 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Emmanuel, I think you are right, the sentence fits, we don't need to have the exact same wording. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31117 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31117 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137329|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 137404 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137404&action=edit Bug 31117: New message for cloning standard rules This commit adds a different message when cloning circulation and fine rules if you use the Standard rules for all libraries option. Test plan : 1. Go to the Circulation and fine rules page in the Admin tab. 2. Check that the 'Select a library' menu is on 'Standard rules for all libraries'. 3. Check that you also have some random rules to clone, or create some. 4. Clone these rules to the library of your choice. 5. Confirm that the message 'Clone circulation and fine rules from "" to (library of your choice)' appears. 6. Now clone rules from a specific library to another one, and repeat steps 3-4. 7. Confirm that this time, the message will displays both libraries properly. 8. Apply patch. 9. Repeat steps 2 to 4 and 6 to 7. Confirm that this time, the message in the first case will be 'Cloning circulation and fine rules to "(library of your choice)"'. 10. Kindly sign off. Signed-off-by: Emmanuel Bétemps <e.betemps@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31117 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31117 --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31117 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00 |22.11.00, 22.05.04 released in| | CC| |lucas@bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 22.05.x for 22.05.04 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31117 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arthur.suzuki@biblibre.com Status|Pushed to stable |Pushed to oldstable Version(s)|22.11.00, 22.05.04 |22.11.00, 22.05.04, released in| |21.11.11 --- Comment #8 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Salut Florian, Bravo pour ce patch, il rejoint la 21.11 en version 21.11.11! backported to 21.11.x for 21.11.11 thx! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31117 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED CC| |victor@tuxayo.net --- Comment #9 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document, marking resolved. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org