[Bug 17441] New: t/db_dependent/Letters.t fails on Jenkins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17441 Bug ID: 17441 Summary: t/db_dependent/Letters.t fails on Jenkins Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris@bigballofwax.co.nz Reporter: katrin.fischer@bsz-bw.de QA Contact: gmcharlt@gmail.com Attached patch will fix t/db_dependent/Letters.t from failing on Jenkins. The code is from Jonathan, debugging the problem on my laptop. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17441 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17441 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 56438 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56438&action=edit Bug 17441 - t/db_dependent/Letters.t fails on Jenkins Run prove t/db_dependent/Letters.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17441 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |5260 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260 [Bug 5260] Add option to send an order by e-mail to the acquisition module -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17441 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17441 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56438|0 |1 is obsolete| | --- Comment #2 from Claire Gravely <claire_gravely@hotmail.com> --- Created attachment 56462 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56462&action=edit Bug 17441 - t/db_dependent/Letters.t fails on Jenkins Run prove t/db_dependent/Letters.t Signed-off-by: Claire Gravely <claire_gravely@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17441 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl QA Contact|gmcharlt@gmail.com |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17441 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Trivial patch |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17441 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56462|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 56491 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56491&action=edit Bug 17441 - t/db_dependent/Letters.t fails on Jenkins Run prove t/db_dependent/Letters.t Signed-off-by: Claire Gravely <claire_gravely@hotmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> To improve consistency, adding a follow-up. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17441 --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 56492 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56492&action=edit Bug 17441: [QA Follow-up] Return value of SendAlerts This patch makes the return value of SendAlerts more consistent. It returns 1 on success, or undef || { error => 'msg' } on failure. Needed to adjust one test in Letters.t too. Adjusted one typo along the way (seleted). Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Tested by running Letters.t. Also tested SendAlerts from the interface with AutoEmailOpacUser and memberentry (adding new patron). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17441 --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> ---
From Jenkins: # Failed test 'Successfully sent claim' # at t/db_dependent/Letters.t line 431. # got: undef # expected: '1' # Looks like you failed 1 test of 74. [15:18:31] t/db_dependent/Letters.t ..................................
By returning 1, you will resolve this issue on Jenkins. But the change itself is somewhat obscure now. Looking further, we never really defined what SendAlerts should really return. In most cases we call like: $err=SendAlerts(...) In some cases SendAlerts warns and returns undef on an error. Or carps and returns { error => ... } Another line in Letters.t tests the results of SendAlerts with is($err2, "", "Successfully sent serial notification"); Added a follow-up to return 1 on success and add some consistency on the sendmail calls in SendAlerts. Adjusted the one line in Letters.t. Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17441 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17446 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17446 [Bug 17446] Remove some seleted typos -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17441 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan@bywatersolutions.co | |m --- Comment #6 from Brendan Gallagher <brendan@bywatersolutions.com> --- Pushed to Master - Should be in the November 16.11 Release. Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17441 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |frederic@tamil.fr --- Comment #7 from Frédéric Demians <frederic@tamil.fr> --- Pushed in 16.05. Will be in 16.05.05. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17441 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com --- Comment #8 from Julian Maurice <julian.maurice@biblibre.com> --- Pushed in 3.22.x, will be in 3.22.12 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org