[Bug 12717] New: Library no longer receiving Overdue email for patrons without email address
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12717 Bug ID: 12717 Summary: Library no longer receiving Overdue email for patrons without email address Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org With bug 10832 the handling of overdue emails has changes. Now if a patron has no email address, there is a 'print' message generated. Before MTT was pushed overdues for patrons without email addresses would automatically be sent to the library as an attachement to an email and could be printed from there. I don't see how this can be done now, but I might be missing a configuration option. Right now it looks like a regression for libraries not using server generated files. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12717 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10832 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12717 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- The described behaviour is still in the documentation of overdue_notices.pl: http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=misc/cronjobs/over... 192 =head2 Outgoing emails 193 194 Typically, messages are prepared for each patron with overdue 195 items. Messages for whom there is no email address on file are 196 collected and sent as attachments in a single email to each library 197 administrator, or if that is not set, then to the email address in the 198 C<KohaAdminEmailAddress> system preference. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12717 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12717 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #2 from David Cook <dcook@prosentient.com.au> --- (In reply to Katrin Fischer from comment #0)
With bug 10832 the handling of overdue emails has changes. Now if a patron has no email address, there is a 'print' message generated.
Before MTT was pushed overdues for patrons without email addresses would automatically be sent to the library as an attachement to an email and could be printed from there.
I don't see how this can be done now, but I might be missing a configuration option. Right now it looks like a regression for libraries not using server generated files.
I think there is also an issue with the former HOLD_PRINT notices as well. http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10845#c37 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12717 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com, | |nengard@gmail.com Severity|major |critical --- Comment #3 from Nicole C. Engard <nengard@gmail.com> --- Upgrading severity, this is a big issue for libraries in rural areas with many patrons who do not have email addresses. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12717 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Ok,to make things worse, I am having trouble generating the files. I tried: overdue_notices.pl -html ./ Generates an empty HTML flie overdue_notices.pl -csv ./ Generates an CSV file with the header line, but no data gather_print_notices.pl ./ Generates a file named holdnotices-2014-08-16.html with my overdue letter ? This seems currently seriously broken. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12717 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- overdue_notices.pl -text ./ Empty txt file. BUT: -n will get -csv -html and -text working again. But it is NOT a solution, as it will not just grab the notices that are supposed to be printed, but will grab them all and no emails will be generated.
From the documentation: -n Do not send any email. Overdue notices that would have been sent to the patrons or to the admin are printed to standard out. CSV data (if the -csv flag is set) is written to standard out or to any csv filename given.
-- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12717 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Still testing - one patron with email address and one without, both generating an overdue notice today. I think the options I tested before all work like they should, but they offer no solution to the problem. So I tried to make sure the old behaviour was as described. I found it working before the MTT changes, with: git checkout 9834401c59ed2ac41ca354732a528a117404fb76 ./misc/cronjobs/overdue_notices.pl (no parameters) Generates an email to the patron and one to the library with the text version as attachement. One of the differences between then and now is, that we now have an entry 'print' in the message_queue for the patrons without email. So we need to make sure that we can send an email with the overdue notices attached and set those enries to 'sent'. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12717 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |jonathan.druart@biblibre.co | |m Assignee|koha-bugs@lists.koha-commun |jonathan.druart@biblibre.co |ity.org |m --- Comment #7 from Jonathan Druart <jonathan.druart@biblibre.com> --- I will try to provide a fix soon. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12717 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12717 --- Comment #8 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 31022 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31022&action=edit Bug 12717: Library no longer receiving Overdue email for patrons without email address Bug 10832 changes the fallback behavior if a patron does not have email address: a print notice is generated into the message_queue table. But this can cause issue for some libraries. The script should sent an email and (generated csv, html, text file) with the list of all unsent notices. Test plan: 1/ Add overdue to a patron without email address (or smsalertnumber) 2/ Check email in the overdue rules configuration (or sms) 3/ Launch the overdue_notices.pl cronjob 4/ Verify the message_queue contain a print notice AND an email notice for the library -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12717 --- Comment #9 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to David Cook from comment #2)
I think there is also an issue with the former HOLD_PRINT notices as well. http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10845#c37
Could you please detail what could be wrong with HOLD? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12717 Larry Baerveldt <larry@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12810 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12717 Larry Baerveldt <larry@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |larry@bywatersolutions.com --- Comment #10 from Larry Baerveldt <larry@bywatersolutions.com> --- I realize a patch has already been written for this, but I'm wondering if this is the best way to go. For example, since gather_print_notices now seems to include all print notices, holds plus overdues, etc. (see bug 12810), and since Jonathan is working on a patch to get gather_print_notices to email files, maybe that should become that standard way of getting print notices, of all types, to the library staff. So, update gather_print_notices so that it's no longer "holds"-specific (i.e. stop naming the output file 'holdnotices...'), or possibly even have it output to different files depending on the type of notice. Then with the patch for bug 11678 in place, those would be emailed to the library, without the need to have the overdues cronjob email them. Something to consider. - Larry -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12717 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think moving to a file based solution long term is good - but this was a feature libraries were relying to and I think we should bring it back AND work towards replacing it by gather_print_notices.pl long term. Right now the other script doesn't offer the same functionality and overdues.pl can already create different output formats. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12717 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- How I wish you could correct your bugzilla entries at times... Trying again to make more sense: I think moving to gather_print_notices.pl long term is good - but this is a feature libraries are relying on currently that got broken accidentally. I think we should bring it back for now AND work towards offering another option with gather_print_notices.pl. At the moment gather_print_notices.pl doesn't offer the same functionality and overdues.pl can already create different output formats. - I haven't tested the patch yet, but it looks rather small and I hope it will fix the problem. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12717 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #13 from Chris Cormack <chris@bigballofwax.co.nz> --- I agree with Katrin, lets get the accidentally removed functionality back, then work on extending the gather_print_notices to do the same. There are a lot of libraries using this, and if they upgraded from 3.14.x to 3.16.x would experience a regression that they may not even notice for a few days. Until they wondered, why arent we getting emails anymore .. and then its too late to send out the notices. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12717 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12717 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31022|0 |1 is obsolete| | --- Comment #14 from Nick Clemens <nick@quecheelibrary.org> --- Created attachment 31124 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31124&action=edit [SIGNED OFF] Bug 12717: Library no longer receiving Overdue email for patrons without email address Bug 10832 changes the fallback behavior if a patron does not have email address: a print notice is generated into the message_queue table. But this can cause issue for some libraries. The script should sent an email and (generated csv, html, text file) with the list of all unsent notices. Test plan: 1/ Add overdue to a patron without email address (or smsalertnumber) 2/ Check email in the overdue rules configuration (or sms) 3/ Launch the overdue_notices.pl cronjob 4/ Verify the message_queue contain a print notice AND an email notice for the library Signed-off-by: Nick Clemens <nick@quecheelibrary.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12717 --- Comment #15 from Larry Baerveldt <larry@bywatersolutions.com> --- I'm fine with restoring the functionality of overdues that was lost. However, we still need to address Bug 12810. Once this bug has been fixed, then a library that's also using gather_print_notices for holds will be getting multiple print overdue messages, one from overdues via email and another in the gather_print_notices output file. Regards, Larry -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12717 --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Larry, I agree. Having the overdues in the holdnotices file doesn't make sense and we need to make changes there as well. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12717 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12717 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31124|0 |1 is obsolete| | --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 31163 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31163&action=edit [PASSED QA] Bug 12717: Library no longer receiving Overdue email for patrons without email address Bug 10832 changes the fallback behavior if a patron does not have email address: a print notice is generated into the message_queue table. But this can cause issue for some libraries. The script should sent an email and (generated csv, html, text file) with the list of all unsent notices. Test plan: 1/ Add overdue to a patron without email address (or smsalertnumber) 2/ Check email in the overdue rules configuration (or sms) 3/ Launch the overdue_notices.pl cronjob 4/ Verify the message_queue contain a print notice AND an email notice for the library Signed-off-by: Nick Clemens <nick@quecheelibrary.org> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> This works as described and restores the old behaviour for now, with the difference that you have a print notice generated and visible in the patron account notices tab that will say 'pending'. We will have to figure out how we can change the workflows nicely to have only one script deal with print notice in the future. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12717 --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- What could be the next step? Things I can think off: - offer an option for the script not to send the email to the library, adjust the documentation in the script? - work on 11603 in order to make it possible to email files with gather_print_notices.pl? - add gather_print_notices.pl to the default cronjob files? - verify that gather_print_notices.pl can be set up to work similar/better than overduenotices now? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12717 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #19 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12717 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_4_candidate CC| |gmcharlt@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12717 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #20 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to 3.16.x for inclusion in 3.16.4. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12717 Heather Braum <hbraum@nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum@nekls.org -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12717 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED CC| |fridolyn.somers@biblibre.co | |m --- Comment #21 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Bug 10832 is not in 3.14.x so this one is not needed. I set as resolved -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org