[Bug 16608] New: Missing entity nbsp in some XML files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16608 Bug ID: 16608 Summary: Missing entity nbsp in some XML files Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: fridolin.somers@biblibre.com QA Contact: testopia@bugs.koha-community.org The special character "non breaking space" is not contained in XML syntax by default. So we add it in the file header : <!DOCTYPE stylesheet [<!ENTITY nbsp " " >]> Even if the source code files do no contain this character, it can be that translated files contain it. French for example "Titre :". This entity is missing in all files in koha-tmpl/intranet-tmpl/prog/en/data/ and in some files of koha-tmpl/intranet-tmpl/prog/en/xslt. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16608 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |fridolin.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16608 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |7141 Status|NEW |ASSIGNED --- Comment #1 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Same issue as Bug 7141 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7141 [Bug 7141] The biblio details page in the intranet doesn't work if XSLT is activated and the xsl file contains " " -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16608 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16608 --- Comment #2 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 51862 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51862&action=edit Bug 16608 - Add xsld extension to t/00-valid-xml.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16608 --- Comment #3 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 51863 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51863&action=edit Bug 16608 - Add xsd extension to t/00-valid-xml.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16608 --- Comment #4 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 51864 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51864&action=edit Bug 16608 - Missing entity nbsp in some XML files The special character "non breaking space" is not contained in XML syntax by default. So we add it in the file header : <!DOCTYPE stylesheet [<!ENTITY nbsp " " >]> Even if the source code files do no contain this character, it can be that translated files contain it. French for example "Titre :". This entity is missing in all files in koha-tmpl/intranet-tmpl/prog/en/data/ and in some files of koha-tmpl/intranet-tmpl/prog/en/xslt. Test plan : - generate French templates: cd misc/translator ./translate install fr-FR cd ../.. - run test: prove -v t/00-valid-xml.t you get failing error message - apply this patch - translate again - run test again: it passes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16608 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51862|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16608 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51863|0 |1 is obsolete| | --- Comment #5 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 51886 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51886&action=edit [SIGNED-OFF] Bug 16608 - Add xsd extension to t/00-valid-xml.t Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16608 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51864|0 |1 is obsolete| | --- Comment #6 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 51887 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51887&action=edit [SIGNED-OFF] Bug 16608 - Missing entity nbsp in some XML files The special character "non breaking space" is not contained in XML syntax by default. So we add it in the file header : <!DOCTYPE stylesheet [<!ENTITY nbsp " " >]> Even if the source code files do no contain this character, it can be that translated files contain it. French for example "Titre :". This entity is missing in all files in koha-tmpl/intranet-tmpl/prog/en/data/ and in some files of koha-tmpl/intranet-tmpl/prog/en/xslt. Test plan : - generate French templates: cd misc/translator ./translate install fr-FR cd ../.. - run test: prove -v t/00-valid-xml.t you get failing error message - apply this patch - translate again - run test again: it passes Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Works as described following test plan Tes pass, no errors. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16608 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16608 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16608 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51886|0 |1 is obsolete| | Attachment #51887|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 52231 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52231&action=edit Bug 16608 - Add xsd extension to t/00-valid-xml.t Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16608 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 52232 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52232&action=edit Bug 16608 - Missing entity nbsp in some XML files The special character "non breaking space" is not contained in XML syntax by default. So we add it in the file header : <!DOCTYPE stylesheet [<!ENTITY nbsp " " >]> Even if the source code files do no contain this character, it can be that translated files contain it. French for example "Titre :". This entity is missing in all files in koha-tmpl/intranet-tmpl/prog/en/data/ and in some files of koha-tmpl/intranet-tmpl/prog/en/xslt. Test plan : - generate French templates: cd misc/translator ./translate install fr-FR cd ../.. - run test: prove -v t/00-valid-xml.t you get failing error message - apply this patch - translate again - run test again: it passes Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Works as described following test plan Tes pass, no errors. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16608 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle@bywatersolutions.com --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 16.11, thanks Frido! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16608 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr --- Comment #10 from Frédéric Demians <frederic@tamil.fr> --- Pushed in 16.05. Will be in 16.05.01. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16608 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice@biblibre.com --- Comment #11 from Julian Maurice <julian.maurice@biblibre.com> --- Patches pushed to 3.22.x, will be in 3.22.8 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org