[Bug 26032] New: Add 'is new' filter in items search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26032 Bug ID: 26032 Summary: Add 'is new' filter in items search Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: koha-bugs@lists.koha-community.org Reporter: fridolin.somers@biblibre.com QA Contact: testopia@bugs.koha-community.org In items search, add a filter on value of items.new_status with a Ignore/Yes/No. Yes meaning != 0, No meaning = 0, with considering that NULL value is like 0. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26032 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |fridolin.somers@biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26032 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26032 --- Comment #1 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 107141 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107141&action=edit Bug 26032: Add unit test Run prove t/db_dependent/Items.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26032 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24443 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26032 --- Comment #2 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 107142 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107142&action=edit Bug 26032: Add 'is new' filter in items search In items search, add a filter on value of items.new_status with a Ignore/Yes/No. Yes meaning != 0, No meaning = 0, with considering that NULL value is like 0. This patch adds 'isnull' option to filter, this may be reused on other fields. Test plan : 1) Define an item subfield on items.new_status with authorised values YES_NO (0 or 1) 2) Edit an item A to set new_status=1 3) Edit an item B to set new_status=0 4) Perform an item search with 'is new' = 'ignore' => you get all items 5) Perform an item search with 'is new' = 'yes' => you get item A 6) Perform an item search with 'is new' = 'no' => you get all items but A -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26032 Emmi Takkinen <emmi.takkinen@outlook.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emmi.takkinen@outlook.com Status|Needs Signoff |Failed QA --- Comment #3 from Emmi Takkinen <emmi.takkinen@outlook.com> --- Followed test plan and filtering works as expected. However tests fail since they seem to take whole db in account not just test items. Should there be more filters (e.g by homebranch like in test above)? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26032 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26032 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107141|0 |1 is obsolete| | --- Comment #4 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 111554 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111554&action=edit Bug 26032: Add unit test Run prove t/db_dependent/Items.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26032 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107142|0 |1 is obsolete| | --- Comment #5 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 111555 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111555&action=edit Bug 26032: Add 'is new' filter in items search In items search, add a filter on value of items.new_status with a Ignore/Yes/No. Yes meaning != 0, No meaning = 0, with considering that NULL value is like 0. This patch adds 'isnull' option to filter, this may be reused on other fields. Test plan : 1) Define an item subfield on items.new_status with authorised values YES_NO (0 or 1) 2) Edit an item A to set new_status=1 3) Edit an item B to set new_status=0 4) Perform an item search with 'is new' = 'ignore' => you get all items 5) Perform an item search with 'is new' = 'yes' => you get item A 6) Perform an item search with 'is new' = 'no' => you get all items but A -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26032 --- Comment #6 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- (In reply to Emmi Takkinen from comment #3)
Followed test plan and filtering works as expected. However tests fail since they seem to take whole db in account not just test items. Should there be more filters (e.g by homebranch like in test above)?
You are right, Unit Test is now much better. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26032 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26032 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26032 --- Comment #7 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 111834 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111834&action=edit Bug 26032: (follow-up) Replace IFNULL() mysqlism with COALESCE() -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26032 Emmi Takkinen <emmi.takkinen@outlook.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111554|0 |1 is obsolete| | --- Comment #8 from Emmi Takkinen <emmi.takkinen@outlook.com> --- Created attachment 111961 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111961&action=edit Bug 26032: Add unit test Run prove t/db_dependent/Items.t Signed-off-by: Emmi Takkinen <emmi.takkinen@outlook.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26032 Emmi Takkinen <emmi.takkinen@outlook.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111555|0 |1 is obsolete| | --- Comment #9 from Emmi Takkinen <emmi.takkinen@outlook.com> --- Created attachment 111962 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111962&action=edit Bug 26032: Add 'is new' filter in items search In items search, add a filter on value of items.new_status with a Ignore/Yes/No. Yes meaning != 0, No meaning = 0, with considering that NULL value is like 0. This patch adds 'isnull' option to filter, this may be reused on other fields. Test plan : 1) Define an item subfield on items.new_status with authorised values YES_NO (0 or 1) 2) Edit an item A to set new_status=1 3) Edit an item B to set new_status=0 4) Perform an item search with 'is new' = 'ignore' => you get all items 5) Perform an item search with 'is new' = 'yes' => you get item A 6) Perform an item search with 'is new' = 'no' => you get all items but A Signed-off-by: Emmi Takkinen <emmi.takkinen@outlook.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26032 Emmi Takkinen <emmi.takkinen@outlook.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111834|0 |1 is obsolete| | --- Comment #10 from Emmi Takkinen <emmi.takkinen@outlook.com> --- Created attachment 111963 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111963&action=edit Bug 26032: (follow-up) Replace IFNULL() mysqlism with COALESCE() Signed-off-by: Emmi Takkinen <emmi.takkinen@outlook.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26032 Emmi Takkinen <emmi.takkinen@outlook.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #11 from Emmi Takkinen <emmi.takkinen@outlook.com> --- Works as expected and tests pass. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26032 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26032 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Fridolin, there is no mapping in MARC21 for the "new_status", so it cannot be edited via the item editor. It also seems that this is not set to any value by default. I am really not sure how this is used normally, it doesn't seem to be well integrated in "default" Koha right now. Can you explain? I'd also love if the div had an id so it would e possible to hide the option for libraries not using this. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26032 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|katrin.fischer@bsz-bw.de | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26032 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- My problem is that the "is new" is not really a feature at the moment that is really advertised anywhere in standard Koha - I believe having a field to limit on with no idea where to set it will be confusing :( -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26032 --- Comment #14 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Good points. I propose to show this filter only if items.new_status has a mapping. + div with an id -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26032 --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Frido, that sounds sensible, thx! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26032 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26032 --- Comment #16 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 112500 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112500&action=edit Bug 26032: (follow-up 2) show 'is new' filter only if items.new_status is used Addition to test plan: 1) Apply on a database without Koha to MARC mapping on items.new_status 2Â) Check you dont see the 'is new' filter in items search form -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26032 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112500|0 |1 is obsolete| | --- Comment #17 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 112501 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112501&action=edit Bug 26032: (follow-up 2) show 'is new' filter only if items.new_status is used Addition to test plan: 1) Apply on a database without Koha to MARC mapping on items.new_status 2) Check you dont see the 'is new' filter in items search form -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26032 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112501|0 |1 is obsolete| | --- Comment #18 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 112502 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112502&action=edit Bug 26032: (follow-up 2) show 'is new' filter only if items.new_status is used Also adds a class 'item-new-status' to this filter to be able to hidde even if items.new_status used. Addition to test plan: 1) Apply on a database without Koha to MARC mapping on items.new_status 2) Check you dont see the 'is new' filter in items search form 3) Apply on a database with Koha to MARC mapping on items.new_status 4) Check you see class 'form-field item-new-status' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26032 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26032 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111961|0 |1 is obsolete| | --- Comment #19 from Séverine Queune <severine.queune@bulac.fr> --- Created attachment 112707 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112707&action=edit Bug 26032: Add unit test Run prove t/db_dependent/Items.t Signed-off-by: Emmi Takkinen <emmi.takkinen@outlook.com> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26032 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111962|0 |1 is obsolete| | --- Comment #20 from Séverine Queune <severine.queune@bulac.fr> --- Created attachment 112708 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112708&action=edit Bug 26032: Add 'is new' filter in items search In items search, add a filter on value of items.new_status with a Ignore/Yes/No. Yes meaning != 0, No meaning = 0, with considering that NULL value is like 0. This patch adds 'isnull' option to filter, this may be reused on other fields. Test plan : 1) Define an item subfield on items.new_status with authorised values YES_NO (0 or 1) 2) Edit an item A to set new_status=1 3) Edit an item B to set new_status=0 4) Perform an item search with 'is new' = 'ignore' => you get all items 5) Perform an item search with 'is new' = 'yes' => you get item A 6) Perform an item search with 'is new' = 'no' => you get all items but A Signed-off-by: Emmi Takkinen <emmi.takkinen@outlook.com> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26032 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111963|0 |1 is obsolete| | --- Comment #21 from Séverine Queune <severine.queune@bulac.fr> --- Created attachment 112709 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112709&action=edit Bug 26032: (follow-up) Replace IFNULL() mysqlism with COALESCE() Signed-off-by: Emmi Takkinen <emmi.takkinen@outlook.com> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26032 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112502|0 |1 is obsolete| | --- Comment #22 from Séverine Queune <severine.queune@bulac.fr> --- Created attachment 112710 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112710&action=edit Bug 26032: (follow-up 2) show 'is new' filter only if items.new_status is used Also adds a class 'item-new-status' to this filter to be able to hidde even if items.new_status used. Addition to test plan: 1) Apply on a database without Koha to MARC mapping on items.new_status 2) Check you dont see the 'is new' filter in items search form 3) Apply on a database with Koha to MARC mapping on items.new_status 4) Check you see class 'form-field item-new-status' Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26032 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112707|0 |1 is obsolete| | Attachment #112710|0 |1 is obsolete| | --- Comment #23 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 112809 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112809&action=edit Bug 26032: Add unit test Run prove t/db_dependent/Items.t Signed-off-by: Emmi Takkinen <emmi.takkinen@outlook.com> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26032 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112708|0 |1 is obsolete| | --- Comment #24 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 112810 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112810&action=edit Bug 26032: Add 'is new' filter in items search In items search, add a filter on value of items.new_status with a Ignore/Yes/No. Yes meaning != 0, No meaning = 0, with considering that NULL value is like 0. This patch adds 'isnull' option to filter, this may be reused on other fields. Test plan : 1) Define an item subfield on items.new_status with authorised values YES_NO (0 or 1) 2) Edit an item A to set new_status=1 3) Edit an item B to set new_status=0 4) Perform an item search with 'is new' = 'ignore' => you get all items 5) Perform an item search with 'is new' = 'yes' => you get item A 6) Perform an item search with 'is new' = 'no' => you get all items but A Signed-off-by: Emmi Takkinen <emmi.takkinen@outlook.com> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26032 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112709|0 |1 is obsolete| | --- Comment #25 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 112811 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112811&action=edit Bug 26032: (follow-up) Replace IFNULL() mysqlism with COALESCE() Signed-off-by: Emmi Takkinen <emmi.takkinen@outlook.com> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26032 --- Comment #26 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 112812 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112812&action=edit Bug 26032: (follow-up) show 'is new' filter only if items.new_status is used Also adds a class 'item-new-status' to this filter to be able to hidde even if items.new_status used. Addition to test plan: 1) Apply on a database without Koha to MARC mapping on items.new_status 2) Check you dont see the 'is new' filter in items search form 3) Apply on a database with Koha to MARC mapping on items.new_status 4) Check you see class 'form-field item-new-status' Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26032 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26032 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112809|0 |1 is obsolete| | Attachment #112810|0 |1 is obsolete| | Attachment #112811|0 |1 is obsolete| | Attachment #112812|0 |1 is obsolete| | --- Comment #27 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 112915 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112915&action=edit Bug 26032: Add unit test Run prove t/db_dependent/Items.t Signed-off-by: Emmi Takkinen <emmi.takkinen@outlook.com> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26032 --- Comment #28 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 112916 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112916&action=edit Bug 26032: Add 'is new' filter in items search In items search, add a filter on value of items.new_status with a Ignore/Yes/No. Yes meaning != 0, No meaning = 0, with considering that NULL value is like 0. This patch adds 'isnull' option to filter, this may be reused on other fields. Test plan : 1) Define an item subfield on items.new_status with authorised values YES_NO (0 or 1) 2) Edit an item A to set new_status=1 3) Edit an item B to set new_status=0 4) Perform an item search with 'is new' = 'ignore' => you get all items 5) Perform an item search with 'is new' = 'yes' => you get item A 6) Perform an item search with 'is new' = 'no' => you get all items but A Signed-off-by: Emmi Takkinen <emmi.takkinen@outlook.com> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26032 --- Comment #29 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 112917 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112917&action=edit Bug 26032: (follow-up) Replace IFNULL() mysqlism with COALESCE() Signed-off-by: Emmi Takkinen <emmi.takkinen@outlook.com> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26032 --- Comment #30 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 112918 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112918&action=edit Bug 26032: (follow-up) show 'is new' filter only if items.new_status is used Also adds a class 'item-new-status' to this filter to be able to hidde even if items.new_status used. Addition to test plan: 1) Apply on a database without Koha to MARC mapping on items.new_status 2) Check you dont see the 'is new' filter in items search form 3) Apply on a database with Koha to MARC mapping on items.new_status 4) Check you see class 'form-field item-new-status' Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26032 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #31 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Added missing signed-off-by lines. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26032 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26032 --- Comment #32 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26032 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26032 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |There is a new filter in release notes| |item search, when the | |database column | |'items.new_status' is used. | |It allows searching items | |defined as new or not new, | |like the filter on damaged | |or not damaged. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26032 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org