[Bug 16031] New: sitemap.pl shouldn't append protocol to OPACBaseURL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16031 Bug ID: 16031 Summary: sitemap.pl shouldn't append protocol to OPACBaseURL Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Command-line Utilities Assignee: gmcharlt@gmail.com Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org CC: robin@catalyst.net.nz Right now, the script appends a fixed protocol (HTTP) to the generated URL. This is because the tool was written before bug 5010 was pushed. To reproduce: - Have OPACBaseURL set - Run the script (without the --url parameter) => FAIL: Notice the generated sitemap files contain double protocol specification on the URLs (like in http://http:// or http://https://) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16031 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |tomascohen@gmail.com Depends on| |5010 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 [Bug 5010] Fix OPACBaseURL to include protocol -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16031 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11190 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11190 [Bug 11190] sitemap.pl -- Generate a catalog sitemap -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16031 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 48893 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48893&action=edit Bug 16031: sitemap.pl shouldn't append protocol to OPACBaseURL Since bug 5010 was pushed, OPACBaseURL already contains the protocol. The sitemap.pl script was written before this was pushed, and thus still concatenates http:// in front of OPACBaseURL. This patch removes this behaviour. To test: - Have OPACBaseURL set to (say) http://myopac.com - Run the sitemap.pl script without specifying the --url param => FAIL: Notice URLs look like http://http://myopac.com/bib... in the sitemap files. - Apply the patch - Run the sitemap.pl script without specifying the --url param => SUCCESS: Notice URLs look correctly like http://myopac.com/bib... - Sign off :-D Regards -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16031 --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 48894 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48894&action=edit Bug 16031: (followup) Fix documentation This followup fixes a tiny mistake in the script POD. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16031 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16031 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16031 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48893|0 |1 is obsolete| | --- Comment #3 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 48897 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48897&action=edit [SIGNED-OFF] Bug 16031: sitemap.pl shouldn't append protocol to OPACBaseURL Since bug 5010 was pushed, OPACBaseURL already contains the protocol. The sitemap.pl script was written before this was pushed, and thus still concatenates http:// in front of OPACBaseURL. This patch removes this behaviour. To test: - Have OPACBaseURL set to (say) http://myopac.com - Run the sitemap.pl script without specifying the --url param => FAIL: Notice URLs look like http://http://myopac.com/bib... in the sitemap files. - Apply the patch - Run the sitemap.pl script without specifying the --url param => SUCCESS: Notice URLs look correctly like http://myopac.com/bib... - Sign off :-D Regards Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16031 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48894|0 |1 is obsolete| | --- Comment #4 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 48898 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48898&action=edit [SIGNED-OFF] Bug 16031: (followup) Fix documentation This followup fixes a tiny mistake in the script POD. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16031 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |mtompset@hotmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16031 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16031 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48897|0 |1 is obsolete| | Attachment #48898|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 48952 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48952&action=edit Bug 16031: sitemap.pl shouldn't append protocol to OPACBaseURL Since bug 5010 was pushed, OPACBaseURL already contains the protocol. The sitemap.pl script was written before this was pushed, and thus still concatenates http:// in front of OPACBaseURL. This patch removes this behaviour. To test: - Have OPACBaseURL set to (say) http://myopac.com - Run the sitemap.pl script without specifying the --url param => FAIL: Notice URLs look like http://http://myopac.com/bib... in the sitemap files. - Apply the patch - Run the sitemap.pl script without specifying the --url param => SUCCESS: Notice URLs look correctly like http://myopac.com/bib... - Sign off :-D Regards Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16031 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 48953 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48953&action=edit Bug 16031: (followup) Fix documentation This followup fixes a tiny mistake in the script POD. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16031 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan@bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #7 from Brendan Gallagher <brendan@bywatersolutions.com> --- Pushed to Master - Should be in the May 2016 release. Thanks -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16031 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice@biblibre.com --- Comment #8 from Julian Maurice <julian.maurice@biblibre.com> --- Patches pushed to 3.22.x, will be in 3.22.5 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org