[Bug 32284] New: Capitalization: Audio Carriers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32284 Bug ID: 32284 Summary: Capitalization: Audio Carriers Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: Academy Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_183a.tt:15 Audio Carriers should be Audio carriers -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32284 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Capitalization: Audio |Capitalization: Audio |Carriers |Carriers, Computer Carriers --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Same for: Computer Carriers koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_183a.tt:77 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32284 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Capitalization: Audio |Capitalization: Audio |Carriers, Computer Carriers |Carriers, Computer Carriers | |... in UNIMARC value | |builders --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Content Form koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_181a.tt:13 Content Type koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_181c.tt:13 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32284 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Media Type koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_182c.tt:13 Media Type Code␠ koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_182a.tt:13 Microform Carriers koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_183a.tt:133 Microscopic Carriers koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_183a.tt:195 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32284 Cath Leone <catherineleone@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32284 --- Comment #4 from Cath Leone <catherineleone@catalyst.net.nz> --- Created attachment 184265 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184265&action=edit Bug 32284: Fixing capitalisation in UNIMARC value builders Test Plan: 1. In your KTD navigate to koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder 2. Run "git grep Audio Carriers" you should get results 3. Run "git grep Computer Carriers" you should get results 4. Run "git grep Content Form" you should get results 5. Run "git grep Content Type" you should get results 6. Run "git grep Media Type" you should get results 7. Run "git grep Media Type Code" you should get results 8. Run "git grep Microform Carriers" you should get results 9. Run "git grep Microscopic Carriers" you should get results 10. Apply the patch 11. Repeat steps 2-9 you should not get results -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32284 Cath Leone <catherineleone@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |catherineleone@catalyst.net | |.nz CC| |catherineleone@catalyst.net | |.nz -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32284 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32284 --- Comment #5 from David Nind <david@davidnind.com> --- Created attachment 184272 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184272&action=edit Bug 32284: Fix capitalization for UNIMARC value builders This patch changes the capitalization for the labels displayed in the MARC tag editor for UNIMARC subfields 181$a, 181$c, $182$a, 182$c, and 183$c, when the value builders are used. The labels are changed from capital case to sentence case, for consistency with other labels: - Content Form -> Content form (181$a) - Content Type -> Content type (181$c) - Media Type Code -> Media type code (182$a) - Media Type -> Media type (182$c) - In the dropdown list (183$a): . Audio Carriers -> Audio carriers . Computer Carriers -> Computer carriers . Microform Carriers -> Microform carriers . Microscopic Carriers -> Microscopic carriers . Stereographic Carriers -> Stereographic carriers Test plan: 1. In your KTD shell navigate to koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder 2. Run "git grep Audio Carriers" you should get results 3. Run "git grep Computer Carriers" you should get results 4. Run "git grep Content Form" you should get results 5. Run "git grep Content Type" you should get results 6. Run "git grep Media Type" you should get results 7. Run "git grep Media Type Code" you should get results 8. Run "git grep Microform Carriers" you should get results 9. Run "git grep Microscopic Carriers" you should get results 10. Apply the patch 11. Repeat steps 2-9 you should not get results Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32284 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes the release notes| |capitalization for the | |labels displayed in the | |MARC tag editor for UNIMARC | |subfields 181$a, 181$c, | |$182$a, 182$c, and 183$c, | |when the value builders are | |used. The labels are | |changed from capital case | |to sentence case, for | |consistency with other | |labels: | |- Content Form -> Content | |form (181$a) | |- Content Type -> Content | |type (181$c) | |- Media Type Code -> Media | |type code (182$a) | |- Media Type -> Media type | |(182$c) | |- In the dropdown list | |(183$a): | | . Audio Carriers -> Audio | |carriers | | . Computer Carriers -> | |Computer carriers | | . Microform Carriers -> | |Microform carriers | | . Microscopic Carriers -> | |Microscopic carriers | | . Stereographic Carriers | |-> Stereographic carriers CC| |david@davidnind.com --- Comment #6 from David Nind <david@davidnind.com> --- Thanks for the patch Cath! I've updated the commit message to add a description (see the commit message guidelines https://wiki.koha-community.org/wiki/Commit_messages), I've also changed the title a little bit. I've also added a draft release note. David Nind Testing notes (using koha-testing-docker): 1. To set up a UNIMARC environment, edit the KTD .env file and set MARC_FLAVOR=unimarc 2. Edit the default framework (Koha administration > Catalog > MARC bibliographic frameworks > Default framework) to add the appropriate value builders to the subfields (and remove authorized value lists if they are populated): - 181$a: add the unimarc_field_181a.pl plugin - 181$c*: remove authorized value list and add the unimarc_field_181c.pl plugin (unimarc_181c - authorized value list, already configured) - 182$a*: remove authorized value list and add the unimarc_field_182a.pl plugin (unimarc_182a - authorized value list, already configured) - 182$c*: remove authorized value list and add the unimarc_field_182c.pl plugin (unimarc_182c - authorized value list, already configured) - 183$a: add the unimarc_field_183a.pl plugin Note: the subfields with an * also have authorized value lists, which are now configured by default for the default fraemwork 3. Edit a record and add values for the subfields using the tag editor. 4. Check how the labels are displayed in the tag editor before and after the patch: - Before: Capital case - After: Sentence case 5. To check the wording (in capital case), check the UNIMARC definitions at https://www.ifla.org/unimarc-updates/unimarc-bibliographic-format-manual-onl... (pages 262-272 of the PDF). 6. Changes: - Content Form -> Content form (181$a) - Content Type -> Content type (181$c) - Media Type Code -> Media type code (182$a) - Media Type -> Media type (182$c) - In a dropdown list (183$a): . Audio Carriers -> Audio carriers . Computer Carriers -> Computer carriers . Microform Carriers -> Microform carriers . Microscopic Carriers -> Microscopic carriers . Stereographic Carriers -> Stereographic carriers -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32284 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184265|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32284 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184272|0 |1 is obsolete| | --- Comment #7 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 184392 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184392&action=edit Bug 32284: Fix capitalization for UNIMARC value builders This patch changes the capitalization for the labels displayed in the MARC tag editor for UNIMARC subfields 181$a, 181$c, $182$a, 182$c, and 183$c, when the value builders are used. The labels are changed from capital case to sentence case, for consistency with other labels: - Content Form -> Content form (181$a) - Content Type -> Content type (181$c) - Media Type Code -> Media type code (182$a) - Media Type -> Media type (182$c) - In the dropdown list (183$a): . Audio Carriers -> Audio carriers . Computer Carriers -> Computer carriers . Microform Carriers -> Microform carriers . Microscopic Carriers -> Microscopic carriers . Stereographic Carriers -> Stereographic carriers Test plan: 1. In your KTD shell navigate to koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder 2. Run "git grep Audio Carriers" you should get results 3. Run "git grep Computer Carriers" you should get results 4. Run "git grep Content Form" you should get results 5. Run "git grep Content Type" you should get results 6. Run "git grep Media Type" you should get results 7. Run "git grep Media Type Code" you should get results 8. Run "git grep Microform Carriers" you should get results 9. Run "git grep Microscopic Carriers" you should get results 10. Apply the patch 11. Repeat steps 2-9 you should not get results Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32284 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emily.lamancusa@montgomeryc | |ountymd.gov QA Contact|testopia@bugs.koha-communit |emily.lamancusa@montgomeryc |y.org |ountymd.gov Patch complexity|--- |String patch Status|Signed Off |Passed QA --- Comment #8 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- Looks great! Thanks, Cath! Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32284 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32284 --- Comment #9 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32284 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.11.00 |25.11.00,25.05.02 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32284 --- Comment #10 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 25.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32284 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to stable |Needs documenting --- Comment #11 from Fridolin Somers <fridolin.somers@biblibre.com> --- I prefer not backport to 24.11 to avoid translation work -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32284 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #12 from David Nind <david@davidnind.com> --- No update to the manual required. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org