[Bug 15686] New: Rename "item level holds" circ rule column to "OPAC item level holds"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15686 Bug ID: 15686 Summary: Rename "item level holds" circ rule column to "OPAC item level holds" Change sponsored?: --- Product: Koha Version: 3.22 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: hbraum@nekls.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Bug 5786 moved the OPACItemHolds sys pref setting to the Circulation Rules table. However, the naming of the new circ rules column is quite confusing. It is called "Item level holds" which makes it sound like this setting controls the item level holds placing from anywhere in the system (staff and OPAC sides) Instead, the setting only affects item level hold placing from the OPAC side. Should this column then be renamed to "OPAC item level holds"?, so it's not so confusing? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15686 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.22 |master CC| |katrin.fischer@bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi George, feel free to submit a patch doing this! :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15686 delaye <stephane.delaye@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |stephane.delaye@biblibre.co | |m --- Comment #2 from delaye <stephane.delaye@biblibre.com> --- In the Circulation Rule, "Item level holds" works only in 'All location'..In the OPAC don't works in th erule of a location.For me it's logic but for the librian, this column in the table is disturbing. I prefer before with the systeme preference why this change?... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15686 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to delaye from comment #2)
In the Circulation Rule, "Item level holds" works only in 'All location'..In the OPAC don't works in th erule of a location.For me it's logic but for the librian, this column in the table is disturbing. I prefer before with the systeme preference
why this change?...
I don't believe this is true (anymore). But it will use the strictest rule if you have multiple items with different itemtypes on one record, so if you have one item with an itemtype that forces item level, it will do that. I think renaming is a good idea still. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15686 Lisette Scheer <lisetteslatah@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15686 --- Comment #4 from Lisette Scheer <lisetteslatah@gmail.com> --- Created attachment 97359 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97359&action=edit Bug 15686 - Rename "item level holds" circ rule column to "OPAC item level holds" This patch changes the column heading on smart-rules.pl to indicate that it only effects item level holds on the OPAC side, rather than the intranet. To test: 1. Go to Administration, circulation and fine rules. 2. Observe incorrect heading on both the top and bottom of the table. 3. Apply the patch. 4. Repeat step 1. 5. Observe new headings. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15686 Lisette Scheer <lisetteslatah@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah@gmail.com Assignee|koha-bugs@lists.koha-commun |lisetteslatah@gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15686 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15686 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97359|0 |1 is obsolete| | --- Comment #5 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 97364 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97364&action=edit Bug 15686 - Rename "item level holds" circ rule column to "OPAC item level holds" This patch changes the column heading on smart-rules.pl to indicate that it only effects item level holds on the OPAC side, rather than the intranet. To test: 1. Go to Administration, circulation and fine rules. 2. Observe incorrect heading on both the top and bottom of the table. 3. Apply the patch. 4. Repeat step 1. 5. Observe new headings. Signed-off-by: Liz Rea <wizzyrea@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15686 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15686 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97364|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 97370 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97370&action=edit Bug 15686 - Rename "item level holds" circ rule column to "OPAC item level holds" This patch changes the column heading on smart-rules.pl to indicate that it only effects item level holds on the OPAC side, rather than the intranet. To test: 1. Go to Administration, circulation and fine rules. 2. Observe incorrect heading on both the top and bottom of the table. 3. Apply the patch. 4. Repeat step 1. 5. Observe new headings. Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15686 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15686 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15686 --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15686 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED CC| |joy@bywatersolutions.com Resolution|--- |FIXED --- Comment #8 from Joy Nelson <joy@bywatersolutions.com> --- Enhancement not backported to 19.11.x branch -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org