https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33184 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33184 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 148019 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148019&action=edit Bug 33184: Warnings when running holds queue builder If a hold was fillable when the holds queue builder starts, but is no longer fillable when the builder gets to that hold's record ( for example, an item was trapped to fill that hold so the hold is now "found" ), it will generate warnings like: Use of uninitialized value in addition (+) at /usr/share/koha/lib/C4/HoldsQueue.pm line 219. Use of uninitialized value in addition (+) at /usr/share/koha/lib/C4/HoldsQueue.pm line 220. Test Plan: 1) Run holds queue builder from the command line 2) While it is running fill a hold 3) Note the warning generated by build_holds_queue.pl 4) Apply this patch 5) Repeat steps 1-2 6) No warnings! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33184 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #2 from David Nind <david@davidnind.com> --- Is there a script or some way to automatically add a large number of holds, without having to manually add them? The build_holds_queue.pl runs too quickly with only a small number of holds manually entered. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33184 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |pedro.amorim@ptfs-europe.co | |m --- Comment #4 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- I created a hold manually and ran the following query a couple times to duplicate holds entries in the database: INSERT INTO reserves (`borrowernumber`,`biblionumber`, `branchcode`) SELECT `borrowernumber`, `biblionumber`, `branchcode` FROM reserves; This just adds "dummy" data into the reserves table, it appears it's not quite there yet to be able to reproduce what Kyle describes. (In reply to Kyle M Hall from comment #0)

If a hold was fillable when the holds queue builder starts, but is no longer fillable when the builder gets to that hold's record

I ran perl misc/cronjobs/holds/build_holds_queue.pl but no warnings are showing for me, as per my testing above. @Kyle are you able to provide test data or a test patch to force this scenario to help reproduce the issue? -- You are receiving this mail because: You are watching all bug changes.