[Bug 37244] New: Selecting homebranch or holdingbranch facet sets branch in library dropdown.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37244 Bug ID: 37244 Summary: Selecting homebranch or holdingbranch facet sets branch in library dropdown. Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching Assignee: koha-bugs@lists.koha-community.org Reporter: andreas.jonsson@kreablo.se QA Contact: testopia@bugs.koha-community.org When clicking on a facet for holding or home branch the branch limit in the corresponding library is inadvertedly selected in the library dropdown, in both staff interface and OPAC. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37244 --- Comment #1 from Andreas Jonsson <andreas.jonsson@kreablo.se> --- Created attachment 168448 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168448&action=edit Bug 37244: Facets should not impact library pulldown. When parsing the branch limits the regular expression matches parameters that contains the substring "branch:" rather than the prefix "^branch:". Consequently, both prefixes homebranch: and holdingbranch: triggers the branch limit. Test plan: - Activate the system preference IntranetAddMastheadLibraryPulldown. - In staff interface: - Perform a catalogue search (e.g. "book"). - Click on a facet for holding library or home library (e.g. "Fairview"). - Click on the "more options" icon in the search box and make sure that "All libraries" is selected. - Activate the system preference OpacAddMastheadLibraryPulldown - In opac: - Perform a catalogue search (e.g. "book"). - Click on a facet for holding library or home library (e.g. "Fairview"). - Make sure "All libraries" is still selected in the dropdown next to the search input. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37244 Andreas Jonsson <andreas.jonsson@kreablo.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37244 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37244 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168448|0 |1 is obsolete| | --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 168481 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168481&action=edit Bug 37244: Facets should not impact library pulldown. When parsing the branch limits the regular expression matches parameters that contains the substring "branch:" rather than the prefix "^branch:". Consequently, both prefixes homebranch: and holdingbranch: triggers the branch limit. Test plan: - Activate the system preference IntranetAddMastheadLibraryPulldown. - In staff interface: - Perform a catalogue search (e.g. "book"). - Click on a facet for holding library or home library (e.g. "Fairview"). - Click on the "more options" icon in the search box and make sure that "All libraries" is selected. - Activate the system preference OpacAddMastheadLibraryPulldown - In opac: - Perform a catalogue search (e.g. "book"). - Click on a facet for holding library or home library (e.g. "Fairview"). - Make sure "All libraries" is still selected in the dropdown next to the search input. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37244 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matt.blenkinsop@ptfs-europe | |.com QA Contact|testopia@bugs.koha-communit |matt.blenkinsop@ptfs-europe |y.org |.com Assignee|koha-bugs@lists.koha-commun |andreas.jonsson@kreablo.se |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37244 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37244 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168481|0 |1 is obsolete| | --- Comment #3 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 168506 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168506&action=edit Bug 37244: Facets should not impact library pulldown. When parsing the branch limits the regular expression matches parameters that contains the substring "branch:" rather than the prefix "^branch:". Consequently, both prefixes homebranch: and holdingbranch: triggers the branch limit. Test plan: - Activate the system preference IntranetAddMastheadLibraryPulldown. - In staff interface: - Perform a catalogue search (e.g. "book"). - Click on a facet for holding library or home library (e.g. "Fairview"). - Click on the "more options" icon in the search box and make sure that "All libraries" is selected. - Activate the system preference OpacAddMastheadLibraryPulldown - In opac: - Perform a catalogue search (e.g. "book"). - Click on a facet for holding library or home library (e.g. "Fairview"). - Make sure "All libraries" is still selected in the dropdown next to the search input. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37244 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Selecting homebranch or |Selecting home library or |holdingbranch facet sets |holding library facet |branch in library dropdown. |changes library dropdown -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37244 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37244 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37244 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable CC| |lucas@bywatersolutions.com Version(s)|24.11.00 |24.11.00,24.05.06 released in| | --- Comment #5 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Backported to 24.05.x for upcoming 24.05.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37244 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37244 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.11.00,24.05.06 |24.11.00,24.05.06,23.11.11 released in| | CC| |fridolin.somers@biblibre.co | |m Status|Pushed to oldstable |Pushed to oldoldstable --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37244 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz Status|Pushed to oldoldstable |Needs documenting --- Comment #7 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11 unless requested -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org