[Bug 36129] New: Check in "Hide all columns" doesn't persist on item patch modification/deletion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36129 Bug ID: 36129 Summary: Check in "Hide all columns" doesn't persist on item patch modification/deletion Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff interface Assignee: koha-bugs@lists.koha-community.org Reporter: emmi.takkinen@koha-suomi.fi QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com On item patch modification/deletion tool, if one checks "Hide all columns" checkbox and then reloads the page, checkbox is no longer selected. Columns are hidden as they should. To reproduce: 1. Find items to modify/delete and modify/delete them with corresponding tool. 2. Check checkbox "Hide all columns". 3. Refresh the page. => Note that columns are still hidden, but checkbox is now unselected. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36129 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs@lists.koha-commun |emmi.takkinen@koha-suomi.fi |ity.org | --- Comment #1 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 162268 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162268&action=edit Bug 36129: Make check on "Hide all columns" persist on item patch modification/deletion On item patch modification/deletion tool, if one checks "Hide all columns" checkbox and then reloads the page, checkbox is no longer selected. Columns are hidden as they should. This patch adds line to batchMod.js which sets "checked" attribute and class "selected" to checkbox. To test: 1. Find items to modify/delete and modify/delete them with corresponding tool. 2. Check checkbox "Hide all columns". 3. Refresh the page. => Note that columns are still hidden, but checkbox is now unselected. 4. Apply this patch. 5. Check checkbox again and refresh page. => Checkbox should be still checked. Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36129 Anni Rajala <anni.rajala@turku.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |anni.rajala@turku.fi --- Comment #2 from Anni Rajala <anni.rajala@turku.fi> --- When testing this I noticed that after refreshing page the selected checkbox didn't always remain. Both batch modification and deletion tool use the same code (+ browser's cache) when hiding columns so apparently what happened in my case was that my previous selection from batch modification tool was retrieved when I refreshed the batch deletion tool -page. Not sure if this can or needs to be fixed, but just to let everyone know what I bumped into. The patch does however fix the original issue where selection and columns hidden didn't match after reloading the page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36129 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32477 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36129 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #3 from David Nind <david@davidnind.com> --- I experienced some odd behavour with this as well when testing, and have changed to Failed QA: 1. Apply the patch 2. Clear browser cache 3. With batch item modification: . Select 'Hide all columns' - works as expected . Hard refresh the page (Shift + Refresh button) - no change . Select 'Show all columns' - works as expected . Repeat a couple of times . On one of the hard refreshes, it takes a while to load the page (and browser tab icon is spinning) . Don't do anything for a while (say one or two minutes) . Get this console error message: Unchecked runtime.lastError: A listener indicated an asynchronous response by returning true, but the message channel closed before a response was received batchMod.pl:1 . Hard refresh the page again . Takes a while to load, tab icon is spinning, 'Show all columns' + Others are selected (except for 'Hide all columns', then after a wait changes to 'Hide all columns' 4. Use the breadcrumbs/menu options to navigate to the staff interface home page, then go to Cataloging > Batch item deletion: . Note the spinning tab icon, and pages load slowly . Paste in some barcodes and submit . Note that the page load reasonably quickly, however the tab icon is spinning . Leave it for a bit (say one or two minutes), changes from what is expected (All columns selected, with only 'Hide all columns' not selected) to just 'Hide all columns' . Hard refresh, same as previous step 5. Clear the browser cache and then go to the batch item deletion tool . Select 'Hide all columns' . This message appears in the web developer tools console: Uncaught ReferenceError: allColumns is not defined batchMod_23.1200012.js:116 at hideAllColumns (batchMod_23.1200012.js:116:24) at HTMLInputElement.<anonymous> (batchMod_23.1200012.js:159:13) at HTMLInputElement.dispatch (jquery-3.6.0.min_23.1200012.js:2:43064) at v.handle (jquery-3.6.0.min_23.1200012.js:2:41048) . Don't do anything for a bit, then this console messages appears: Unchecked runtime.lastError: A listener indicated an asynchronous response by returning true, but the message channel closed before a response was received batchMod.pl:1 . Hard refresh - All columns are now selected, with only 'Hide all columns' not selected . Wait a bit - changes to 'Hide all columns' and the "Uncaught ReferenceError: allColumns" error from above is shown in the console again. Items I used to test: 39999000006094 39999000006117 39999000011418 39999000005134 Have added bug 32477 as a reference, while not the same it was fixing similar issues. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36129 --- Comment #4 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- (In reply to David Nind from comment #3)
I experienced some odd behavour with this as well when testing, and have changed to Failed QA:
1. Apply the patch
2. Clear browser cache
3. With batch item modification: . Select 'Hide all columns' - works as expected . Hard refresh the page (Shift + Refresh button) - no change . Select 'Show all columns' - works as expected . Repeat a couple of times . On one of the hard refreshes, it takes a while to load the page (and browser tab icon is spinning) . Don't do anything for a while (say one or two minutes) . Get this console error message: Unchecked runtime.lastError: A listener indicated an asynchronous response by returning true, but the message channel closed before a response was received batchMod.pl:1 . Hard refresh the page again . Takes a while to load, tab icon is spinning, 'Show all columns' + Others are selected (except for 'Hide all columns', then after a wait changes to 'Hide all columns'
4. Use the breadcrumbs/menu options to navigate to the staff interface home page, then go to Cataloging > Batch item deletion: . Note the spinning tab icon, and pages load slowly . Paste in some barcodes and submit . Note that the page load reasonably quickly, however the tab icon is spinning . Leave it for a bit (say one or two minutes), changes from what is expected (All columns selected, with only 'Hide all columns' not selected) to just 'Hide all columns' . Hard refresh, same as previous step
5. Clear the browser cache and then go to the batch item deletion tool . Select 'Hide all columns' . This message appears in the web developer tools console: Uncaught ReferenceError: allColumns is not defined batchMod_23.1200012.js:116 at hideAllColumns (batchMod_23.1200012.js:116:24) at HTMLInputElement.<anonymous> (batchMod_23.1200012.js:159:13) at HTMLInputElement.dispatch (jquery-3.6.0.min_23.1200012.js:2:43064) at v.handle (jquery-3.6.0.min_23.1200012.js:2:41048) . Don't do anything for a bit, then this console messages appears: Unchecked runtime.lastError: A listener indicated an asynchronous response by returning true, but the message channel closed before a response was received batchMod.pl:1 . Hard refresh - All columns are now selected, with only 'Hide all columns' not selected . Wait a bit - changes to 'Hide all columns' and the "Uncaught ReferenceError: allColumns" error from above is shown in the console again.
Items I used to test: 39999000006094 39999000006117 39999000011418 39999000005134
Have added bug 32477 as a reference, while not the same it was fixing similar issues.
I've been trying to reproduce this scenario with no luck. Could it be that this happens with specific browser? I'm using Firefox (version 125.0.3). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36129 --- Comment #5 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Couldn't reproduce Davids problem with Chromium either. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36129 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #6 from David Nind <david@davidnind.com> --- I can't see it now either (Firefox and Chromium). 8-( -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36129 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36129 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162268|0 |1 is obsolete| | --- Comment #7 from David Nind <david@davidnind.com> --- Created attachment 166526 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166526&action=edit Bug 36129: Make check on "Hide all columns" persist on item patch modification/deletion On item patch modification/deletion tool, if one checks "Hide all columns" checkbox and then reloads the page, checkbox is no longer selected. Columns are hidden as they should. This patch adds line to batchMod.js which sets "checked" attribute and class "selected" to checkbox. To test: 1. Find items to modify/delete and modify/delete them with corresponding tool. 2. Check checkbox "Hide all columns". 3. Refresh the page. => Note that columns are still hidden, but checkbox is now unselected. 4. Apply this patch. 5. Check checkbox again and refresh page. => Checkbox should be still checked. Sponsored-by: Koha-Suomi Oy Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36129 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36129 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com QA Contact|testopia@bugs.koha-communit |kyle@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36129 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36129 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166526|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 169251 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169251&action=edit Bug 36129: Make check on "Hide all columns" persist on item patch modification/deletion On item patch modification/deletion tool, if one checks "Hide all columns" checkbox and then reloads the page, checkbox is no longer selected. Columns are hidden as they should. This patch adds line to batchMod.js which sets "checked" attribute and class "selected" to checkbox. To test: 1. Find items to modify/delete and modify/delete them with corresponding tool. 2. Check checkbox "Hide all columns". 3. Refresh the page. => Note that columns are still hidden, but checkbox is now unselected. 4. Apply this patch. 5. Check checkbox again and refresh page. => Checkbox should be still checked. Sponsored-by: Koha-Suomi Oy Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36129 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36129 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36129 --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Thanks for all the hard work! Pushed to main for the next 24.11.00 release as RM Assistant -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36129 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Check in "Hide all columns" |Check in "Hide all columns" |doesn't persist on item |doesn't persist on item |patch modification/deletion |batch modification/deletion Text to go in the| |This fixes the item batch release notes| |modification/deletion tool, | |so that if the "Hide all | |columns" checkbox is | |selected and then the page | |is reloaded, the checkbox | |is still shown as selected. | |Before this, the columns | |remained hidden as | |expected, but the checkbox | |wasn't selected. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36129 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.11.00 |24.11.00.24.05.04 released in| | Status|Pushed to main |Pushed to stable CC| |lucas@bywatersolutions.com --- Comment #10 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 24.05.x for upcoming 24.05.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36129 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to stable |Pushed to oldstable Version(s)|24.11.00.24.05.04 |24.11.00.24.05.04,23.11.09 released in| | --- Comment #11 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.09 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36129 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #12 from wainuiwitikapark@catalyst.net.nz --- Not backporting to 23.05.x unless requested -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36129 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Needs documenting --- Comment #13 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11 unless requested -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org