[Bug 9841] New: Improve the link from the "logged in as mysql-user"-warning
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9841 Bug ID: 9841 Summary: Improve the link from the "logged in as mysql-user"-warning Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Authentication Assignee: magnus@enger.priv.no Reporter: magnus@enger.priv.no CC: dpavlin@rot13.org Bug 9008 introduced a nice warning message on the admin homepage for users logged in as the MySQL user. There is a link from the warning to create a patron, which looks like this: /cgi-bin/koha/members/memberentry.pl?op=add This takes me to a screen for adding an "Adult patron" (category code S), but when I save a patron it's actually saved with category code J, which is kind of weird... You'd probably want to create a "Librarian" patron, but since there is no way to know the category code that corresponds to "Librarian" in any given installation, I think it would be better if the link simply pointed to: /cgi-bin/koha/members/memberentry.pl where the desired category code can be chosen directly. There is also a small typo in the warning: "This a bad idea". -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9841 --- Comment #1 from Magnus Enger <magnus@enger.priv.no> --- Sorry, typo. I think the link should be this: /cgi-bin/koha/members/members-home.pl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9841 --- Comment #2 from Magnus Enger <magnus@enger.priv.no> --- Created attachment 16344 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16344&action=edit Bug 9841 - Improve the link from the "logged in as mysql-user"-warning Currently, the link from the "logged in as mysql-user"-warning goes to add a patron in a seemingly random category code. This patch changes the link to point to Home › Patrons, where a category for the new patron can be chosen. A small typo in the warning message is also corrected. To test: - Apply the patch - Login as the MySQL user - Check that the warning appears on the intranet home page - Check that the typo in the first line is fixed: "This *is* a bad idea" - Check that the link in the warning leads to Home > Patrons -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9841 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9841 --- Comment #3 from Brendan Gallagher <brendan@bywatersolutions.com> --- Created attachment 16358 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16358&action=edit Bug 9841 - Improve the link from the "logged in as mysql-user"-warning Currently, the link from the "logged in as mysql-user"-warning goes to add a patron in a seemingly random category code. This patch changes the link to point to Home › Patrons, where a category for the new patron can be chosen. A small typo in the warning message is also corrected. To test: - Apply the patch - Login as the MySQL user - Check that the warning appears on the intranet home page - Check that the typo in the first line is fixed: "This *is* a bad idea" - Check that the link in the warning leads to Home > Patrons Signed-off-by: Brendan <brendan@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9841 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16344|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9841 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |brendan@bywatersolutions.co | |m --- Comment #4 from Brendan Gallagher <brendan@bywatersolutions.com> --- Signed off and test plan was great. When clicking link - it dumped me to members-home where I could then choose which patron type I wanted. -Brendan -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9841 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9841 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16358|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 16366 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16366&action=edit [PASSED QA] Bug 9841 - Improve the link from the "logged in as mysql-user"-warning Currently, the link from the "logged in as mysql-user"-warning goes to add a patron in a seemingly random category code. This patch changes the link to point to Home > Patrons, where a category for the new patron can be chosen. A small typo in the warning message is also corrected. To test: - Apply the patch - Login as the MySQL user - Check that the warning appears on the intranet home page - Check that the typo in the first line is fixed: "This *is* a bad idea" - Check that the link in the warning leads to Home > Patrons Signed-off-by: Brendan <brendan@bywatersolutions.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> All happy with this. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9841 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9841 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #7 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.10.x will be in 3.10.5 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9841 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED --- Comment #8 from Magnus Enger <magnus@enger.priv.no> --- Works as intended (tested with packages built off current master). -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org