[Bug 31783] New: Table settings page needs page-section class
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31783 Bug ID: 31783 Summary: Table settings page needs page-section class Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Depends on: 30952 We need the page-section div added to the columns_settings.tt page to ensure proper contrast for even/odd rows on the tables. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31783 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31783 --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 141852 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141852&action=edit Bug 31783: Add page-section to columns_settings.tt page This patch adds the page-section class to the tables on the Table settings page. To test: 1. Apply patch and go to Administration > Table settings 2. Make sure the tables look good with the new page-section class, which is added to an existing div in this case. 3. Make sure that changing some table setting still works and you can properly save new settings. Note: This patch moves the fieldset which contains the Save button into the page-section div. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31783 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- I think I disagree on this one. The main difference between the current interface and the pre-redesign one is the table borders. The table row highlighting is even a little darker in the redesign. In my opinion the interface is too busy with the added page-section class. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31783 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31783 Bug 31783 depends on bug 30952, which changed state. Bug 30952 Summary: New design for staff interface https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org