[Bug 11272] New: copy submit button on inventory
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11272 Bug ID: 11272 Summary: copy submit button on inventory Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: nengard@gmail.com QA Contact: testopia@bugs.koha-community.org On the inventory tool the submit button is a the very bottom, but it should probably be in two places. One under the file upload and one at the bottom. This will make it clear that if you do a file you don't have to fill in the filter options - just submit. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11272 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11272 --- Comment #1 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 24705 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24705&action=edit [BUG 11272] Add second submit button to inventory The inventory tool allows for 2 ways of processing files. The first is to upload a file. The second is to generate the shelf list. Most libraries think they have to fill in all fields because the submit button is at the bottom of the second option. They do not. This patch adds a second submit button under the first method to make this clearer. To test: * Generate a file of barcodes for inventorying * Before applying the patch use the file upload method to mark as seen * Apply the patch * Use the file upload method to mark as seen using the new submit * Repeat the above for the shelf list method * Confirm that inventory still works as expected with 2 buttons -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11272 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |nengard@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11272 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11272 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24705|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 24893 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24893&action=edit [SIGNED-OFF] Bug 11272 - copy submit button on inventory The inventory tool allows for 2 ways of processing files. The first is to upload a file. The second is to generate the shelf list. Most libraries think they have to fill in all fields because the submit button is at the bottom of the second option. They do not. This patch adds a second submit button under the first method to make this clearer. To test: * Generate a file of barcodes for inventorying * Before applying the patch use the file upload method to mark as seen * Apply the patch * Use the file upload method to mark as seen using the new submit * Repeat the above for the shelf list method * Confirm that inventory still works as expected with 2 buttons Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11272 --- Comment #3 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 24934 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24934&action=edit Bug 11272 - copy submit button on inventory The inventory tool allows for 2 ways of processing files. The first is to upload a file. The second is to generate the shelf list. Most libraries think they have to fill in all fields because the submit button is at the bottom of the second option. They do not. This patch adds a second submit button under the first method to make this clearer. To test: * Generate a file of barcodes for inventorying * Before applying the patch use the file upload method to mark as seen * Apply the patch * Use the file upload method to mark as seen using the new submit * Repeat the above for the shelf list method * Confirm that inventory still works as expected with 2 buttons Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11272 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |m.de.rooy@rijksmuseum.nl QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | --- Comment #4 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Passing QA on this trivial patch adding a submit button on inventory, but I feel that this form actually needs more attention as for design. Just viewing this as a workaround. The form design is not intuitive. The two approaches should be more visible, as well as common options to both approaches like exporting to csv etc. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11272 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24893|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11272 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #5 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Nicole! I agree with Marcel that the form needs a revamp to make it clear that it has two distinct modes of operation. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11272 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers@biblibre.co | |m --- Comment #6 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Pushed to 3.14.x, will be in 3.14.07 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11272 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12025 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11272 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to 3.12.x will be in 3.12.13 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11272 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |ASSIGNED --- Comment #8 from Nicole C. Engard <nengard@gmail.com> --- I'm wondering if this got reverted. I'm on 3.16 (and I have a master system as well) and I don't see the button anymore. Can anyone confirm? Nicole -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11272 --- Comment #9 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Bug 12025 as reverted this bug -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11272 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11272 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24934|0 |1 is obsolete| | --- Comment #10 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 37850 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37850&action=edit Bug 11272 - copy submit button on inventory The inventory tool allows for 2 ways of processing files. The first is to upload a file. The second is to generate the shelf list. Most libraries think they have to fill in all fields because the submit button is at the bottom of the second option. They do not. This patch adds a second submit button under the first method to make this clearer. To test: * Generate a file of barcodes for inventorying * Before applying the patch use the file upload method to mark as seen * Apply the patch * Use the file upload method to mark as seen using the new submit * Repeat the above for the shelf list method * Confirm that inventory still works as expected with 2 buttons Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Rebased. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11272 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com --- Comment #11 from M. Tompsett <mtompset@hotmail.com> --- I wasn't sure what status to stick this to. If you compare it to the previous obsolete, it's identical. For some strange reason the extra blank lines confused the git bz apply such that it didn't apply. This one does. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11272 --- Comment #12 from Marc Véron <veron@veron.ch> --- Created attachment 37895 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37895&action=edit [Signed-off] Bug 11272 - copy submit button on inventory The inventory tool allows for 2 ways of processing files. The first is to upload a file. The second is to generate the shelf list. Most libraries think they have to fill in all fields because the submit button is at the bottom of the second option. They do not. This patch adds a second submit button under the first method to make this clearer. To test: * Generate a file of barcodes for inventorying * Before applying the patch use the file upload method to mark as seen * Apply the patch * Use the file upload method to mark as seen using the new submit * Repeat the above for the shelf list method * Confirm that inventory still works as expected with 2 buttons Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Rebased. Works as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11272 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch Attachment #37850|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11272 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11272 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #13 from Jonathan Druart <jonathan.druart@biblibre.com> --- Mark, please have a look at the historic of the report before reintroduce a dead patch. It will take you to bug 12025 comment 4. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11272 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Signed Off |RESOLVED --- Comment #14 from Jonathan Druart <jonathan.druart@biblibre.com> --- This is "resolved" as it is pushed to master and stable versions. Open a new bug for discussion if needed. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11272 --- Comment #15 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Jonathan Druart from comment #13)
Mark, please have a look at the historic of the report before reintroduce a dead patch. It will take you to bug 12025 comment 4.
Apologies. I was just working at lowering the "Patch does not apply" queue. I should have been a little more thorough in checking git logs, and noting see also's above. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org