[Bug 11415] New: SCO has no option to disable automatic receipt printing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11415 Bug ID: 11415 Summary: SCO has no option to disable automatic receipt printing Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Self checkout Assignee: koha-bugs@lists.koha-community.org Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org There are libraries use Koha's self checkout system without having receipt printers connected to them. The prompt for print a receipt from sco should be optional and controlled by a system preference. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11415 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11415 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11415 JaTara Barnes <jendayi30@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jendayi30@gmail.com --- Comment #1 from JaTara Barnes <jendayi30@gmail.com> --- Created attachment 23904 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23904&action=edit Implements syspref for SCO receipt printing -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11415 JaTara Barnes <jendayi30@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #2 from JaTara Barnes <jendayi30@gmail.com> --- Test Case: 1. Log into self-check as normal. 2. Click the "Finish" button. 3. Notice that receipt dialog pops up. 4. Apply patch. 5. Run updatedatabase.pl 6. Set the SelfCheckReceiptPrompt syspref to "Don't show" 6. Log into self-check. 7. Click the "Finish" button. 8. Verify that the receipt dialog does NOT pop up. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11415 --- Comment #3 from Chris Cormack <chris@bigballofwax.co.nz> --- Comment on attachment 23904 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23904 Implements syspref for SCO receipt printing Review of attachment 23904: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=11415&attachment=23904) ----------------------------------------------------------------- ::: installer/data/mysql/updatedatabase.pl @@ +7886,5 @@
}
+$DBversion = "3.15.00.XXX"; +if(CheckVersion($DBversion)) { + $dbh->do("INSERT INTO systempreferences (variable,value,options,explanation,type) VALUES('SelfCheckReceiptPrompt', '0', 'NULL', 'If ON, print receipt dialog pops up when self checkout is finished.', 'YesNo');");
This all looks good, and works well. Our rule of thumb though is to not change behaviour. This syspref is set off, so once you upgrade you will no longer get the prompt showing up. I think it should go into the update as on, so the behaviour doesn't change on upgrade, people can switch it off. It can go in off for new installs though. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11415 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11415 --- Comment #4 from JaTara Barnes <jendayi30@gmail.com> --- Created attachment 24028 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24028&action=edit Implements syspref for SCO receipt printing - updated to change default to ON -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11415 JaTara Barnes <jendayi30@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|kyle@bywatersolutions.com |jendayi30@gmail.com --- Comment #5 from JaTara Barnes <jendayi30@gmail.com> --- Created attachment 24037 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24037&action=edit Implements syspref for SCO receipt printing -- updated default value + template -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11415 --- Comment #6 from JaTara Barnes <jendayi30@gmail.com> --- Created attachment 24038 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24038&action=edit Implements syspref for SCO receipt -- added code to prog -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11415 --- Comment #7 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 24039 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24039&action=edit Bug 11415: Add syspref to toggle receipt printing for self-check Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11415 --- Comment #8 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 24040 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24040&action=edit Bug 11415: Add syspref to toggle SCO receipt printing Simple change to updatedatabase.pl to set SCO receipt printing as default Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11415 --- Comment #9 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 24041 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24041&action=edit Bug 11415: Add syspref to toggle SCO receipt printing Updated files to set default to 1 in sysprefs.sql. Also added code to pass the parameter to the template page, Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11415 --- Comment #10 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 24042 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24042&action=edit Bug 11415: Add syspref to toggle SCO receipt printing Added code to update prog Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11415 --- Comment #11 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 24043 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24043&action=edit [SIGNED OFF] Bug 11415: Add syspref to toggle receipt printing for self-check Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11415 --- Comment #12 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 24044 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24044&action=edit [SIGNED OFF] Bug 11415: Add syspref to toggle SCO receipt printing Toggled SCO receipt printing to be on by default for upgrades in updatedatabase.pl. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11415 --- Comment #13 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 24045 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24045&action=edit [SIGNED OFF] Bug 11415: Add syspref to toggle SCO receipt printing Updated files to set default to 1 in sysprefs.sql. Also added code to read the system preference on the template page. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11415 --- Comment #14 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 24046 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24046&action=edit [SIGNED OFF] Bug 11415: Add syspref to toggle SCO receipt printing Added code to update prog theme with same changes as the bootstrap theme. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11415 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23904|0 |1 is obsolete| | CC| |mtompset@hotmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11415 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24028|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11415 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24037|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11415 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24038|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11415 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24039|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11415 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24040|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11415 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24041|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11415 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24042|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11415 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #15 from M. Tompsett <mtompset@hotmail.com> --- REVISED TEST PLAN ================= 0. ~/qa-test-tools/koha-qa.pl -v 2 -c 4 NOTE: Fix tabs. 1. Log into self-check as normal. (https://.../cgi-bin/koha/sco/sco-main.pl) 2. Check something out. 2. Click the "Finish" button. 3. Notice that receipt dialog pops up. 4. Apply patch. 5. Run updatedatabase.pl 6. Set the SelfCheckReceiptPrompt syspref to "Don't show" 7. Log into self-check. 8. Check something out. 9. Click the "Finish" button. 10. Verify that the receipt dialog does NOT pop up. 11. Set the SelfCheckReceiptPrompt syspref to "Don't show" 12. Log into self-check. 13. Check something out. 14. Click the "Finish" button. 15. Verify that the receipt dialog does NOT pop up. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11415 --- Comment #16 from M. Tompsett <mtompset@hotmail.com> --- Oops... got hit by the cut-and-paste problem. Fixed step 11. :) REVISED TEST PLAN ================= 0. ~/qa-test-tools/koha-qa.pl -v 2 -c 4 NOTE: Fix tabs. 1. Log into self-check as normal. (https://.../cgi-bin/koha/sco/sco-main.pl) 2. Check something out. 2. Click the "Finish" button. 3. Notice that receipt dialog pops up. 4. Apply patch. 5. Run updatedatabase.pl 6. Set the SelfCheckReceiptPrompt syspref to "Don't show" 7. Log into self-check. 8. Check something out. 9. Click the "Finish" button. 10. Verify that the receipt dialog does NOT pop up. 11. Set the SelfCheckReceiptPrompt syspref to "Show" 12. Log into self-check. 13. Check something out. 14. Click the "Finish" button. 15. Verify that the receipt dialog does NOT pop up -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11415 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24043|0 |1 is obsolete| | Attachment #24044|0 |1 is obsolete| | Attachment #24045|0 |1 is obsolete| | Attachment #24046|0 |1 is obsolete| | --- Comment #17 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 24130 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24130&action=edit Bug 11415: Add syspref to toggle SCO receipt printing Toggled SCO receipt printing to be on by default for upgrades in updatedatabase.pl. Updated files to set default to 1 in sysprefs.sql. Also added code to read the system preference on the template page. Added code to update prog theme with same changes as the bootstrap theme. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11415 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24130|0 |1 is obsolete| | --- Comment #18 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 24131 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24131&action=edit Bug 11415: Add syspref to toggle SCO receipt printing Toggled SCO receipt printing to be on by default for upgrades in updatedatabase.pl. Updated files to set default to 1 in sysprefs.sql. Also added code to read the system preference on the template page. Added code to update prog theme with same changes as the bootstrap theme. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Passes koha-qa.pl, works as advertised. No regressions noted. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11415 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11415 --- Comment #19 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 24132 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24132&action=edit Bug 11415 [QA Followup] - Add syspref to toggle SCO receipt printing -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11415 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #20 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Now Kyle was faster with doing QA:) Welcome JaTara! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11415 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #21 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Congratulations on having your first patch accepted into Koha, JaTara! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11415 Heather Braum <hbraum@nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum@nekls.org -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11415 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers@biblibre.co | |m --- Comment #22 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Pushed to 3.14.x, will be in 3.14.07. (created updatabase 3.14.06.001) -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org