[Bug 37934] New: Extend length of API Key, requestor ID and customer ID for data providers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37934 Bug ID: 37934 Summary: Extend length of API Key, requestor ID and customer ID for data providers Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: ERM Assignee: jonathan.druart@gmail.com Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: jonathan.druart@gmail.com, jonathan.field@ptfs-europe.com, martin.renvoize@ptfs-europe.com, matt.blenkinsop@ptfs-europe.com, pedro.amorim@ptfs-europe.com API Key, requestor ID and customer ID are defined as varchar(80). We had reports that this can be not enough in some cases. Suggestion is to extend to varchar(255). https://schema.koha-community.org/24_05/tables/erm_usage_data_providers.html -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37934 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |michaela.sieber@kit.edu -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37934 --- Comment #1 from Michaela Sieber <michaela.sieber@kit.edu> --- And for service_url 80 characters are not enough as well -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37934 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathsabypro@gmail.com --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 38807 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37934 --- Comment #3 from Mathieu Saby <mathsabypro@gmail.com> --- Is there a specification in SUSHI documentation regarding the lengh of those fields? I tried to search but I only found in their OpenAPI specification that those fields have "ApiKey" datatype, which does not seem to have a lenght limit. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37934 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Mathieu Saby from comment #3)
Is there a specification in SUSHI documentation regarding the lengh of those fields? I tried to search but I only found in their OpenAPI specification that those fields have "ApiKey" datatype, which does not seem to have a lenght limit.
I have wondered the same thing in order to make sure we pick the right datatypes here. Did you encounter anything close to 255 chars yet? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37934 --- Comment #5 from Jonathan Field <jonathan.field@ptfs-europe.com> --- (In reply to Katrin Fischer from comment #4)
(In reply to Mathieu Saby from comment #3)
Is there a specification in SUSHI documentation regarding the lengh of those fields? I tried to search but I only found in their OpenAPI specification that those fields have "ApiKey" datatype, which does not seem to have a lenght limit.
I have wondered the same thing in order to make sure we pick the right datatypes here. Did you encounter anything close to 255 chars yet?
(In reply to Mathieu Saby from comment #3)
Is there a specification in SUSHI documentation regarding the lengh of those fields? I tried to search but I only found in their OpenAPI specification that those fields have "ApiKey" datatype, which does not seem to have a lenght limit.
I think the NISO standard is the place to look - https://groups.niso.org/higherlogic/ws/public/download/29097/Z39-93-2014_SUS... - However, there don't seem to be restrictions on length. So, I guess we need to work with the longest examples we have. I think increasing to 255 would cover that, wouldn't you? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37934 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jonathan.druart@gmail.com |katrin.fischer@bsz-bw.de --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> ---
I think the NISO standard is the place to look - https://groups.niso.org/higherlogic/ws/public/download/29097/Z39-93- 2014_SUSHI-1_7.pdf - However, there don't seem to be restrictions on length. So, I guess we need to work with the longest examples we have. I think increasing to 255 would cover that, wouldn't you?
I believe so. It would be interesting to hear what the longest encountered were to see how close we get. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37934 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- @Michaela maybe: Can you check in your data for the length of your longest key? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37934 --- Comment #8 from Michaela Sieber <michaela.sieber@kit.edu> --- (In reply to Katrin Fischer from comment #7)
@Michaela maybe: Can you check in your data for the length of your longest key?
The longest API Key we have is for SAE Mobilus (see https://registry.countermetrics.org/platform/ee4dbcd0-e6ca-49c8-aca1-759eae5...) and it has 256 characters. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37934 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- That is a lot, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37934 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I wonder if we should just use text then. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37934 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 180107 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180107&action=edit Bug 37934: Extend data types for customer ID, requestor ID, and API key for ERM data providers This changes the datatype of customer ID, requestor ID, and API key from limited varchar to text to accustom for longer values. To test: * Apply the patch * Run updatedatabase (a sandbox will do this automatically) * Activate the ERM module in the system preferences (ERMModule) * Go to E-ressource management > Data providers > New data provider * Make sure you can enter values longer than 265 in the fields named above and that they are stored correctly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37934 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Extend length of API Key, |Extend length of API key, |requestor ID and customer |requestor ID and customer |ID for data providers |ID for data providers Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37934 Jesse Maseto <jesse@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37934 Jesse Maseto <jesse@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180107|0 |1 is obsolete| | --- Comment #12 from Jesse Maseto <jesse@bywatersolutions.com> --- Created attachment 180112 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180112&action=edit Bug 37934: Extend data types for customer ID, requestor ID, and API key for ERM data providers This changes the datatype of customer ID, requestor ID, and API key from limited varchar to text to accustom for longer values. To test: * Apply the patch * Run updatedatabase (a sandbox will do this automatically) * Activate the ERM module in the system preferences (ERMModule) * Go to E-ressource management > Data providers > New data provider * Make sure you can enter values longer than 265 in the fields named above and that they are stored correctly. Signed-off-by: Jesse Maseto <jesse@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37934 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37934 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180112|0 |1 is obsolete| | --- Comment #13 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 180273 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180273&action=edit Bug 37934: Extend data types for customer ID, requestor ID, and API key for ERM data providers This changes the datatype of customer ID, requestor ID, and API key from limited varchar to text to accustom for longer values. To test: * Apply the patch * Run updatedatabase (a sandbox will do this automatically) * Activate the ERM module in the system preferences (ERMModule) * Go to E-ressource management > Data providers > New data provider * Make sure you can enter values longer than 265 in the fields named above and that they are stored correctly. Signed-off-by: Jesse Maseto <jesse@bywatersolutions.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37934 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch CC| |lucas@bywatersolutions.com QA Contact|testopia@bugs.koha-communit |lucas@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37934 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37934 --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37934 Michaela Sieber <michaela.sieber@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_24_11_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37934 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to main |Pushed to stable Version(s)|25.05.00 |25.05.00,24.11.06 released in| | --- Comment #15 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 24.11.x for 24.11.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37934 Jesse Maseto <jesse@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jesse@bywatersolutions.com --- Comment #16 from Jesse Maseto <jesse@bywatersolutions.com> --- Merge conflicts with 24.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37934 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #17 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org