[Bug 10553] New: Public lists not available from OPAC login page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10553 Bug ID: 10553 Summary: Public lists not available from OPAC login page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org If as a non-logged-in user you try to access public lists from the lists button on the OPAC login page it will say there are no public lists. In fact the list of public lists is not made available to the login page by Auth.pm. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10553 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10553 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 19491 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19491&action=edit Bug 10553 - Public lists not available from OPAC login page If you are not logged in to the OPAC, looking at the login page, and you click the Lists button to see public lists it says there are none. This patch corrects Auth.pm so that it loads the list of public lists in this situation. To test you must have at least one public list. Make sure you are logged out of the OPAC and visit the login page (/cgi-bin/koha/opac-user.pl). Clicking the "Lists" button should show you a list of public shelves. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10553 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Owen, I haven't tested this, but I think there might be one case where we don't want to show any lists on the login page: when the opac is not public, but requires login for searching. Do you think this could be taken into account? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10553 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- If OpacPublic is set to make the OPAC not public the lists button does not appear at all. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10553 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Cool, thx Owen. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10553 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10553 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10553 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19491|0 |1 is obsolete| | --- Comment #5 from Liz Rea <liz@catalyst.net.nz> --- Created attachment 19743 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19743&action=edit Bug 10553 - Public lists not available from OPAC login page If you are not logged in to the OPAC, looking at the login page, and you click the Lists button to see public lists it says there are none. This patch corrects Auth.pm so that it loads the list of public lists in this situation. To test you must have at least one public list. Make sure you are logged out of the OPAC and visit the login page (/cgi-bin/koha/opac-user.pl). Clicking the "Lists" button should show you a list of public shelves. Signed-off-by: Liz Rea <liz@catalyst.net.nz> works as described, and list button is not shown when opacpublic is disabled. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10553 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10553 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19743|0 |1 is obsolete| | --- Comment #6 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 19749 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19749&action=edit Bug 10553 - Public lists not available from OPAC login page If you are not logged in to the OPAC, looking at the login page, and you click the Lists button to see public lists it says there are none. This patch corrects Auth.pm so that it loads the list of public lists in this situation. To test you must have at least one public list. Make sure you are logged out of the OPAC and visit the login page (/cgi-bin/koha/opac-user.pl). Clicking the "Lists" button should show you a list of public shelves. Signed-off-by: Liz Rea <liz@catalyst.net.nz> works as described, and list button is not shown when opacpublic is disabled. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10553 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10553 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #7 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- QA Comment: Works as advertised. Small change. Looks good to me. No complaints from koha-qa, no new warnings in log. Redefinition of $pubshelves in checkauth is not on same scope level. Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10553 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10553 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #8 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10553 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel@gmail.com --- Comment #9 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Pushed to 3.10.x, will be in 3.10.11 Already present on 3.12.4 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10553 Chris Hall <chrish@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chrish@catalyst.net.nz --- Comment #10 from Chris Hall <chrish@catalyst.net.nz> --- Pushed to 3.8.x, will be in 3.8.18 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org