[Bug 6259] New: AllowHoldPolicyOverride ON causes every staff hold to require override
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6259 Bug #: 6259 Summary: AllowHoldPolicyOverride ON causes every staff hold to require override Classification: Unclassified Change sponsored?: --- Product: Koha Version: rel_3_4 Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 Component: Hold requests AssignedTo: ian.walls@bywatersolutions.com ReportedBy: ruth@bywatersolutions.com QAContact: koha-bugs@lists.koha-community.org CC: gmcharlt@gmail.com if AllowHoldPolicyOverride is turned on, any attempt in the staff client to place a hold will require override, even if it should not. Turning the syspref OFF lets normal rules take over. In reserve/request.pl, right after the comment " If AllowHoldPolicyOverride is set, it should override EVERY..." (circa line 444-450) seems to be the crux of the matter. It should, I suspect, check to see if item->{available} is already *set* before setting $item->{override}. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6259 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent CC| |nengard@gmail.com Patch Status|--- |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6259 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Version|rel_3_4 |rel_3_6 --- Comment #1 from Chris Cormack <chris@bigballofwax.co.nz> 2011-04-27 04:22:17 UTC --- Pushed, please test -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6259 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Signed Off |Patch Pushed -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6259 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |robin@catalyst.net.nz Resolution| |FIXED --- Comment #2 from Robin Sheat <robin@catalyst.net.nz> 2011-06-23 09:17:40 UTC --- Tested, works on both master and 3.4.x -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6259 --- Comment #3 from Robin Sheat <robin@catalyst.net.nz> 2011-06-23 09:21:00 UTC --- To clarify, afaik it hasn't been pulled into 3.4.x, but it should be and it works there. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org