[Bug 8581] New: Authority display doesn't like GND records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8581 Priority: P5 - low Change sponsored?: --- Bug ID: 8581 CC: katrin.fischer@bsz-bw.de Assignee: jcamins@cpbibliography.com Summary: Authority display doesn't like GND records Severity: normal Classification: Unclassified OS: All Reporter: jcamins@cpbibliography.com Hardware: All Status: NEW Version: master Component: MARC Authority data support Product: Koha -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8581 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |3462 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8581 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8581 --- Comment #1 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Created attachment 11391 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11391&action=edit Bug 8581: don't display parentheses when we don't have a type Prior to this patch, see also references in certain authority records (most notably GND records) were being followed by empty parentheses in the search results display. This patch resolves that problem. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8581 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11391|0 |1 is obsolete| | --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 11395 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11395&action=edit Bug 8581: don't display parentheses when we don't have a type Prior to this patch, see also references in certain authority records (most notably GND records) were being followed by empty parentheses in the search results display. This patch resolves that problem. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8581 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |chris@bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8581 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |mtj@kohaaloha.com --- Comment #3 from Mason James <mtj@kohaaloha.com> --- (In reply to comment #2)
Created attachment 11395 [details] Bug 8581: don't display parentheses when we don't have a type
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
patch looks good, passing QA *NOTE: PATCH MUST BE APPLIED AFTER 3462* mason@xen1:~/git/head$ git bz apply 3462 Bug 3462 - Link see alsos in authorities Bug 3462: Links in authorities should be hyperlinks Apply? [yn] y Applying: Bug 3462: Links in authorities should be hyperlinks mason@xen1:~/git/head$ git bz apply 8581 Bug 8581 - Authority display doesn't like GND records Bug 8581: don't display parentheses when we don't have a type Apply? [yn] y Applying: Bug 8581: don't display parentheses when we don't have a type mason@xen1:~/git/head$ mason@xen1:~/git/head$ koha-qa.pl * 645650a Bug 8581: don't display parentheses when we don't have a type koha-tmpl/intranet-tmpl/prog/en/includes/authorities-search-results.inc koha-tmpl/opac-tmpl/prog/en/includes/authorities-search-results.inc - perlcritic-progressive tests... OK - perl -c syntax tests... OK - xt/tt_valid.t tests... OK - xt/author/valid-template.t tests... OK mason@xen1:~/git/head$ -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8581 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain@biblibre.com Version|master |rel_3_8 --- Comment #4 from Paul Poulain <paul.poulain@biblibre.com> --- Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8581 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8581 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8581 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #5 from Paul Poulain <paul.poulain@biblibre.com> --- sorry, save hit too fast... The patch does not apply. Looking at koha-tmpl/intranet-tmpl/prog/en/includes/authorities-search-results.inc I see that the patch says: - [% CASE %]([% type | html %]) + [% CASE %][% IF type %]([% type | html %])[% END %] and I have: [% CASE %]([% type %]) (not type|html) WTF ? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8581 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Jared, can you take a look at this please? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8581 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA --- Comment #7 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Setting back to "Passed QA" as the patch applies fine on current master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8581 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #8 from Paul Poulain <paul.poulain@biblibre.com> --- Patch pushed to master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8581 --- Comment #9 from Chris Cormack <chris@bigballofwax.co.nz> --- Could you please rebase this for 3.8.x -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8581 --- Comment #10 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Created attachment 12630 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12630&action=edit [3.8.x] Bug 8581: don't display parentheses when we don't have a type Prior to this patch, see also references in certain authority records (most notably GND records) were being followed by empty parentheses in the search results display. This patch resolves that problem. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8581 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11395|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8581 --- Comment #11 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Patch rebased for 3.8.x attached. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8581 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #12 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.8.x, will be in 3.8.6 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8581 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED --- Comment #13 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This has been fixed in Master. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org