[Bug 12948] New: The language filter in advance search doen't work with DOM MARC21 - NORMARC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12948 Bug ID: 12948 Summary: The language filter in advance search doen't work with DOM MARC21 - NORMARC Change sponsored?: Sponsored Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Searching Assignee: z.tajoli@cineca.it Reporter: z.tajoli@cineca.it QA Contact: testopia@bugs.koha-community.org The filter 'language' in Advanced Search works on 041 data and not with data in 008 pos 35-28. I think there is an 'ln:n' instead of 'ln:w' in specific lines of marc21/biblios/biblio-koha-indexdefs.xml. This bug is present only on DOM indexing setup for MARC21 and probably in NORMARC. The Unimarc equivalent is OK -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12948 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus@enger.priv.no --- Comment #1 from Magnus Enger <magnus@enger.priv.no> --- Zeno: You are right, ln:n needs to be replaced with ln:w, both for MARC21 and NORMARC. I can do a patch, but now that grs1 is on the way out, do we still edit biblio-koha-indexdefs.xml and generate biblio-zebra-indexdefs.xsl from that, or do we edit biblio-zebra-indexdefs.xsl directly? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12948 --- Comment #2 from Zeno Tajoli <z.tajoli@cineca.it> --- Hi, I think that the best option now is to edit biblio-koha-indexdefs.xml and generate biblio-zebra-indexdefs.xsl from that. But I ask about this topic in koha-dev: http://lists.koha-community.org/pipermail/koha-devel/2015-February/041178.ht... Bye -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12948 --- Comment #3 from Magnus Enger <magnus@enger.priv.no> --- Thanks! Feel free to do the patch if you want. :-) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12948 Zeno Tajoli <z.tajoli@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12948 --- Comment #4 from Zeno Tajoli <z.tajoli@cineca.it> --- Created attachment 35921 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35921&action=edit Patch for MARC21 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12948 --- Comment #5 from Zeno Tajoli <z.tajoli@cineca.it> --- Created attachment 35922 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35922&action=edit Patch for Normarc -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12948 Zeno Tajoli <z.tajoli@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #6 from Zeno Tajoli <z.tajoli@cineca.it> --- To test on MARC21: 1)Setup a site with MARC21 2)Insert 2 record, one lang A in 041 and 008 pos 35-37 an other with lang A in 041 and lang B in 008 pos 35-37 3)Index them 4)Search in advanced search with filter 'languare' for lan A. You will see 2 records 5)Search in advanced search with filter 'languare' for lan B. You will see 0 records 6)Apply the patch 7)Full reindex 8)Search in advanced search with filter 'languare' for lan B. You will see 1 records To test on Normarc: the same as MARC21, but you need a Normarc setup -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12948 --- Comment #7 from Magnus Enger <magnus@enger.priv.no> --- (In reply to Zeno Tajoli from comment #2)
Hi,
I think that the best option now is to edit biblio-koha-indexdefs.xml and generate biblio-zebra-indexdefs.xsl from that.
But I ask about this topic in koha-dev: http://lists.koha-community.org/pipermail/koha-devel/2015-February/041178. html
Tomas answered this on the mailing list, I'm pasting in the answer here for future reference: --- The existence of biblio-koha-indexdefs.xml is not related to GRS-1 right now. It might have been (for a while) a way to transform the record.abs file into something translatable to XSLT. But it is a more useful thing now. The XML file provides with a user-friendly syntax for defining indexes (and now also facets). The etc/zebradb/xsl/koha-indexdefs-to-zebra.xsl file is designed to process that syntax for creating a suitable XSLT for use in DOM. So, if you want to change some indexes, or facet definitions: do it on the XML file. If you want to change the behaviour of DOM indexing (for example, you could want to generate an index for the 'availability' filter on each record, so it is calculated on indexing time instead of complex un-doable PQF queries), then you should patch the meta-XSLT (koha-indexdefs-to-zebra.xsl) so it generates an XSLT that generates that specific index out of a MARCXML record. It's been a while since we stopped re-generating the DOM files from the GRS-1, as we've been forcing people to fix both GRS-1 *and* DOM each time. Hope this clarifies the landscape. Regards Tomas http://lists.koha-community.org/pipermail/koha-devel/2015-February/041179.ht... -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12948 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35922|0 |1 is obsolete| | --- Comment #8 from Magnus Enger <magnus@enger.priv.no> --- Created attachment 35923 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35923&action=edit Bug 12948 - [SIGNED-OFF] Patch-for-filter-language-in-Advanced-Search This patch is for Normarc Same test plan as patch for MARC21, except you need a setup with Normarc. http://bugs.koha-community.org/show_bug.cgi?id=12948 Signed-off-by: Magnus Enger <magnus@enger.priv.no> - Added a record with "bul" in 008pos35-37 - Verified that this did not turn up in an advanced search with language = Bulgarian - Applied the patch - I was testing on a gitified install, so I had to copy the patched index file to the right location with this command: sudo cp etc/zebradb/marc_defs/normarc/biblios/biblio-zebra-indexdefs.xsl \ /etc/koha/zebradb/marc_defs/normarc/biblios/biblio-zebra-indexdefs.xsl - Did a full reindex - Verified that the record *did* turn up in an advanced search with language = Bulgarian - Signing off! Thanks Zeno! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12948 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12948 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35921|0 |1 is obsolete| | --- Comment #9 from Magnus Enger <magnus@enger.priv.no> --- Created attachment 35924 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35924&action=edit Bug 12948 - [SIGNED-OFF] Patch for filter 'language' in Advanced Search. This patch is for MARC21. To test: 1)Setup a site with MARC21 2)Insert 2 record, one lang A in 041 and 008 pos 35-37 an other with lang A in 041 and lang B in 008 pos 35-37 3)Index them 4)Search in advanced search with filter 'languare' for lan A. You will see 2 records 5)Search in advanced search with filter 'languare' for lan B. You will see 0 records 6)Apply the patch 7)Full reindex 8)Search in advanced search with filter 'languare' for lan B. You will see 1 records http://bugs.koha-community.org/show_bug.cgi?id=12948 Signed-off-by: Magnus Enger <magnus@enger.priv.no> I have *not* actually tested this, but the changes are identical to the ones done for NORMARC, which I have tested, so I think it is safe to sign off. If anyone disagrees, please reset the bug to "Needs signoff". -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12948 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |januszop@gmail.com --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> --- *** Bug 13725 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12948 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12948 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35923|0 |1 is obsolete| | --- Comment #11 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 35990 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35990&action=edit [SIGNED OFF] Bug 12948: Use word indexing for language (NORMARC) This patch is for Normarc Same test plan as patch for MARC21, except you need a setup with Normarc. http://bugs.koha-community.org/show_bug.cgi?id=12948 Signed-off-by: Magnus Enger <magnus@enger.priv.no> - Added a record with "bul" in 008pos35-37 - Verified that this did not turn up in an advanced search with language = Bulgarian - Applied the patch - I was testing on a gitified install, so I had to copy the patched index file to the right location with this command: sudo cp etc/zebradb/marc_defs/normarc/biblios/biblio-zebra-indexdefs.xsl \ /etc/koha/zebradb/marc_defs/normarc/biblios/biblio-zebra-indexdefs.xsl - Did a full reindex - Verified that the record *did* turn up in an advanced search with language = Bulgarian - Signing off! Thanks Zeno! Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12948 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35924|0 |1 is obsolete| | --- Comment #12 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 35991 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35991&action=edit [SIGNED OFF] Bug 12948: Use word indexing for language (MARC21) This patch is for MARC21. To test: 1)Setup a site with MARC21 2)Insert 2 record, one lang A in 041 and 008 pos 35-37 an other with lang A in 041 and lang B in 008 pos 35-37 3)Index them 4)Search in advanced search with filter 'languare' for lan A. You will see 2 records 5)Search in advanced search with filter 'languare' for lan B. You will see 0 records 6)Apply the patch 7)Full reindex 8)Search in advanced search with filter 'languare' for lan B. You will see 1 records http://bugs.koha-community.org/show_bug.cgi?id=12948 Signed-off-by: Magnus Enger <magnus@enger.priv.no> I have *not* actually tested this, but the changes are identical to the ones done for NORMARC, which I have tested, so I think it is safe to sign off. If anyone disagrees, please reset the bug to "Needs signoff". Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12948 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12948 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35990|0 |1 is obsolete| | Attachment #35991|0 |1 is obsolete| | --- Comment #13 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 36090 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36090&action=edit [PASSED QA] Bug 12948: Use word indexing for language (NORMARC) This patch is for Normarc Same test plan as patch for MARC21, except you need a setup with Normarc. http://bugs.koha-community.org/show_bug.cgi?id=12948 Signed-off-by: Magnus Enger <magnus@enger.priv.no> - Added a record with "bul" in 008pos35-37 - Verified that this did not turn up in an advanced search with language = Bulgarian - Applied the patch - I was testing on a gitified install, so I had to copy the patched index file to the right location with this command: sudo cp etc/zebradb/marc_defs/normarc/biblios/biblio-zebra-indexdefs.xsl \ /etc/koha/zebradb/marc_defs/normarc/biblios/biblio-zebra-indexdefs.xsl - Did a full reindex - Verified that the record *did* turn up in an advanced search with language = Bulgarian - Signing off! Thanks Zeno! Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12948 --- Comment #14 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 36091 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36091&action=edit [PASSED QA] Bug 12948: Use word indexing for language (MARC21) This patch is for MARC21. To test: 1)Setup a site with MARC21 2)Insert 2 record, one lang A in 041 and 008 pos 35-37 an other with lang A in 041 and lang B in 008 pos 35-37 3)Index them 4)Search in advanced search with filter 'languare' for lan A. You will see 2 records 5)Search in advanced search with filter 'languare' for lan B. You will see 0 records 6)Apply the patch 7)Full reindex 8)Search in advanced search with filter 'languare' for lan B. You will see 1 records http://bugs.koha-community.org/show_bug.cgi?id=12948 Signed-off-by: Magnus Enger <magnus@enger.priv.no> I have *not* actually tested this, but the changes are identical to the ones done for NORMARC, which I have tested, so I think it is safe to sign off. If anyone disagrees, please reset the bug to "Needs signoff". Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12948 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #15 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Thanks Zeno! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12948 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #16 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.18.x will be in 3.18.4 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org