[Bug 8439] New: Printing basketgroup does not work on plack
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8439 Priority: P5 - low Change sponsored?: --- Bug ID: 8439 CC: dpavlin@rot13.org Assignee: koha-bugs@lists.koha-community.org Summary: Printing basketgroup does not work on plack Severity: critical Classification: Unclassified OS: All Reporter: paul.poulain@biblibre.com Hardware: All Status: NEW Version: master Component: Acquisitions Product: Koha When you try to print a basketgroup under Plack, you get a nasty : Can't call method "header" on an undefined value at /home/paul/koha.dev/koha-community/acqui/basketgroup.pl line 271. at /home/paul/koha.dev/koha-community/acqui/basketgroup.pl line 492 The exact same URL under CGI works fine. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8439 --- Comment #1 from Dobrica Pavlinusic <dpavlin@rot13.org> --- Created attachment 10868 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10868&action=edit Bug 8439 - Printing basketgroup does not work on plack scope $input CGI object with our for plack -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8439 Dobrica Pavlinusic <dpavlin@rot13.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs@lists.koha-commun |dpavlin@rot13.org |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8439 --- Comment #2 from Dobrica Pavlinusic <dpavlin@rot13.org> --- Created attachment 11024 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11024&action=edit Bug 8439 - plack code cleanup - remove all exit(1) and replace them with __END__ which benefits CGI - insert correct =cut markers at end of POD (required for CGI::Compile under plack to correctly parse source code and exeute it) - scope variables with our which are used inside sub for plack -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8439 Mirko Tietgen <5p4m@gmx.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10868|0 |1 is obsolete| | --- Comment #3 from Mirko Tietgen <5p4m@gmx.de> --- Created attachment 11030 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11030&action=edit [SIGNED-OFF] Bug 8439 - Printing basketgroup does not work on plack scope $input CGI object with our for plack Signed-off-by: Mirko Tietgen <5p4m@gmx.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8439 Mirko Tietgen <5p4m@gmx.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |5p4m@gmx.de --- Comment #4 from Mirko Tietgen <5p4m@gmx.de> --- The first patch fixes the problem of printing a basket group and is signed off. The second patch seems to be unrelated to this bug, I have not tested it. I mark this as signed off now so the first patch can go to QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8439 Dobrica Pavlinusic <dpavlin@rot13.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11024|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8439 --- Comment #5 from Dobrica Pavlinusic <dpavlin@rot13.org> --- Sorry about confusion, second patch was supposed to end up in Bug 8482 - labels creator fixes for plack -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8439 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #6 from Paul Poulain <paul.poulain@biblibre.com> --- QA comment: tiny patch, same as what is made for other patches for Plack -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8439 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|master |rel_3_8 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8439 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #7 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.8.x, will be in 3.8.4 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org