[Bug 30734] New: t/db_dependent/Koha/BackgroundJob.t fails on D9 and D10
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30734 Bug ID: 30734 Summary: t/db_dependent/Koha/BackgroundJob.t fails on D9 and D10 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris@bigballofwax.co.nz Reporter: fridolin.somers@biblibre.com QA Contact: testopia@bugs.koha-community.org t/db_dependent/Koha/BackgroundJob.t fails on D9 and D10 : koha_1 | # Failed test 'No tests run for subtest "decoded_data() and set_encoded_data() tests"' koha_1 | # at t/db_dependent/Koha/BackgroundJob.t line 169. koha_1 | hash- or arrayref expected (not a simple scalar, use allow_nonref to allow this) at /kohadevbox/koha/Koha/BackgroundJob.pm line 262. koha_1 | # Looks like your test exited with 255 just after 4. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30734 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |critical -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30734 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com Depends on| |30360 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30360 [Bug 30360] Add helper methods to Koha::BackgroundJobs -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30734 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30734 --- Comment #1 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 134920 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134920&action=edit Bug 30734: Fix BackgroundJob.t Added test for empty string or undefined. We could still consider evaling the json operations. Test plan: Run t/db_dependent/Koha/BackgroundJob.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30734 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|critical |normal CC| |m.de.rooy@rijksmuseum.nl Status|Needs Signoff |Signed Off --- Comment #2 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Trivial: self SO -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30734 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris@bigballofwax.co.nz |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30734 --- Comment #3 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Why only on D9 and D10? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30734 --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #3)
Why only on D9 and D10?
Apparently, Fridolin saw it there. But it could be removed imo. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30734 --- Comment #5 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Marcel de Rooy from comment #4)
(In reply to Jonathan Druart from comment #3)
Why only on D9 and D10?
Apparently, Fridolin saw it there. But it could be removed imo.
I don't recreate on D11, so I think it's valid for D9 and D10 only, but I don't understand why -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30734 --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #5)
(In reply to Marcel de Rooy from comment #4)
(In reply to Jonathan Druart from comment #3)
Why only on D9 and D10?
Apparently, Fridolin saw it there. But it could be removed imo.
I don't recreate on D11, so I think it's valid for D9 and D10 only, but I don't understand why
Could be related to the JSON module version on D11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30734 --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- Could we say it is passed QA ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30734 --- Comment #8 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Fridolin Somers from comment #7)
Could we say it is passed QA ?
It is a trivial patch and you are RM :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30734 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #9 from Fridolin Somers <fridolin.somers@biblibre.com> --- I want my jenkins green. Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30734 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30734 --- Comment #10 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30734 Bug 30734 depends on bug 30360, which changed state. Bug 30360 Summary: Add helper methods to Koha::BackgroundJobs https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30360 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org