[Bug 23527] New: BakerTaylorBookstoreURL is converted to escaped characters by template, rendering it invalid
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23527 Bug ID: 23527 Summary: BakerTaylorBookstoreURL is converted to escaped characters by template, rendering it invalid Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: techservspec@gmail.com QA Contact: testopia@bugs.koha-community.org The url stored in the preference BakerTaylorBookstoreURL is rendered in opac-detail.tt with escaped characters (including the "/", "?" and "=" characters which are designating subdirectories and parameters), thus making the resulting link invalid. For example: The URL used for BakerTaylorBookstoreURL is https://contentcafe2.btol.com/ContentCafeClient/ContentCafe.aspx?UserID= However, what is rendered in the OPAC is https://contentcafe2.btol.com%2FContentCafeClient%2FContentCafe.aspx%3FUserI... To test this (requires a Baker & Taylor username and id): 1. Enter contentcafe2.btol.com/ContentCafeClient/ContentCafe.aspx?UserID=(your username)&Password=(your password)&ItemKey= into the BakerTaylorBookstoreURL preference and enable Baker & Taylor images. 2. Display a record that has a cover image in the OPAC. 3. Click on the image. You are not redirected to the above url (in firefox nothing happens, in chrome you are directed to "about:blank#blocked"). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23527 David Kuhn <techservspec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |techservspec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23527 --- Comment #1 from David Kuhn <techservspec@gmail.com> --- This also occurs in opac-search.tt. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23527 --- Comment #2 from David Kuhn <techservspec@gmail.com> --- Sorry, I mean opac-results.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23527 David Kuhn <techservspec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23527 --- Comment #3 from David Kuhn <techservspec@gmail.com> --- Created attachment 92516 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92516&action=edit Bug 23527 - BakerTaylorBookstoreURL is converted to escaped characters by template, rendering it invalid Changing the template toolkit filter for rendering the value of BakerTaylorBookstoreURL in opac-detail.tt and opac-results.tt from uri to url fixes the problem. To test (requires a Baker & Taylor username and password): 1. Enter the B&T url into BakerTaylorBookstoreURL. 2. Set BakerTaylorEnabled to "add" and enter your username and password. 3. Look up a title in the OPAC. 4. Locate a title with a cover image. 5. Click on the cover image. You are not redirected to the url stored in BakerTaylorBookstoreURL. 6. Display the full record for the title 7. Click on the cover image. You are not redirected to the url stored in BakerTaylorBookstoreURL. 8. Apply the patch. 9. Refresh the OPAC display. 10. Click on the cover image. You are now redirected to the specified url. 11. Return to the results list. 12. Click on a cover image. You are now redirected to the specified url. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23527 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |techservspec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23527 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de, | |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23527 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23527 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92516|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 98950 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98950&action=edit Bug 23527 - BakerTaylorBookstoreURL is converted to escaped characters by template, rendering it invalid Changing the template toolkit filter for rendering the value of BakerTaylorBookstoreURL in opac-detail.tt and opac-results.tt from uri to url fixes the problem. To test (requires a Baker & Taylor username and password): 1. Enter the B&T url into BakerTaylorBookstoreURL. 2. Set BakerTaylorEnabled to "add" and enter your username and password. 3. Look up a title in the OPAC. 4. Locate a title with a cover image. 5. Click on the cover image. You are not redirected to the url stored in BakerTaylorBookstoreURL. 6. Display the full record for the title 7. Click on the cover image. You are not redirected to the url stored in BakerTaylorBookstoreURL. 8. Apply the patch. 9. Refresh the OPAC display. 10. Click on the cover image. You are now redirected to the specified url. 11. Return to the results list. 12. Click on a cover image. You are now redirected to the specified url. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Although I don't have valid Baker & Taylor credentials I was able to use dummy data to verify that the links in the template are correctly encoded with this patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23527 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23527 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 99127 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99127&action=edit Bug 23527: BakerTaylorBookstoreURL is converted to escaped characters by template, rendering it invalid Changing the template toolkit filter for rendering the value of BakerTaylorBookstoreURL in opac-detail.tt and opac-results.tt from uri to url fixes the problem. To test (requires a Baker & Taylor username and password): 1. Enter the B&T url into BakerTaylorBookstoreURL. 2. Set BakerTaylorEnabled to "add" and enter your username and password. 3. Look up a title in the OPAC. 4. Locate a title with a cover image. 5. Click on the cover image. You are not redirected to the url stored in BakerTaylorBookstoreURL. 6. Display the full record for the title 7. Click on the cover image. You are not redirected to the url stored in BakerTaylorBookstoreURL. 8. Apply the patch. 9. Refresh the OPAC display. 10. Click on the cover image. You are now redirected to the specified url. 11. Return to the results list. 12. Click on a cover image. You are now redirected to the specified url. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Although I don't have valid Baker & Taylor credentials I was able to use dummy data to verify that the links in the template are correctly encoded with this patch. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23527 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98950|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23527 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi David, just a tiny thing - the subject line of the patch always needs to start with XXXX: - fixed it during my QA. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23527 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23527 --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23527 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00 |20.05.00, 19.11.04 released in| | Status|Pushed to master |Pushed to stable CC| |joy@bywatersolutions.com --- Comment #8 from Joy Nelson <joy@bywatersolutions.com> --- Pushed to 19.11.x branch for 19.11.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23527 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Pushed to stable |Pushed to oldstable Version(s)|20.05.00, 19.11.04 |20.05.00, 19.11.04, released in| |19.05.09 --- Comment #9 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 19.05.x for 19.05.09 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org