[Bug 8436] New: Add branch limit on checkexpiration.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8436 Priority: P5 - low Change sponsored?: --- Bug ID: 8436 CC: colin.campbell@ptfs-europe.com Assignee: koha-bugs@lists.koha-community.org Summary: Add branch limit on checkexpiration.pl Severity: enhancement Classification: Unclassified OS: All Reporter: claire.hernandez@biblibre.com Hardware: All Status: NEW Version: unspecified Component: Serials Product: Koha This limit is available only if user is superlibrarian or has the permission 'superserials'. Otherwise, only subscriptions that are linked to the working branch are shown. (BibLibre stetienne/ft/MT6725) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8436 claire.hernandez@biblibre.com <claire.hernandez@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |8435 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8436 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |julian.maurice@biblibre.com Assignee|koha-bugs@lists.koha-commun |julian.maurice@biblibre.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8436 --- Comment #1 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 11742 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11742&action=edit Bug 8436: Add limit on branch in checkexpiration.pl This limit is only available for superlibrarians and patrons that have superserials permission. Other patrons will only see subscriptions of their branch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8436 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8436 --- Comment #2 from Julian Maurice <julian.maurice@biblibre.com> --- Note that this patch depends on Bug 8435 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8436 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11742|0 |1 is obsolete| | --- Comment #3 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 11746 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11746&action=edit Bug 8436: Add limit on branch in checkexpiration.pl This limit is only available for superlibrarians and patrons that have superserials permission. Other patrons will only see subscriptions of their branch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8436 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |gmcharlt@gmail.com --- Comment #4 from Galen Charlton <gmcharlt@gmail.com> --- Patch does not apply; please rebase and resubmit. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8436 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8436 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11746|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 19262 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19262&action=edit Bug 8436: Add limit on branch in checkexpiration.pl This limit is only available for superlibrarians and patrons that have superserials permission. Other patrons will only see subscriptions of their branch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8436 I'm just a bot <gitbot@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gitbot@bugs.koha-community. | |org When did the bot| |2013-09-29 last check this| | --- Comment #6 from I'm just a bot <gitbot@bugs.koha-community.org> --- Patch applied cleanly, go forth and signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8436 --- Comment #7 from I'm just a bot <gitbot@bugs.koha-community.org> --- Patch applied cleanly, go forth and signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8436 I'm just a bot <gitbot@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- When did the bot|2013-09-29 00:00:00 |2013-10-25 last check this| | --- Comment #8 from I'm just a bot <gitbot@bugs.koha-community.org> --- Patch applied cleanly, go forth and signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8436 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #9 from Chris Cormack <chris@bigballofwax.co.nz> --- Can I get a test plan on this please so I can signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8436 Jesse Maseto <jesse@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jesse@bywatersolutions.com --- Comment #10 from Jesse Maseto <jesse@bywatersolutions.com> --- Julian, Can you send a testing plan for us to follow. -Jesse -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8436 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8436 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha@univ-lyon3.fr --- Comment #11 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- difficult to test this patch before solving bug 12452 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8436 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paola.rossi@cineca.it Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8436 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19262|0 |1 is obsolete| | --- Comment #12 from Paola Rossi <paola.rossi@cineca.it> --- Created attachment 35166 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35166&action=edit [SIGNED OFF] Bug 8436: Add limit on branch in checkexpiration.pl I've applied the patch against master 3.19.00.005 head 12868 If a subscription will expire in the future, it can be selected [and listed] by : /koha/serials/checkexpiration.pl Home › Serials › Check expiration either on master or after having applied this patch. So imo I can test this patch. After having applied this patch on checkexpiration.pl : 1) a superlibrarian could select all the subscriptions, just as required; 2) if IndependentBranches syspref is set to "Prevent", a (Staff) superlibrarian without "superserials" permission could select only the subscriptions of his own branch, just as required; 3) if IndependentBranches syspref is set to "Prevent", a "Patron" librarian without "superserials" permission (and with all the other serials' permissions + catalogue's permission) could select only the subscriptions of his own branch, just as required; 4) if IndependentBranches syspref is set to "Prevent", a librarian without "superserials" permission could select the subscriptions of "none" branch, just as required; 5) if IndependentBranches syspref is set to "Don't prevent", a superlibrarian without "superserials" permission could select all the subscriptions, just as required. So I pass the patch to "Signed Off" status. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8436 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Julian, could you take a look at the search for the expiration date? I think I can see bug 12452. I have a serial subscription with expiration date on 10/09/2014. If I use the filter on the left side of the subscription search with 01/10/2014 the subscription shows up (as it should). But when I repeat the same search on the 'check expiration' page, the subscription is not found. Using iso formatted dates dd/mm/yyyy. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8436 --- Comment #14 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Katrin Fischer from comment #13) I answered on bug 12452. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8436 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Signed Off |Failed QA --- Comment #15 from Kyle M Hall <kyle@bywatersolutions.com> --- Can you please use C4::Branch::GetBranchesLoop rather than GetBranches with bespoke selection logic? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8436 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8436 --- Comment #16 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 36062 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36062&action=edit Bug 8436: Replace GetBranches with GetBranchesLoop The branch selection logic still exists in GetBranchesLoop, it should be used here. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8436 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8436 --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Comment on attachment 35166 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35166 [SIGNED OFF] Bug 8436: Add limit on branch in checkexpiration.pl Review of attachment 35166: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=8436&attachment=35166) ----------------------------------------------------------------- ::: serials/checkexpiration.pl @@ +106,5 @@
} + +my $branchname; +my @branches_loop; +if ( $flags->{superlibrarian}
I think we should be using C4::Context->IsSuperLibrarian() here - please check! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8436 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8436 --- Comment #18 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 41891 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41891&action=edit Bug 8436: Use C4::Context->IsSuperLibrarian() -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8436 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8436 --- Comment #19 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 43646 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43646&action=edit [PASSED QA] Bug 8436: Add limit on branch in checkexpiration.pl This limit is only available for superlibrarians and patrons that have superserials permission. Other patrons will only see subscriptions of their branch. Signed-off-by: Paola Rossi <paola.rossi@cineca.it> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8436 --- Comment #20 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 43647 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43647&action=edit [PASSED QA] Bug 8436: Replace GetBranches with GetBranchesLoop The branch selection logic still exists in GetBranchesLoop, it should be used here. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8436 --- Comment #21 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 43648 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43648&action=edit [PASSED QA] Bug 8436: Use C4::Context->IsSuperLibrarian() Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8436 --- Comment #22 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 43649 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43649&action=edit Bug 8436: QA Follow-up: Activate branch filter, if IndependentBranches is off The superserials permission is only in use in combination with IndependentBranches - so it makes sense to also show the branch filter when IndependentBranches is off. Permission description: superserials Manage subscriptions from any branch (only applies when IndependentBranches is used) Also adds a missing check for superlibraian. Note: the duplicated permission check in the code is not really nice - would be good to rewrite this to be more clean. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8436 --- Comment #23 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 43650 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43650&action=edit Bug 8436: QA Follow-up: Add Library to result list If we offer a library filter, we should also show the library in the result list, so that search options and result list match. Otherwise, for libraries with multiple branches, there is no way to see, which is the subscription of a specific branch in the list. - Add a Library column in the result list - Rename branch to library in the template -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8436 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41891|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8436 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36062|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8436 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35166|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8436 --- Comment #24 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am guilty of 2 small follow-ups here - Julian or some other QA person - could you take a look? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8436 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8436 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43649|0 |1 is obsolete| | Attachment #43650|0 |1 is obsolete| | --- Comment #25 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 43750 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43750&action=edit [PASSED QA] Bug 8436: QA Follow-up: Activate branch filter, if IndependentBranches is off The superserials permission is only in use in combination with IndependentBranches - so it makes sense to also show the branch filter when IndependentBranches is off. Permission description: superserials Manage subscriptions from any branch (only applies when IndependentBranches is used) Also adds a missing check for superlibraian. Note: the duplicated permission check in the code is not really nice - would be good to rewrite this to be more clean. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8436 --- Comment #26 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 43751 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43751&action=edit [PASSED QA] Bug 8436: QA Follow-up: Add Library to result list If we offer a library filter, we should also show the library in the result list, so that search options and result list match. Otherwise, for libraries with multiple branches, there is no way to see, which is the subscription of a specific branch in the list. - Add a Library column in the result list - Rename branch to library in the template Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8436 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Passed QA |Pushed to Master --- Comment #27 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Thanks Julian! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org