[Bug 6000] New: Performance enhancements for C4::Context and C4::Languages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6000 Bug #: 6000 Summary: Performance enhancements for C4::Context and C4::Languages Classification: Unclassified Change sponsored?: --- Product: Koha Version: rel_3_4 Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 Component: Architecture, internals, and plumbing AssignedTo: gmcharlt@gmail.com ReportedBy: chris@bigballofwax.co.nz QAContact: koha-bugs@lists.koha-community.org Blocks: 5999 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6000 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Patch Status|--- |Needs Signoff --- Comment #1 from Chris Cormack <chris@bigballofwax.co.nz> 2011-03-29 23:03:40 UTC --- This probably needs a decent amount of testing. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6000 --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> 2011-03-29 23:04:12 UTC --- Created attachment 3514 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3514 Proposed Patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6000 --- Comment #3 from Chris Cormack <chris@bigballofwax.co.nz> 2011-03-29 23:07:04 UTC --- Created attachment 3515 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3515 Followup patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6000 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|gmcharlt@gmail.com |henridamien@koha-fr.org -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6000 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|rel_3_4 |Rel_3_8 --- Comment #4 from Paul Poulain <paul.poulain@biblibre.com> 2011-10-24 11:38:13 UTC --- Updating Version : This ENH will be for Koha 3.8 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6000 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|Rel_3_8 |master --- Comment #5 from Paul Poulain <paul.poulain@biblibre.com> 2011-10-25 15:05:47 UTC --- Bug versionned for master. entries will be made against rel_3_8 once the patch has been applied (see thread about that on koha-devel yesterday) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6000 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |7119 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6000 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com Blocks| |7119 Depends on|7119 | AssignedTo|henridamien@koha-fr.org |paul.poulain@biblibre.com -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6000 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Patch Status|Needs Signoff |Does not apply -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6000 --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> 2012-01-04 13:13:09 UTC --- I think we need to define a new helper routine in Context.pm that returns the whole preferences, and memoize that one. The way it is now memoize wont help. I'll send to HDL a proposal. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6000 --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> 2012-01-04 16:07:46 UTC --- Created attachment 7037 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7037 Bug 6000 : Performance enhancing C4::Context.pm Loads all systempreferences at once And uses Memcached to cache them C4::Languages Using List::MoreUtils Memcaching get_langage_description Bug 6000 : Follow up Performance enhancing : C4/Languages.pm removing a call unused to getAllLanguages Doing better job at enabled languages Bug 6000: Rebase against origin/master + 6193 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6000 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #3515|0 |1 is obsolete| | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6000 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #3514|0 |1 is obsolete| | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6000 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Does not apply |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6000 --- Comment #8 from Julian Maurice <julian.maurice@biblibre.com> 2012-01-04 16:15:06 UTC --- In reply to comment 7 With this code:
my $oldsyspref = C4::Context->preference('SYSPREF'); C4::Context->set_preference('SYSPREF', 'newvalue'); my $newsyspref = C4::Context->preference('SYSPREF');
What is the value of $newsyspref, if C4::Context->preference is memoized ? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6000 --- Comment #9 from Tomás Cohen Arazi <tomascohen@gmail.com> 2012-01-04 16:19:23 UTC --- (In reply to comment #8)
In reply to comment 7
With this code:
my $oldsyspref = C4::Context->preference('SYSPREF'); C4::Context->set_preference('SYSPREF', 'newvalue'); my $newsyspref = C4::Context->preference('SYSPREF');
What is the value of $newsyspref, if C4::Context->preference is memoized ?
It's a good question for HDL. I'd personally add a memcached->remove('SYSPREF') in the set_preference routine. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6000 --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> 2012-01-04 16:22:25 UTC --- (In reply to comment #8) Please read comment #6 as I proposed doing it other way, this time I just rebased against origin/master + 6193 (to be signed off patch). I'm willing to discuss how to implement this on IRC. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6000 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion Blocks| |6193 --- Comment #11 from Paul Poulain <paul.poulain@biblibre.com> 2012-02-03 10:03:15 UTC --- Setting "in discussion", as other caching-related bugs -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6000 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Patch doesn't apply --- Comment #12 from Paul Poulain <paul.poulain@biblibre.com> 2012-02-21 12:26:54 UTC --- This patch does not apply now that bug 6193 has been applied. And I think this entry should be dropped in favour of some more granular entries. Marking "failed QA", and I suggest we "abandon" this one -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6000 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org