https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22867 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22867 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 89473 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89473&action=edit Bug 22867: UniqueItemFields preference value should be pipe-delimited This patch updates the UniqueItemFields system preference so that it contains pipe-delimited data instead of space-delimited data. This makes it consistent with other system preferences which contain lists of database column names, and enables the selection process provided by Bug 22844. This patch includes a database update to convert space-delimited values in UniqueItemFields to pipe-delimited. To test you should have two or more space-delimited items table columns saved in the UniqueItemFields system preference. Apply the patch and run the database update. - Go to Administration -> System preferences -> Acquisitions and confirm that the value of UniqueItemFields is now pipe-delimited. - Set the AcqCreateItem system preference to "placing an order." - Go to Acquisitions -> Vendor -> Basket -> Add to basket -> From a new (empty) record. - Fill out the item add form, including those fields specified in UniqueItemFields. - Click the "Add multiple items" button and specify one or more items. - Click "Add" and verify that in the table of items added, the fields specified in UniqueItemFields were not duplicated. - Edit one or more of those items and add duplicate values to one or more of the fields specified in UniqueItemFields. - Click "Save" and confirm that you are presented with an error highlighting the duplicated data. - Correct the data to remove the duplicates and click "Save" again. It should save correctly. - Set the AcqCreateItem system preference to "receiving an order." - Repeat the test above during the process of receiving an order. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22867 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89473|0 |1 is obsolete| | --- Comment #2 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 89486 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89486&action=edit Bug 22867: UniqueItemFields preference value should be pipe-delimited This patch updates the UniqueItemFields system preference so that it contains pipe-delimited data instead of space-delimited data. This makes it consistent with other system preferences which contain lists of database column names, and enables the selection process provided by Bug 22844. This patch includes a database update to convert space-delimited values in UniqueItemFields to pipe-delimited. To test you should have two or more space-delimited items table columns saved in the UniqueItemFields system preference. Apply the patch and run the database update. - Go to Administration -> System preferences -> Acquisitions and confirm that the value of UniqueItemFields is now pipe-delimited. - Set the AcqCreateItem system preference to "placing an order." - Go to Acquisitions -> Vendor -> Basket -> Add to basket -> From a new (empty) record. - Fill out the item add form, including those fields specified in UniqueItemFields. - Click the "Add multiple items" button and specify one or more items. - Click "Add" and verify that in the table of items added, the fields specified in UniqueItemFields were not duplicated. - Edit one or more of those items and add duplicate values to one or more of the fields specified in UniqueItemFields. - Click "Save" and confirm that you are presented with an error highlighting the duplicated data. - Correct the data to remove the duplicates and click "Save" again. It should save correctly. - Set the AcqCreateItem system preference to "receiving an order." - Repeat the test above during the process of receiving an order. Signed-off-by: Liz Rea <wizzyrea@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22867 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22867 --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 89533 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89533&action=edit Bug 22867: (QA follow-up) Build items.json for UniqueItemFields Adding items.json, built from latest kohastructure.sql. Control UniqueItemFields with this source file. And add StatisticsFields. Test plan: Go to Preferences, play with UniqueItemFields. Adjust StatisticsFields and look at patron record, statistics tab. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22867 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Keywords| |rel_19_05_candidate -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22867 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 89659 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89659&action=edit Bug 22867: Update the syspref's description in sysprefs.sql -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22867 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_19_05_candidate | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22867 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22867 --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I have reverted the QA follow-up and copied it across into bug 22844 and reversed the dependencies. It seemed pertinent to get this consistency fix in place as it had already passed QA. -- You are receiving this mail because: You are watching all bug changes.