[Bug 10026] New: cart not showing location anymore
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10026 Bug ID: 10026 Summary: cart not showing location anymore Classification: Unclassified Change sponsored?: --- Product: Koha Version: 3.10 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: nengard@gmail.com In 3.8 Koha's cart used to show the shelving location, but in 3.10 that has been replaced with branch. Branch should have been added to the cart alongside the location and shouldn't have replaced the location. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10026 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.10 |master --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Caused I think by the patch for Bug 7570. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10026 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|cart not showing location |OPAC cart not showing |anymore |location anymore -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10026 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10026 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10026 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 17350 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17350&action=edit Bug 10026 - OPAC cart not showing location anymore When Bug 7570 added availability information to the cart it switched which subroutine was used to get item information, and thus changed how the information was being returned. This patch makes accommodations for this change by adding processing of item location information to the script in a way that will match the existing template variables. To test, add items to the cart in the OPAC some of which include shelving location information. When you view the cart you should see the shelving location displayed. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10026 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10026 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10026 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17350|0 |1 is obsolete| | --- Comment #3 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 17353 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17353&action=edit Bug 10026 - OPAC cart not showing location anymore When Bug 7570 added availability information to the cart it switched which subroutine was used to get item information, and thus changed how the information was being returned. This patch makes accommodations for this change by adding processing of item location information to the script in a way that will match the existing template variables. To test, add items to the cart in the OPAC some of which include shelving location information. When you view the cart you should see the shelving location displayed. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10026 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart@biblibre.co | |m Patch complexity|--- |Trivial patch QA Contact| |jonathan.druart@biblibre.co | |m --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA comment: Small patch, works as expected. Reintroduce the shelving location information on the opac basket page. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10026 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17353|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 17608 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17608&action=edit Bug 10026 - OPAC cart not showing location anymore When Bug 7570 added availability information to the cart it switched which subroutine was used to get item information, and thus changed how the information was being returned. This patch makes accommodations for this change by adding processing of item location information to the script in a way that will match the existing template variables. To test, add items to the cart in the OPAC some of which include shelving location information. When you view the cart you should see the shelving location displayed. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10026 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master and 3.12.x. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10026 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #7 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.10.x will be in 3.10.6 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org