[Bug 16000] New: Duplicate a report from the New Reports button
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16000 Bug ID: 16000 Summary: Duplicate a report from the New Reports button Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: gmcharlt@gmail.com Reporter: cbrannon@cdalibrary.org QA Contact: testopia@bugs.koha-community.org It would make sense to have a "Duplicate" options in guided_reports.pl on the New Report button outside of the "Use saved" phase of the page. Christopher -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16000 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master Assignee|gmcharlt@gmail.com |oleonard@myacpl.org Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16000 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16000 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 48785 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48785&action=edit Bug 16000 - Duplicate a report from the New Reports button This patch creates a combined edit/duplicate/delete toolbar menu option similar to the one on the bibliographic detail page. Also added is the "Schedule" link which was previously only available from the main list of saved reports. Also added is some deletion confirmation JavaScript for deletions initiated from the toolbar. To test, apply the patch and go to Reports -> Saved reports. - Click "Show" in the menu for any saved report. The toolbar which appears on this page should show the new menu items. - Confirm the behavior of all the buttons. - As you check the behavior of the button actions, check that the toolbar is shown and hidden appropriately for each action. - Confirm that the toolbar is correctly shown or hidden when building a guided report. - Confirm that the "Schedule" button is shown or hidden according to the logged-in user's "schedule_tasks" permission. - Confirm that clicking the "Delete" menu option triggers a JS confirmation. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16000 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16000 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48785|0 |1 is obsolete| | --- Comment #2 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 48829 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48829&action=edit Bug 16000 - Duplicate a report from the New Reports button This patch creates a combined edit/duplicate/delete toolbar menu option similar to the one on the bibliographic detail page. Also added is the "Schedule" link which was previously only available from the main list of saved reports. Also added is some deletion confirmation JavaScript for deletions initiated from the toolbar. To test, apply the patch and go to Reports -> Saved reports. - Click "Show" in the menu for any saved report. The toolbar which appears on this page should show the new menu items. - Confirm the behavior of all the buttons. - As you check the behavior of the button actions, check that the toolbar is shown and hidden appropriately for each action. - Confirm that the toolbar is correctly shown or hidden when building a guided report. - Confirm that the "Schedule" button is shown or hidden according to the logged-in user's "schedule_tasks" permission. - Confirm that clicking the "Delete" menu option triggers a JS confirmation. Signed-off-by: Nicole C Engard <nengard@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16000 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #3 from Christopher Brannon <cbrannon@cdalibrary.org> --- While the menu works, it doesn't deliver. Duplicate just puts me in a new report, not a duplicate. The menu could also be visible when editing. I don't think that would pose any issues. Do you? The other menu items appear to work as expected. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16000 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Christopher Brannon from comment #3)
While the menu works, it doesn't deliver. Duplicate just puts me in a new report, not a duplicate.
I do not find this to be the case. Have you tried it with more than one report?
The menu could also be visible when editing. I don't think that would pose any issues. Do you?
This is something which I describe in my latest update to the interface patterns page on the wiki: "In this view the toolbar is not displayed, because the user is expected to either submit a completed form or choose the 'Cancel' link to abort the process of creating a new entry." https://wiki.koha-community.org/wiki/Interface_patterns#The_.27New.27_entry_... However, the option of duplicating something might be relevant during an edit process. I wonder if we should have a "Save as new report" option or something like that? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16000 --- Comment #5 from Christopher Brannon <cbrannon@cdalibrary.org> --- (In reply to Owen Leonard from comment #4)
(In reply to Christopher Brannon from comment #3)
While the menu works, it doesn't deliver. Duplicate just puts me in a new report, not a duplicate.
I do not find this to be the case. Have you tried it with more than one report?
Yes. You can see this in action here: http://screencast.com/t/TS06SJOhpyY
The menu could also be visible when editing. I don't think that would pose any issues. Do you?
This is something which I describe in my latest update to the interface patterns page on the wiki:
"In this view the toolbar is not displayed, because the user is expected to either submit a completed form or choose the 'Cancel' link to abort the process of creating a new entry."
https://wiki.koha-community.org/wiki/Interface_patterns#The_.27New. 27_entry_form
However, the option of duplicating something might be relevant during an edit process. I wonder if we should have a "Save as new report" option or something like that?
I would suggest a secondary Update button, such as "Update and Duplicate", since we don't use the term Save on the screen. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16000 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Christopher Brannon from comment #5)
I do not find this to be the case. Have you tried it with more than one report?
Yes. You can see this in action here: http://screencast.com/t/TS06SJOhpyY
I still can't reproduce this problem. Can you please post the SQL of a report which is showing the problem? Does the "Duplicate" option work from the "Actions" menu on the list of saved reports?
I would suggest a secondary Update button, such as "Update and Duplicate", since we don't use the term Save on the screen.
I think that should be its own enhancement request. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16000 --- Comment #7 from Christopher Brannon <cbrannon@cdalibrary.org> --- (In reply to Owen Leonard from comment #6)
(In reply to Christopher Brannon from comment #5)
I do not find this to be the case. Have you tried it with more than one report?
Yes. You can see this in action here: http://screencast.com/t/TS06SJOhpyY
I still can't reproduce this problem. Can you please post the SQL of a report which is showing the problem? Does the "Duplicate" option work from the "Actions" menu on the list of saved reports?
The screencast I posted demonstrates me showing the original "Duplicate" working from the list of saved reports. It also shows the SQL report I used. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16000 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #8 from Christopher Brannon <cbrannon@cdalibrary.org> --- I have tested again and it is working now. This must be another case of not clearing the cache. I will go ahead and sign off on this. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16000 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sandboxes@biblibre.com Status|Needs Signoff |Signed Off --- Comment #9 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Patch tested with a sandbox, by Christopher Brannon <cbrannon@cdalibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16000 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48829|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16000 --- Comment #10 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 49229 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49229&action=edit Bug 16000 - Duplicate a report from the New Reports button This patch creates a combined edit/duplicate/delete toolbar menu option similar to the one on the bibliographic detail page. Also added is the "Schedule" link which was previously only available from the main list of saved reports. Also added is some deletion confirmation JavaScript for deletions initiated from the toolbar. To test, apply the patch and go to Reports -> Saved reports. - Click "Show" in the menu for any saved report. The toolbar which appears on this page should show the new menu items. - Confirm the behavior of all the buttons. - As you check the behavior of the button actions, check that the toolbar is shown and hidden appropriately for each action. - Confirm that the toolbar is correctly shown or hidden when building a guided report. - Confirm that the "Schedule" button is shown or hidden according to the logged-in user's "schedule_tasks" permission. - Confirm that clicking the "Delete" menu option triggers a JS confirmation. Signed-off-by: Nicole C Engard <nengard@bywatersolutions.com> Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16000 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Status|Signed Off |Failed QA --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Christopher Brannon from comment #8)
I have tested again and it is working now. This must be another case of not clearing the cache. I will go ahead and sign off on this.
No it does not :) Owen, to replicate: /reports/guided_reports.pl?phase=Use saved Actions > edit Update SQL Edit > Duplicate Will open an empty form -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16000 --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 49247 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49247&action=edit Bug 16000: Simplify JS code -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16000 --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #12)
Created attachment 49247 [details] [review] Bug 16000: Simplify JS code
Owen, feel free to embed it into your patch if it's easier for you (i.e. I don't care about the authorship). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16000 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16000 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49229|0 |1 is obsolete| | --- Comment #14 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 49276 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49276&action=edit Bug 16000 [Revised] Duplicate a report from the New Reports button This patch creates a combined edit/duplicate/delete toolbar menu option similar to the one on the bibliographic detail page. Also added is the "Schedule" link which was previously only available from the main list of saved reports. Also added is some deletion confirmation JavaScript for deletions initiated from the toolbar. To test, apply the patch and go to Reports -> Saved reports. - Click "Show" in the menu for any saved report. The toolbar which appears on this page should show the new menu items. - Confirm the behavior of all the buttons. - As you check the behavior of the button actions, check that the toolbar is shown and hidden appropriately for each action. - Confirm that the toolbar is correctly shown or hidden when building a guided report. - Confirm that the "Schedule" button is shown or hidden according to the logged-in user's "schedule_tasks" permission. - Confirm that clicking the "Delete" menu option triggers a JS confirmation. Revision passes the sql data to the template in the case of the "save_successful" screen. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16000 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49247|0 |1 is obsolete| | --- Comment #15 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 49277 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49277&action=edit [SIGNED-OFF] Bug 16000: Simplify JS code Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16000 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16000 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #16 from Marc Véron <veron@veron.ch> --- Sorry, does not apply: Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/includes/reports-toolbar.inc CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/includes/reports-toolbar.inc Failed to merge in the changes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16000 --- Comment #17 from Christopher Brannon <cbrannon@cdalibrary.org> --- I was having trouble getting it to load in a sandbox yesterday. Sandboxes are not sending me e-mails, so had no clue what was happening. Now we know. Christopher -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16000 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16000 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49276|0 |1 is obsolete| | --- Comment #18 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 49541 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49541&action=edit Bug 16000 [Revised] Duplicate a report from the New Reports button This patch creates a combined edit/duplicate/delete toolbar menu option similar to the one on the bibliographic detail page. Also added is the "Schedule" link which was previously only available from the main list of saved reports. Also added is some deletion confirmation JavaScript for deletions initiated from the toolbar. To test, apply the patch and go to Reports -> Saved reports. - Click "Show" in the menu for any saved report. The toolbar which appears on this page should show the new menu items. - Confirm the behavior of all the buttons. - As you check the behavior of the button actions, check that the toolbar is shown and hidden appropriately for each action. - Confirm that the toolbar is correctly shown or hidden when building a guided report. - Confirm that the "Schedule" button is shown or hidden according to the logged-in user's "schedule_tasks" permission. - Confirm that clicking the "Delete" menu option triggers a JS confirmation. Revision passes the sql data to the template in the case of the "save_successful" screen. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16000 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49277|0 |1 is obsolete| | --- Comment #19 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 49542 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49542&action=edit Bug 16000: Simplify JS code Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16000 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #20 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Patch tested with a sandbox, by Christopher Brannon <cbrannon@cdalibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16000 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49541|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16000 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49542|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16000 --- Comment #21 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 49543 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49543&action=edit Bug 16000 [Revised] Duplicate a report from the New Reports button This patch creates a combined edit/duplicate/delete toolbar menu option similar to the one on the bibliographic detail page. Also added is the "Schedule" link which was previously only available from the main list of saved reports. Also added is some deletion confirmation JavaScript for deletions initiated from the toolbar. To test, apply the patch and go to Reports -> Saved reports. - Click "Show" in the menu for any saved report. The toolbar which appears on this page should show the new menu items. - Confirm the behavior of all the buttons. - As you check the behavior of the button actions, check that the toolbar is shown and hidden appropriately for each action. - Confirm that the toolbar is correctly shown or hidden when building a guided report. - Confirm that the "Schedule" button is shown or hidden according to the logged-in user's "schedule_tasks" permission. - Confirm that clicking the "Delete" menu option triggers a JS confirmation. Revision passes the sql data to the template in the case of the "save_successful" screen. Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16000 --- Comment #22 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 49544 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49544&action=edit Bug 16000: Simplify JS code Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16000 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |katrin.fischer@bsz-bw.de --- Comment #23 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Showing an existing export, the schedule button appears twice now. (cgi-bin/koha/reports/guided_reports.pl?reports=1&phase=Show%20SQL) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16000 --- Comment #24 from Christopher Brannon <cbrannon@cdalibrary.org> --- (In reply to Katrin Fischer from comment #23)
Showing an existing export, the schedule button appears twice now. (cgi-bin/koha/reports/guided_reports.pl?reports=1&phase=Show%20SQL)
Yep. I missed that one. :/ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16000 --- Comment #25 from Christopher Brannon <cbrannon@cdalibrary.org> --- Schedule button duplicates after update or save as well. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16000 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED Resolution|--- |DUPLICATE --- Comment #26 from Owen Leonard <oleonard@myacpl.org> --- Rather than resolve the merge errors with Bug 15421, I resolve that my patch is made obsolete by Bug 15421. *** This bug has been marked as a duplicate of bug 15421 *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org