[Bug 23181] New: Unable to use payment library in ACCOUNT_PAYMENT or ACCOUNT_WRITEOFF notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23181 Bug ID: 23181 Summary: Unable to use payment library in ACCOUNT_PAYMENT or ACCOUNT_WRITEOFF notices Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Target Milestone: --- Do to a simple semantic typo, the branches key will always be null for the tables key of the parameters for GetPreparedLetter. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23181 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23181 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23181 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 90908 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90908&action=edit Bug 23181 - Unable to use payment library in ACCOUNT_PAYMENT or ACCOUNT_WRITEOFF notices Do to a simple semantic typo, the branches key will always be null for the tables key of the parameters for GetPreparedLetter. Test Plan: 1) Attempt to use [% branch.branchame %] in the ACCOUNT_PAYMENT notice 2) Note it produces no output 3) Apply this patch 4) Make another payment 5) You should now see the branche's name! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23181 Lisette Scheer <lisetteslatah@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23181 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23181 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90908|0 |1 is obsolete| | --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 91520 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91520&action=edit Bug 23181 - Unable to use payment library in ACCOUNT_PAYMENT or ACCOUNT_WRITEOFF notices Do to a simple semantic typo, the branches key will always be null for the tables key of the parameters for GetPreparedLetter. Test Plan: 0) Activate UseEmailReceipts 1) Attempt to use [% branch.branchname %] in the ACCOUNT_PAYMENT notice 2) Note it produces no output 3) Apply this patch 4) Make another payment 5) You should now see the branche's name! Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Also requires UseEmailReceipts to be activated. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23181 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |martin.renvoize@ptfs-europe | |.com --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Looks good, but it's a change to a Koha:: module.. can we get a corresponding unit test update to prevent future regression pretty please. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23181 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Version|unspecified |master --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- A bit sad to see this one blocked by the missing test - it means you can't print your library's address into the new notices and have to hardcode it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23181 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23181 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 94967 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94967&action=edit Bug 23181: Extend unit tests Run t/db_dependent/Accounts.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23181 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I've given the unit test a go. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23181 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23181 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23181 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91520|0 |1 is obsolete| | Attachment #94967|0 |1 is obsolete| | --- Comment #7 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 94980 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94980&action=edit Bug 23181: Extend unit tests Run t/db_dependent/Accounts.t Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23181 --- Comment #8 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 94981 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94981&action=edit Bug 23181: Unable to use payment library in ACCOUNT_PAYMENT or ACCOUNT_WRITEOFF notices Do to a simple semantic typo, the branches key will always be null for the tables key of the parameters for GetPreparedLetter. Test Plan: 0) Activate UseEmailReceipts 1) Attempt to use [% branch.branchname %] in the ACCOUNT_PAYMENT notice 2) Note it produces no output 3) Apply this patch 4) Make another payment 5) You should now see the branche's name! Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Also requires UseEmailReceipts to be activated. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23181 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |josef.moravec@gmail.com |y.org | CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23181 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thx Josef! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23181 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23181 --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23181 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23805 CC| |fridolin.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23181 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|19.11.00 |19.11.00,19.05.05 released in| | Status|Pushed to master |Pushed to stable --- Comment #11 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 19.05.x for 19.05.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23181 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 95944 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95944&action=edit Bug 23181: [18.11] Extend unit tests Run t/db_dependent/Accounts.t Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23181 --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Had to change the tests slightly to make them pass on 18.11 - attaching patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23181 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hayleymapley@catalyst.net.n | |z --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Hayley, could you consider this for 18.11 please? I attached a patch that worked for me for the tests (so second and third should work together for 18.11) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23181 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|19.11.00,19.05.05 |19.11.00,19.05.05, 18.11.13 released in| | --- Comment #15 from Hayley Mapley <hayleymapley@catalyst.net.nz> --- Backported to 18.11.x for 18.1.13 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23181 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Pushed to oldoldstable -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org