https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31717 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31717 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #2 from David Nind <david@davidnind.com> --- I had a go at testing this, but couldn't get it to work. I'm not sure what I'm doing wrong... I'm sure it is something basic! What I did: 1. Before applying the patch, I checked the current behaviour: . Added unimarc_field_010.pl to 010$a . Created a new record . Entered 9782070612369 in 010$a . Checked 210$c - automatically populated with Gallimard 2. After applying the patch (and flush_memcached, restart_all, fresh browser): . Created a new record . Entered 9782070612369 in 010$a . Checked 210$c - still automatically populated with Gallimard . Checked 214$c - not automatically populated with Gallimard -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31717 --- Comment #4 from Fridolin Somers <fridolin.somers@biblibre.com> --- (In reply to Amaury GAU from comment #3)

I'm not even there at testing.

I did :

1) Choose an existing record with an ISBN and a published in biblioitems.publishercode. I used2211015344 and Ecole des loisirs

2)I don't see the value builder unimarc_field_010.pl on 010$a.

I'm not sure about the process here.

Hi, You need to test on a UNIMARC database. Configure framework on 010$a if needed. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31717 --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- Ah it is a Javascript change, try refreshing cache after applying patch : Ctrl + F5 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31717 --- Comment #7 from David Nind <david@davidnind.com> --- Good news, the patch still applies! Not so good news, as in comment #2 and comment #5 it still doesn't work as expected. After applying the patch, everything was restarted (flush_memcached) and a fresh browser (with cache cleared) was used. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31717 --- Comment #8 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 190703 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190703&action=edit Bug 31717: Value builder unimarc_field_010.pl also use 214$c Value builder unimarc_field_010.pl tries to find publisher from ISBN in order to fill 210$c. Since there is now 214$c for publisher this value builder should be adapted. Test plan : 1) Choose an existing record with an ISBN and a published in biblioitems.publishercode, For example 9782070612369 and Gallimard 2) Use value builder unimarc_field_010.pl on 010$a 3) Create a new record 4) Enter 9782070612369 in 010$a 5) Click on value builder icon on this subfield 6) Check you see 'Gallimard' in 214$c -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31717 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190703|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31717 --- Comment #11 from Fridolin Somers <fridolin.somers@biblibre.com> --- I've changed the patch, it was stopping at first input. Please retest :D -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31717 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190705|0 |1 is obsolete| | --- Comment #12 from David Nind <david@davidnind.com> --- Created attachment 190707 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190707&action=edit Bug 31717: Value builder unimarc_field_010.pl also use 214$c Value builder unimarc_field_010.pl tries to find publisher from ISBN in order to fill 210$c. Since there is now 214$c for publisher this value builder should be adapted. Test plan : 1) Choose an existing record with an ISBN and a published in biblioitems.publishercode, For example 9782070612369 and Gallimard 2) Use value builder unimarc_field_010.pl on 010$a 3) Create a new record 4) Enter 9782070612369 in 010$a 5) Click on value builder icon on this subfield 6) Check you see 'Gallimard' in 214$c Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31717 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #13 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Hmm. This is a tiny change but the plugin itself seems to ask for more attention? It is still in the old style with plugin_javascript instead of builder/launcher. No blocker btw. It seems that it actually does not need a launcher since it only needs an ajax call for the publishercode. But it does to by calling the launcher from the builder, which is a bit odd. (Too much overhead?) No blocker too. The function operates on the Blur event; do we really need to fetch the publishercode (again) if the field did not change? Or should we just use Change? Why write the same code to two fields now? I did not check the UNIMARC specs, but is it really meant to duplicate info here? Or is it meant to use only one of the two? Changing status for feedback. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31717 --- Comment #14 from Fridolin Somers <fridolin.somers@biblibre.com> ---

Why write the same code to two fields now? I did not check the UNIMARC specs, but is it really meant to duplicate info here? Or is it meant to use only one of the two?

It is new from bibliographic transition. 214 is more complex that 210, it meant to use only one of the two. We can find the info here : https://www.transition-bibliographique.fr/unimarc/manuel-unimarc-format-bibl... For the other points, we may create a bug report to rewrite this value builder. Maybe we will use API here at some point. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31717 --- Comment #16 from Fridolin Somers <fridolin.somers@biblibre.com> --- Ah indeed in case there are both 210 and 214, the 214 is more important. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31717 --- Comment #17 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 194494 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194494&action=edit Bug 31717: Value builder unimarc_field_010.pl also use 214$c Value builder unimarc_field_010.pl tries to find publisher from ISBN in order to fill 210$c. Since there is now 214$c for publisher this value builder should be adapted. Test plan : 1) Choose an existing record with an ISBN and a published in biblioitems.publishercode, For example 9782070612369 and Gallimard 2) Use value builder unimarc_field_010.pl on 010$a 3) Create a new record 4) Enter 9782070612369 in 010$a 5) Click on value builder icon on this subfield 6) Check you see 'Gallimard' in 214$c Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31717 --- Comment #18 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 194495 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194495&action=edit Bug 31717: Value builder unimarc_field_010.pl also use 214$c Value builder unimarc_field_010.pl tries to find publisher from ISBN in order to fill 210$c. Since there is now 214$c for publisher this value builder should be adapted. 214 is more important than 210 so if there are both, only 214 will be filled. Test plan : 1) Choose an existing record with an ISBN and a published in biblioitems.publishercode, For example 9782070612369 and Gallimard 2) Use value builder unimarc_field_010.pl on 010$a 3) Create a new record 4) Enter 9782070612369 in 010$a 5) Click on value builder icon on this subfield 6) Check you see 'Gallimard' in 214$c Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31717 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31717 --- Comment #20 from David Nind <david@davidnind.com> --- Created attachment 194546 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194546&action=edit Bug 31717: Value builder unimarc_field_010.pl also use 214$c Value builder unimarc_field_010.pl tries to find publisher from ISBN in order to fill 210$c. Since there is now 214$c for publisher this value builder should be adapted. 214 is more important than 210 so if there are both, only 214 will be filled. Test plan : 1) Choose an existing record with an ISBN and a published in biblioitems.publishercode, For example 9782070612369 and Gallimard 2) Use value builder unimarc_field_010.pl on 010$a 3) Create a new record 4) Enter 9782070612369 in 010$a 5) Click on value builder icon on this subfield 6) Check you see 'Gallimard' in 214$c Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31717 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #22 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Fridolin Somers from comment #16)

Ah indeed in case there are both 210 and 214, the 214 is more important.

Nice (In reply to Marcel de Rooy from comment #13)

The function operates on the Blur event; do we really need to fetch the publishercode (again) if the field did not change? Or should we just use Change?

What about this remark? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31717 --- Comment #24 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Fridolin Somers from comment #23)

...

What about this remark?

Good point. I'd say this report focuses on 214 field missing, which is a bug. Other changes may be proposed in another report.

Fair enough. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31717 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194546|0 |1 is obsolete| | --- Comment #25 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 195262 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195262&action=edit Bug 31717: Value builder unimarc_field_010.pl also use 214$c Value builder unimarc_field_010.pl tries to find publisher from ISBN in order to fill 210$c. Since there is now 214$c for publisher this value builder should be adapted. 214 is more important than 210 so if there are both, only 214 will be filled. Test plan : 1) Choose an existing record with an ISBN and a published in biblioitems.publishercode, For example 9782070612369 and Gallimard 2) Use value builder unimarc_field_010.pl on 010$a 3) Create a new record 4) Enter 9782070612369 in 010$a 5) Click on value builder icon on this subfield 6) Check you see 'Gallimard' in 214$c Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31717 --- Comment #26 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Thanks for all the hard work! Pushed to main for the next 26.05.00 release as RM Assistant -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31717 --- Comment #27 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Thanks all, pushed to 25.11.x -- You are receiving this mail because: You are watching all bug changes.