[Bug 19208] New: Pay select option doesn't pay the selected fine
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19208 Bug ID: 19208 Summary: Pay select option doesn't pay the selected fine Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: andreas.hedstrom.mace@sub.su.se QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Created attachment 66616 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66616&action=edit Fines total amount The "Pay selected" option on the Fines tab in the borrower account page doesn't work as intended. The problem has been noted on both 16.05.00 and on master, but behaves a bit differently. On 16.05 the amount paid will be drawn from the total amount rather than the selected fine, while on master the fine on top of the list gets the amount deducted, even if another fine is choosen from the list. To recreate: 1) Create two or three fines, using the Create manual invoice function. 2) Choose one of the fines (not the one on the top) and click Pay selected 3) Pay a partial amount 4) Go back to the Pay fines tab an notice that the fine you selected has not changed. Instead, either the top fine or the total (see attachment) has ben affected. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19208 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19208 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 66618 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66618&action=edit Bug 19208 [Master] - Pay select option doesn't pay the selected fine The "Pay selected" option on the Fines tab in the borrower account page doesn't work as intended. The fine on top of the list gets the amount deducted, even if another fine is choosen from the list. Test Plan: 1) Create two or three fines, using the Create manual invoice function. 2) Choose one of the fines (not the one on the top) and click Pay selected 3) Pay a partial amount 4) Go back to the Pay fines tab an notice that the fine you selected has not changed. Instead, either the top fine or the total (see attachment) has ben affected. 5) Apply this patch 6) Repeat steps 1-3 7) Note the correct fine is paid -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19208 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | CC| |kyle@bywatersolutions.com Severity|enhancement |major -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19208 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Depends on| |19205 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19205 [Bug 19205] Pay selected fine generates 500 error -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19208 Andreas Hedström Mace <andreas.hedstrom.mace@sub.su.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19208 Andreas Hedström Mace <andreas.hedstrom.mace@sub.su.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66618|0 |1 is obsolete| | --- Comment #2 from Andreas Hedström Mace <andreas.hedstrom.mace@sub.su.se> --- Created attachment 66653 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66653&action=edit Bug 19208 [Master] - Pay select option doesn't pay the selected fine The "Pay selected" option on the Fines tab in the borrower account page doesn't work as intended. The fine on top of the list gets the amount deducted, even if another fine is choosen from the list. Test Plan: 1) Create two or three fines, using the Create manual invoice function. 2) Choose one of the fines (not the one on the top) and click Pay selected 3) Pay a partial amount 4) Go back to the Pay fines tab an notice that the fine you selected has not changed. Instead, either the top fine or the total (see attachment) has ben affected. 5) Apply this patch 6) Repeat steps 1-3 7) Note the correct fine is paid Signed-off-by: Andreas Hedström Mace <andreas.hedstrom.mace@sub.su.se> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19208 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66653|0 |1 is obsolete| | --- Comment #3 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 66690 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66690&action=edit Bug 19208 [Master] - Pay select option doesn't pay the selected fine The "Pay selected" option on the Fines tab in the borrower account page doesn't work as intended. The fine on top of the list gets the amount deducted, even if another fine is choosen from the list. Test Plan: 1) Create two or three fines, using the Create manual invoice function. 2) Choose one of the fines (not the one on the top) and click Pay selected 3) Pay a partial amount 4) Go back to the Pay fines tab an notice that the fine you selected has not changed. Instead, either the top fine or the total (see attachment) has ben affected. 5) Apply this patch 6) Repeat steps 1-3 7) Note the correct fine is paid Signed-off-by: Andreas Hedström Mace <andreas.hedstrom.mace@sub.su.se> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19208 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19208 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19208 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to Master |Pushed to Stable --- Comment #5 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.05.x, will be in 17.05.04. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19208 Bug 19208 depends on bug 19205, which changed state. Bug 19205 Summary: Pay selected fine generates 500 error https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19205 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org