[Bug 33018] New: debian package tidy-up
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33018 Bug ID: 33018 Summary: debian package tidy-up Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Packaging Assignee: koha-bugs@lists.koha-community.org Reporter: mtj@kohaaloha.com QA Contact: testopia@bugs.koha-community.org CC: mtj@kohaaloha.com this bug aims to track a tidy-up of debian package files -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33018 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33018 --- Comment #1 from Mason James <mtj@kohaaloha.com> --- Created attachment 146996 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146996&action=edit Bug 33018: debian package tidy-up this patch removes unneeded package dependencies to test: - apply patch - build and install koha-common package, note success -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33018 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |mtj@kohaaloha.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33018 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33018 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus@libriotech.no --- Comment #2 from Magnus Enger <magnus@libriotech.no> --- It looks like these modules are still in use in Koha? $ grep -rn "LWP::Protocol" * cpanfile:62:requires 'LWP::Protocol::https', '5.836'; debian/list-deps:30: 'LWP::Protocol::https' => 'liblwp-protocol-https-perl | libwww-perl (<<6.02), libio-socket-ssl-perl', $ grep -rn "IO::Socket::IP" * debian/list-deps:32: 'IO::Socket::IP' => 'perl-modules (>= 5.20.0) | libio-socket-ip-perl', misc/bin/connexion_import_daemon.pl:91:# use IO::Socket::IP; $ grep -rn "CPAN::Meta" * cpanfile:15:requires 'CPAN::Meta', '2.150006'; debian/list-deps:33: 'CPAN::Meta' => 'libcpan-meta-perl (>= 2.150010) | perl-modules-5.28 | perl-modules-5.30 | perl-modules (>= 5.20.2)', So the point is that we had to provide them in the Koha Debian repo, but now we don't have to do that anymore, and we can remove them from "special treatment"? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33018 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33018 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146996|0 |1 is obsolete| | --- Comment #3 from Magnus Enger <magnus@libriotech.no> --- Created attachment 148910 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148910&action=edit Bug 33018: debian package tidy-up this patch removes unneeded package dependencies to test: - apply patch - build and install koha-common package, note success Signed-off-by: Magnus Enger <magnus@libriotech.no> Not tested, I trust Mason to the right thing. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33018 --- Comment #4 from Magnus Enger <magnus@libriotech.no> --- Please reset to NSO if thorough testing is considered necessary. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33018 --- Comment #5 from David Cook <dcook@prosentient.com.au> --- (In reply to Magnus Enger from comment #2)
So the point is that we had to provide them in the Koha Debian repo, but now we don't have to do that anymore, and we can remove them from "special treatment"?
I think this question should be answered before this issue is progressed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33018 --- Comment #6 from Mason James <mtj@kohaaloha.com> --- Created attachment 150288 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150288&action=edit Bug 33018: debian package tidy-up (2) remove unrequired module -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33018 --- Comment #7 from Mason James <mtj@kohaaloha.com> --- (In reply to Magnus Enger from comment #2)
It looks like these modules are still in use in Koha?
$ grep -rn "LWP::Protocol" * cpanfile:62:requires 'LWP::Protocol::https', '5.836'; debian/list-deps:30: 'LWP::Protocol::https' => 'liblwp-protocol-https-perl | libwww-perl (<<6.02), libio-socket-ssl-perl',
this pkg is required, but no longer needs to be explicitly listed in deb/list-deps
$ grep -rn "IO::Socket::IP" * debian/list-deps:32: 'IO::Socket::IP' => 'perl-modules (>= 5.20.0) | libio-socket-ip-perl', misc/bin/connexion_import_daemon.pl:91:# use IO::Socket::IP;
this pkg is not required, as its now provided by perl-modules-* pkg
$ grep -rn "CPAN::Meta" * cpanfile:15:requires 'CPAN::Meta', '2.150006'; debian/list-deps:33: 'CPAN::Meta' => 'libcpan-meta-perl (>= 2.150010) | perl-modules-5.28 | perl-modules-5.30 | perl-modules (>= 5.20.2)',
this pkg is not required, as its now provided by perl-modules-* pkg -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33018 --- Comment #8 from Magnus Enger <magnus@libriotech.no> --- Thanks Mason, sounds good! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33018 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #9 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- I would not remove CPAN::Meta from the cpanfile: commit a34d086a24b1e4519f8b31331d4c42b87b8e4a83 Bug 19735: Move Perl deps definitions into a cpanfile Added dependencies: - Module::CPANfile - CPAN::Meta (dependency of Module::CPANfile, but we need a more recent version than the one Module::CPANfile requires) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33018 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion --- Comment #10 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Mason, ping? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33018 --- Comment #11 from Mason James <mtj@kohaaloha.com> --- (In reply to Jonathan Druart from comment #9)
I would not remove CPAN::Meta from the cpanfile:
hi Jonathan, sorry for the late reply sounds good to me, i'll obsolete the patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33018 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150288|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33018 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33018 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am not sure how to QA this one - can someone else take over please? I notice there is still this line in the patch: - 'CPAN::Meta' => 'libcpan-meta-perl (>= 2.150010) | perl-modules-5.28 | perl-modules-5.30 | perl-modules (>= 5.20.2)', -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33018 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl Status|Signed Off |Needs Signoff --- Comment #13 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Magnus Enger from comment #3)
Created attachment 148910 [details] [review] Bug 33018: debian package tidy-up
this patch removes unneeded package dependencies
to test: - apply patch - build and install koha-common package, note success
Signed-off-by: Magnus Enger <magnus@libriotech.no> Not tested, I trust Mason to the right thing.
Sorry, but I am moving back status. Signoff means test. QA is reading too :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33018 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pedro.amorim@ptfs-europe.co | |m --- Comment #14 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Hi, I'd like to help here but I don't think I'm qualified to. What is list-deps used for exactly, why did it need the now removed entries, why are they now being removed and how does list-deps relate to cpanfile. Ignore the questions above if they're irrelevant in moving this bug. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33018 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #15 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Are we still keen to do this Mason? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33018 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |blawlor@clamsnet.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33018 --- Comment #16 from David Cook <dcook@prosentient.com.au> --- Personally, I still don't get why we use debian/update-control, debian/list-deps, and debian/control.in and don't just manage debian/control by hand, but c'est la vie. I've come up with a little test plan. You'll probably find "bash debian/update-control" takes a longish time to run. Test plan: 0. Apply the patch 1. apt-get update 2. apt-get install apt-file 3. apt-file update 4. vi debian/control 5. Find "Package: koha-common" and change "yaz" to "yazzz" 4. bash debian/update-control 5. Review the changes to debian/control using "git diff" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33018 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #17 from David Cook <dcook@prosentient.com.au> --- When reviewing the change... 1. When reviewing, there should be no new reference to libio-socket-ip-perl, since we don't have that in the cpanfile and IO::Socket::IP is already part of perl-base. So that's good. 2. With this patch, libcpan-meta-perl now appears in debian/control without any reference to version number of "perl-modules", and this is potentially a problem... because CPAN::Meta 2.150010 is part of the perl core (via perl-modules-5.XX) since Perl 5.14 (AKA Debian 7 Wheezy). So... if we accidentally installed libcpan-meta-perl it's probably not a big deal, because it's the same version as the core version. One of them would appear first when searching @INC and it shouldn't really matter. But... we really shouldn't be installing a package (that we host on debian.koha-community.org) if we don't need it. 3. "liblwp-protocol-https-perl" appears instead of "liblwp-protocol-https-perl | libwww-perl (<<6.02), libio-socket-ssl-perl," liblwp-protocol-https-perl is in buster, bullseye, bookworm, etc and we don't have it in the debian.koha-community.org repo. I think this is fine. -- So overall... I think the IO::Socket::IP and LWP::Protocol::https changes are good, but not the the CPAN::Meta one. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33018 --- Comment #18 from David Cook <dcook@prosentient.com.au> --- (In reply to David Cook from comment #17)
So overall... I think the IO::Socket::IP and LWP::Protocol::https changes are good, but not the the CPAN::Meta one.
That is to say, at the moment, we don't install libcpan-meta-perl in koha-testing-docker or prod. If we pushed this change, installing Koha would now install libcpan-meta-perl. (In reply to Jonathan Druart from comment #9)
I would not remove CPAN::Meta from the cpanfile:
commit a34d086a24b1e4519f8b31331d4c42b87b8e4a83 Bug 19735: Move Perl deps definitions into a cpanfile
Added dependencies: - Module::CPANfile - CPAN::Meta (dependency of Module::CPANfile, but we need a more recent version than the one Module::CPANfile requires)
Ok let's consider versions... Our oldest supported OS is... maybe Debian 11 (Bullseye) which uses Perl 5.32 or Ubuntu 20.04 which uses Perl 5.30.0. - Currently, we're requiring 2.150010 - CPAN::Meta in 5.14.0 is 2.110440 - CPAN::Meta in 5.26.0 is 2.150010 So we should be good from Perl 5.26.0 onwards. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33018 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150288|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33018 --- Comment #19 from David Cook <dcook@prosentient.com.au> --- Restored Mason's cpanfile patch and re-ran the test plan... libcpan-meta-perl line is removed and liblwp-protocl-https-perl is included without version numbers. Looks good to me. Going to mark as signed off. I suppose additional testing would involve building the package and making sure things using CPAN::Meta and LWP https URLs still works, but I'd be very confident that they would. The only potential problem would be with Koha running on very old OSes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33018 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33018 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148910|0 |1 is obsolete| | --- Comment #20 from David Cook <dcook@prosentient.com.au> --- Created attachment 173848 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173848&action=edit Bug 33018: debian package tidy-up this patch removes unneeded package dependencies to test: - apply patch - build and install koha-common package, note success Signed-off-by: Magnus Enger <magnus@libriotech.no> Not tested, I trust Mason to the right thing. Signed-off-by: David Cook <dcook@prosentient.com.au> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33018 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150288|0 |1 is obsolete| | --- Comment #21 from David Cook <dcook@prosentient.com.au> --- Created attachment 173849 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173849&action=edit Bug 33018: debian package tidy-up (2) remove unrequired module modified: cpanfile Signed-off-by: David Cook <dcook@prosentient.com.au> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33018 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173848|0 |1 is obsolete| | --- Comment #22 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 175341 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175341&action=edit Bug 33018: debian package tidy-up this patch removes unneeded package dependencies to test: - apply patch - build and install koha-common package, note success Signed-off-by: Magnus Enger <magnus@libriotech.no> Not tested, I trust Mason to the right thing. Signed-off-by: David Cook <dcook@prosentient.com.au> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33018 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173849|0 |1 is obsolete| | --- Comment #23 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 175342 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175342&action=edit Bug 33018: debian package tidy-up (2) remove unrequired module modified: cpanfile Signed-off-by: David Cook <dcook@prosentient.com.au> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33018 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33018 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|debian package tidy-up |Debian package tidy-up -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33018 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33018 --- Comment #24 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33018 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Text to go in the| |This removes unneeded release notes| |Debian package | |dependencies. Previously we | |provided them in the Koha | |Debian repository, but we | |no longer need to as they | |are now available in the | |standard repositories. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33018 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.05.00 |25.05.00,24.11.02 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33018 --- Comment #25 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 24.11.x for 24.11.01 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33018 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.05.00,24.11.02 |25.05.00,24.11.02,24.05.08 released in| | CC| |alexbuckley@catalyst.net.nz Status|Pushed to stable |Pushed to oldstable --- Comment #26 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Nice work everyone! Pushed to 24.05.x for 24.05.08 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33018 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #27 from Fridolin Somers <fridolin.somers@biblibre.com> --- I whould prefer not impact 23.11.x for stability. Tell me if this is mandatory -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33018 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Needs documenting CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #28 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11 unless requested -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33018 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED --- Comment #29 from David Nind <david@davidnind.com> --- No changes to the manual required. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org