[Bug 13214] New: Improve performance of acqui/addorderiso2709.pl, stop fetching all import_records needlessly
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13214 Bug ID: 13214 Summary: Improve performance of acqui/addorderiso2709.pl, stop fetching all import_records needlessly Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: olli-antti.kivilahti@jns.fi QA Contact: testopia@bugs.koha-community.org When you have 167 import batches and you try to pick one by going to acqui/addorderiso2709.pl, it takes ~16s to load the page. This is because all import_records are loaded simply to check if an import_batch has recors with the given status. This patch fixes this and cuts the load time to 1.6s -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13214 Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |7180 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13214 Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |olli-antti.kivilahti@jns.fi |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13214 --- Comment #1 from Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> --- Created attachment 33314 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33314&action=edit Bug 13214 - Improve performance of acqui/addorderiso2709.pl, stop fetching all import_records needlessly TEST PLAN: 1. Load 167 staged files to Koha. 2. Try to make an acquisiton from a staged file. 3. Wait 16s for the acqui/addorderiso2709.pl -view to load. AFTER PATCH: 1. Load 167 staged files to Koha. 2. Try to make an acquisiton from a staged file. 3. Wait 1.6s for the acqui/addorderiso2709.pl -view to load. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13214 Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #2 from Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> --- Tested using Jonathan's excellent tutorial about Perl performace profiling! http://wiki.koha-community.org/wiki/Profiling_with_Devel::NYTProf -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13214 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Olli-Antti Kivilahti from comment #2)
Tested using Jonathan's excellent tutorial about Perl performace profiling!
http://wiki.koha-community.org/wiki/Profiling_with_Devel::NYTProf
It's not mine :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13214 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13214 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33314|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 33322 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33322&action=edit Bug 13214 - Improve performance of acqui/addorderiso2709.pl, stop fetching all import_records needlessly TEST PLAN: 1. Load 167 staged files to Koha. 2. Try to make an acquisiton from a staged file. 3. Wait 16s for the acqui/addorderiso2709.pl -view to load. AFTER PATCH: 1. Load 167 staged files to Koha. 2. Try to make an acquisiton from a staged file. 3. Wait 1.6s for the acqui/addorderiso2709.pl -view to load. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13214 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13214 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33322|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 33794 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33794&action=edit [PASSED QA] Bug 13214 - Improve performance of acqui/addorderiso2709.pl, stop fetching all import_records needlessly TEST PLAN: 1. Load 167 staged files to Koha. 2. Try to make an acquisiton from a staged file. 3. Wait 16s for the acqui/addorderiso2709.pl -view to load. AFTER PATCH: 1. Load 167 staged files to Koha. 2. Try to make an acquisiton from a staged file. 3. Wait 1.6s for the acqui/addorderiso2709.pl -view to load. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13214 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13214 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Olli! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org