[Bug 30270] New: Use numeric inputs instead of dropdowns for hold priority
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30270 Bug ID: 30270 Summary: Use numeric inputs instead of dropdowns for hold priority Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Currently we load a dropdown menu with the range of priority optins when listing holds on request.pl For a record with many holds (100+) this dropdown is large, and difficult to use The page size when loading this many dropdowns is also large We can reduce the problem by using numeric inputs and allowing the user to type new numbers, rather than selecting -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30270 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Depends on| |30269 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30269 [Bug 30269] Use objects directly to display holds on request.pl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30270 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 131574 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131574&action=edit Bug 30270: Use numeric inputs for holds priority This patch removes the code to generate dropdowns for holds priority and adjusts it to use numeric inputs This does remove the option to set priority to 'del' and use 'Update holds' button to delete, however, we have a checkbox and 'Cancel selected' which perform the same function as well as a cancel button for each individual hold This patch increases performance of the page by reducing the size of the page To test: 1 - Place many holds on a record 2 - View the holds page and verify functionlity when using: HoldsSplitQueue HoldsSplitQueueNumbering 3 - Apply patch 4 - Confirm dropdowns are gone 5 - Confirm priorities correctly numbered virtually or actually according to HoldsSplitQueueNumbering 6 - Confirm with all values of HoldsSplitQueue 7 - Confirm cancellation works using checkboxes or button 8 - Confirm hold priority buttons work as before -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30270 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30270 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30270 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |andrew@bywatersolutions.com --- Comment #2 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Great start, Nick! Sadly, there was an error when setting HoldsSplitQueue to "pickup library and itemtype." Template process failed: undef error - The method Koha::Hold->object is not covered by tests! Trace begun at /kohadevbox/koha/Koha/Object.pm line 875 Koha::Object::AUTOLOAD('Koha::Hold=HASH(0x55f3aa7bafe0)') called at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt line 1052 eval {...} at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt line 1052 eval {...} at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt line 1057 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30270 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Andrew Fuerste-Henry from comment #2)
Great start, Nick! Sadly, there was an error when setting HoldsSplitQueue to "pickup library and itemtype."
Template process failed: undef error - The method Koha::Hold->object is not covered by tests!
Trace begun at /kohadevbox/koha/Koha/Object.pm line 875 Koha::Object::AUTOLOAD('Koha::Hold=HASH(0x55f3aa7bafe0)') called at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt line 1052 eval {...} at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt line 1052 eval {...} at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt line 1057
Add a new patch to the dependency -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30270 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |BLOCKED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org