https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23762 --- Comment #1 from Bin Wen <bin.wen@inlibro.com> --- Created attachment 93820 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93820&action=edit Bug 23762 - Editing is_html status of email template fails under multi-languages To test: 1.Enable multi-languages 2.Set the preference 'TranslateNotices' on 'Allow' 3.Go to: tools==>Notices & slips==>Edit (one notice) 4.Click on the "Email" in the "Default" tab, change the checkbox status of 'HTML Messages'. 5.Save 6.Reopen the notice, nothing changed. 7.Apply the patch 8.Repeat the steps 4 and 5 9.Success. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23762 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Bin, I tested this according to your test plan, but the HTML checkbox saves correctly for me on master. Can you please check your test plan again? What I did: - Edit MEMBERSHIP_EXPIRY - Pick default tab - Check checkbox for HTML - Save - Reopen - Checkbox was saved (patch wasn't applied) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23762 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Katrin Fischer from comment #3)

Actually, it should be: Don't use default, but any other. I can see the issue when picking German.

Actually no, this happens with and without the patch if no subject and text is entered. I am sorry, I can't replicate the problem :( -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23762 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23762 --- Comment #7 from Bin Wen <bin.wen@inlibro.com> --- (In reply to Katrin Fischer from comment #5)

Ok... it cannot be unchecked it seems.

Hi Katrin, thanks for reminding me to add it to the test plan. Only when you enter the subject and content and save it will the corresponding language email template be generated in the table 'letter'. To test: 1.Enable multi-languages 2.Set the preference 'TranslateNotices' on 'Allow' 3.Go to: tools==>Notices & slips==>Edit (one notice) 4.Make sure that multilingual email templates are not empty. 5.Click on the "Email" in the "Default" tab, change the checkbox status of 'HTML Messages'. 6.Save 7.Reopen the notice, nothing changed. 8.Apply the patch 9.Repeat the steps 4 and 5 10.Success. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23762 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |bin.wen@inlibro.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23762 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93906|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94948 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94948&action=edit Bug 23762: Editing is_html status of email template fails under multi-languages To test: 1.Enable multi-languages 2.Set the preference 'TranslateNotices' on 'Allow' 3.Go to: tools==>Notices & slips==>Edit (one notice) 4.Click on the "Email" in the Default, uncheck the checkbox for 'HTML Messages'. 5.Save 6.Reopen the notice, nothing changed. 7.Apply the patch 8.Repeat the steps 4 and 5 9.Success. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23762 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Code makes sense, bug replicated and proved to be resolved by this patch. Passes QA scripts and although I'd love to have seen an accompanying selenium test that's not a blocker. Passing QA. Minor note.. please remember to alter the 'Importance' of bugs.. This was labelled as an enhancement when in my mind it's a bug. Nice work finding and fixing though Bin Wen -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23762 --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes.