[Bug 7061] New: SQLHelper has unused global variables
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7061 Bug #: 7061 Summary: SQLHelper has unused global variables Classification: Unclassified Change sponsored?: --- Product: Koha Version: unspecified Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 Component: Architecture, internals, and plumbing AssignedTo: ian.walls@bywatersolutions.com ReportedBy: ian.walls@bywatersolutions.com QAContact: koha-bugs@lists.koha-community.org my $tablename and my $hash are globally defined in C4::SQLHelper, but are never used; all subroutines use a locally scoped $tablename, and $hash is never used, locally or otherwise. Removing these two lines may help ensure mod_perl compatibility (since variables in subroutines cannot safely alter values in outer script in persistent environments). Or not. If nothing else, it's just a bit a trivial cleanup. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7061 --- Comment #1 from Ian Walls <ian.walls@bywatersolutions.com> 2011-10-19 00:21:49 UTC --- Created attachment 5970 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5970 Proposed Patch Removes two unused global variables from SQLHelper -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7061 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Patch Status|--- |Needs Signoff Severity|enhancement |trivial -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7061 laurenthdl <henridamien.laurent@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |henridamien.laurent@biblibr | |e.com --- Comment #2 from laurenthdl <henridamien.laurent@biblibre.com> 2011-10-19 15:06:50 UTC --- idea was to use the hash to store the whole database structure and use that rather than making a SHOW TABLE never been implemented because of time. It should help to store the database structure somewhere in some way. Would it be DBIC schema, or a yaml file no preference. But should be in our mind though -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7061 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5970|0 |1 is obsolete| | --- Comment #3 from Nicole C. Engard <nengard@gmail.com> 2011-10-19 19:56:14 UTC --- Created attachment 5997 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5997 [SIGNED-OFF] Bug 7061: unnecessary global variables declared in C4::SQLHelper Removes $tablename and $hash from global scope of C4/SQLHelper.pm. They are never used; all instances of $table are locally scoped to the subroutines, and $hash is never used. This may help with persistance; if not, it's at least a bit of trivial cleanup. To test: 1. Search for a patron 2. Create a Contract in Acquisitions 3. Modify that Contract 4. Delete that Contract All instances should return error free. This checks the subroutines of SQLHelper Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7061 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7061 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Signed Off |Passed QA --- Comment #4 from Ian Walls <ian.walls@bywatersolutions.com> 2011-10-19 22:18:38 UTC --- Marking Passed QA, RM please verify. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7061 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |paul.poulain@biblibre.com Version|unspecified |rel_3_6 Patch Status|Passed QA |Patch Pushed --- Comment #5 from Paul Poulain <paul.poulain@biblibre.com> 2011-11-04 11:20:04 UTC --- patch pushed, trivial changes & perfect test plan, please test & close -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7061 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #6 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This was included in the 3.6 branch prior to 3.6.4. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org