[Bug 11252] New: rebuild_zebra.pl should not have --munge-config
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11252 Bug ID: 11252 Summary: rebuild_zebra.pl should not have --munge-config Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching Assignee: gmcharlt@gmail.com Reporter: gmcharlt@gmail.com QA Contact: testopia@bugs.koha-community.org The --munge-config option of rebuild_zebra.pl attempts to create a valid Zebra configuration. While there was a period in the 3.0 days where this might have been useful, nowadays this option would either not work, or if it does work, be actively dangerous. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11252 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11252 --- Comment #1 from Galen Charlton <gmcharlt@gmail.com> --- Created attachment 22944 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22944&action=edit Bug 11252: remove deprecated -munge-config switch from rebuild_zebra.pl The -munge-config switch has been deprecated for years, and trying to use it would either not work at all or, if it did "work", almost certainly damage one's Zebra configuration for Koha. This patch removes this switch. To test: [1] Run rebuild_zebra.pl and verify that no mention is made of -munge-config. [2] Run rebuild_zebra.pl to index records in one's test database and verify that there are no regressions. Signed-off-by: Galen Charlton <gmc@esilibrary.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11252 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11252 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22944|0 |1 is obsolete| | --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 23766 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23766&action=edit Bug 11252: remove deprecated -munge-config switch from rebuild_zebra.pl The -munge-config switch has been deprecated for years, and trying to use it would either not work at all or, if it did "work", almost certainly damage one's Zebra configuration for Koha. This patch removes this switch. To test: [1] Run rebuild_zebra.pl and verify that no mention is made of -munge-config. [2] Run rebuild_zebra.pl to index records in one's test database and verify that there are no regressions. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Removing a really dangerous option -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11252 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11252 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23766|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 23820 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23820&action=edit [PASSED QA] Bug 11252: remove deprecated -munge-config switch from rebuild_zebra.pl The -munge-config switch has been deprecated for years, and trying to use it would either not work at all or, if it did "work", almost certainly damage one's Zebra configuration for Koha. This patch removes this switch. To test: [1] Run rebuild_zebra.pl and verify that no mention is made of -munge-config. [2] Run rebuild_zebra.pl to index records in one's test database and verify that there are no regressions. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Removing a really dangerous option Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes all tests and QA script. Ran rebuild_zebra.pl with various options and confirmed that data was reindexed successfully. No regressions found. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11252 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11252 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers@biblibre.co | |m --- Comment #5 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Patch pushed to 3.14.x, will be in 3.14.2. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org