[Bug 32701] New: Self checkout help page lacks required I18N JavaScript
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32701 Bug ID: 32701 Summary: Self checkout help page lacks required I18N JavaScript Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org If you view the self checkout help page and look in the browser console you will see an error: jQuery.Deferred exception: __ is not defined The template does not include all the right JavaScript assets for the I18N JS to function properly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32701 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32701 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32701 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28488 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28488 [Bug 28488] Javascript error in self-checkout (__ is not defined) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32701 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32701 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 150137 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150137&action=edit Bug 32701: Fix I18N JavaScript libraries on self checkout help page The help page was missing the fixes from bug 28488. The missing libraries are causing a JavaScript error on the page and likely other issues. To test: * Make sure WebBasedSelfCheck is activated and configured Note: In ktd you don't need to configure anything, it's already set up. * In the OPAC, go to: /cgi-bin/koha/sco/sco-main.pl * Click on the link to the help in the top right corner * Verify you see the error in the console: jQuery.Deferred exception: __ is not defined * Apply patch * Restart things * Reload the page * Veriy the errors are gone -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32701 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32701 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150137|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 150145 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150145&action=edit Bug 32701: Fix I18N JavaScript libraries on self checkout help page The help page was missing the fixes from bug 28488. The missing libraries are causing a JavaScript error on the page and likely other issues. To test: * Make sure WebBasedSelfCheck is activated and configured Note: In ktd you don't need to configure anything, it's already set up. * In the OPAC, go to: /cgi-bin/koha/sco/sco-main.pl * Click on the link to the help in the top right corner * Verify you see the error in the console: jQuery.Deferred exception: __ is not defined * Apply patch * Restart things * Reload the page * Veriy the errors are gone Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32701 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32672 CC| |jonathan.druart+koha@gmail. | |com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32701 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32701 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150145|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 150211 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150211&action=edit Bug 32701: Fix I18N JavaScript libraries on self checkout help page The help page was missing the fixes from bug 28488. The missing libraries are causing a JavaScript error on the page and likely other issues. To test: * Make sure WebBasedSelfCheck is activated and configured Note: In ktd you don't need to configure anything, it's already set up. * In the OPAC, go to: /cgi-bin/koha/sco/sco-main.pl * Click on the link to the help in the top right corner * Verify you see the error in the console: jQuery.Deferred exception: __ is not defined * Apply patch * Restart things * Reload the page * Veriy the errors are gone Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32701 --- Comment #4 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- It does not make sense to have it here, but I am lazy to find a better solution (and it's already in sci-main). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32701 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32701 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32701 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.06 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32701 --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32701 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|23.05.00,22.11.06 |23.05.00,22.11.06,22.05.14 released in| | CC| |lucas@bywatersolutions.com --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 22.05.x for upcoming 22.05.14 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32701 Danyon Sewell <danyonsewell@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |danyonsewell@catalyst.net.n | |z --- Comment #8 from Danyon Sewell <danyonsewell@catalyst.net.nz> --- Does this need to be backported to 21.11.x? -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org