[Bug 9212] New: Parentheses in subject headings break search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9212 Bug ID: 9212 Summary: Parentheses in subject headings break search Classification: Unclassified Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: gmcharlt@gmail.com Reporter: kyle@bywatersolutions.com Click a subject link such as "SAS (Computer program language)" gives the error: Error: Can't call method "sort" on an undefined value at /home/koha/kohaclone/C4/Search.pm line 404. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9212 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 13887 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13887&action=edit Bug 9212 - Parentheses in subject headings break search -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9212 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P3 Assignee|gmcharlt@gmail.com |kyle@bywatersolutions.com Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9212 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9212 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9212 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=1807 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9212 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- You don't say what the context for this error is--OPAC or staff client, XSLT or non-XSLT--but I can't reproduce the error. I tested with this record: http://lccn.loc.gov/2011019323 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9212 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- I'm marking this as failed QA simply because it's not testable without more details. Please resubmit the patch with a detailed commit message including a test plan. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9212 gbarna@uttyler.edu changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gbarna@uttyler.edu --- Comment #4 from gbarna@uttyler.edu --- (In reply to comment #0)
Click a subject link such as "SAS (Computer program language)" gives the error:
Error: Can't call method "sort" on an undefined value at /home/koha/kohaclone/C4/Search.pm line 404.
Our library has the same issue. We have upgraded to 3.10 and when clicking on, for example, Ellis Island Immigration Station (N.Y. and N.J.), we get the following error message: Error: Can't call method "sort" on an undefined value at /home/koha/kohaclone/C4/Search.pm line 407. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9212 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Test Plan: 1) In the OPAC, try clicking a subject link that contains parentheses, you should get an error 2) Apply the patch 3) Repeat step 1, this time it should work correctly. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9212 --- Comment #6 from gbarna@uttyler.edu --- (In reply to comment #5)
Test Plan: 1) In the OPAC, try clicking a subject link that contains parentheses, you should get an error 2) Apply the patch 3) Repeat step 1, this time it should work correctly.
I applied the patch and repeated step 1. Problem was not solved. :-( -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9212 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |chris@bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9212 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13887|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 16043 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16043&action=edit Bug 9212 - Parentheses in subject headings break search Subjects links for subjects with parentheses will not give any results. Test Plan: 1) In the OPAC, try clicking a subject link that contains parentheses, you should get an error 2) Apply the patch 3) Repeat step 1, this time it should work correctly. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9212 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9212 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Small patch |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9212 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9212 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16043|0 |1 is obsolete| | --- Comment #8 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 16105 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16105&action=edit Bug 9212 - Parentheses in subject headings break search Subjects links for subjects with parentheses will not give any results. Test Plan: 1) In the OPAC, try clicking a subject link that contains parentheses, you should get an error 2) Apply the patch 3) Repeat step 1, this time it should work correctly. Signed-off-by: Liz Rea <liz@catalyst.net.nz> Tested per plan, without the patch I didn't get the sort error, but I did get "result not found" With the patch, I came back to my same record. I take this as an indicator that the patch is working. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9212 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz@catalyst.net.nz --- Comment #9 from Liz Rea <liz@catalyst.net.nz> --- The subject heading I had added was Customer Relations (nonsense) in a 650a -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9212 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl QA Contact| |m.de.rooy@rijksmuseum.nl --- Comment #10 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- QA: Looking at this one now. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9212 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #11 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- QA Comment: This is marked trivial, but it appears to be not that trival at all :) Patch complexity is not about the size only.. Liz: If you tested a 650, did you check if it was no an:xxx-link? I tested with 653s for that reason. The behavior of this patch depends on several pref values, including UseICU and TraceSubjectSubdivisions, and OPAC XSLT. When the tracing quotes {|} are disabled, the normal quotes are doubled in the XSLT searches leading to the famous: Can't call method "sort" on an undefined value at /usr/share/koha/testclone/C4/Search.pm line 422. Note that before the patch, this search would have worked! Also I feel that this report should also include the search at staff side. A similar change should be made in intranet xslt and normal view to be consistent. Note that now the search in previous example works under staff with two quotes and does not work in opac with four quotes.. Failed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9212 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=9687 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9212 --- Comment #12 from Liz Rea <liz@catalyst.net.nz> --- The search is not broken on the staff side - and it seems that the same thing happens with Author authorities as well as subjects, I discovered today. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9212 --- Comment #13 from Kyle M Hall <kyle@bywatersolutions.com> --- *** Bug 8783 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9212 jdemuth@roseville.ca.us <jdemuth@roseville.ca.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jdemuth@roseville.ca.us -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9212 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED Resolution|--- |DUPLICATE CC| |katrin.fischer@bsz-bw.de --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Sorry, I missed this at first glance and created bug 13650, which is a different approach to fixing this that seems to avoid the problems Marcel found nicely. I tested with different variations of TraceCompleteSubfields and TraceSubjectSubdivisions and didn't find any problems. Marking this duplicate. *** This bug has been marked as a duplicate of bug 13650 *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org