[Bug 16588] New: libreadonly-perl (and libreadonly-xs-perl) need to be added as dependencies
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588 Bug ID: 16588 Summary: libreadonly-perl (and libreadonly-xs-perl) need to be added as dependencies Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Packaging Assignee: koha-bugs@lists.koha-community.org Reporter: robin@kallisti.net.nz QA Contact: testopia@bugs.koha-community.org CC: robin@catalyst.net.nz Doing a build in a clean environment: # Failed test 'use C4::Overdues;' # at t/00-load.t line 47. # Tried to use 'C4::Overdues'. # Error: Can't locate Readonly.pm in @INC (you may need to install the Readonly module) (@INC contains: /build/koha-3.23~git+20160525154303.188b3b5b/blib/PERL_MODULE_DIR /build/koha-3.23~git+20160525154303.188b3b5b/blib/arch /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.22.1 /usr/local/share/perl/5.22.1 /usr/lib/x86_64-linux-gnu/perl5/5.22 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl/5.22 /usr/share/perl/5.22 /usr/local/lib/site_perl /usr/lib/x86_64-linux-gnu/perl-base .) at /build/koha-3.23~git+20160525154303.188b3b5b/blib/PERL_MODULE_DIR/Koha/SearchEngine.pm line 22. It should have been added in bug 7893, but apparently went missing some time later. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com --- Comment #1 from M. Tompsett <mtompset@hotmail.com> --- Yes, I found this report as a result of noticing Readonly in the following: Koha/Edifact/Order.pm Koha/ElasticSearch.pm Koha/SearchEngine.pm -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=14066 CC| |mirko@abunchofthings.net --- Comment #2 from Mirko Tietgen <mirko@abunchofthings.net> --- It was deleted by bug 14066. So it seems somebody reintroduced it. I added both deps to the packages for 16.05.01. And a red readonly::xs on the about page already triggered the first question again. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I'd say, let's remove it (again) and use the constant pragma instead http://perlmaven.com/constants-and-read-only-variables-in-perl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588 --- Comment #4 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Jonathan Druart from comment #3)
I'd say, let's remove it (again) and use the constant pragma instead http://perlmaven.com/constants-and-read-only-variables-in-perl
And add something to the PERL section of the Coding Guidelines indicating the preferred method for defining read-only constants. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588 --- Comment #5 from Mirko Tietgen <mirko@abunchofthings.net> --- Any volunteers? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart@bugs.koha-c |ity.org |ommunity.org Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |7736, 12478, 14066 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 [Bug 7736] Edifact QUOTE and ORDER functionality https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 [Bug 12478] Elasticsearch support for Koha https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14066 [Bug 14066] Koha code does not really use Readonly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 53636 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53636&action=edit Bug 16588: Remove Readonly from Edifact Bug 14066 has removed the Readonly dependency, but in the meanwhile, 2 long standing reports reintroduced it: Edifact and ElasticSearch This patchset will remove it from these 2 modules. Test plan: No idea how to test Edifact, I have not tested this patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 53637 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53637&action=edit Bug 16588: Remove Readonly from SearchEngine Test plan: Make sure you are able to reindex and search for records at the OPAC using ElasticSearch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 53638 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53638&action=edit Bug 16588: Koha::SearchEngine must return a true value -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17017 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17043 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17043 [Bug 17043] debian/list-deps fixes, master edition -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|17043 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17043 [Bug 17043] debian/list-deps fixes, master edition -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|libreadonly-perl (and |Remove the Readonly |libreadonly-xs-perl) need |dependency (again) |to be added as dependencies | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17043 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |colin.campbell@ptfs-europe. | |com --- Comment #9 from Colin Campbell <colin.campbell@ptfs-europe.com> --- Would it not be preferable to add Readonly rather than replace usages of Readonly by constant reintroducing exactly the problems with constant readonly addresses (see the Readonly doc). I thought Readonly was in the dependencies list previously. It would be safer to replace the readonly vars with simple variables than using the constant pragma -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588 --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Colin Campbell from comment #9)
Would it not be preferable to add Readonly rather than replace usages of Readonly by constant reintroducing exactly the problems with constant readonly addresses (see the Readonly doc). I thought Readonly was in the dependencies list previously.
It would be safer to replace the readonly vars with simple variables than using the constant pragma
I asked for feedbacks on bug 14066 comment 2 and did not get any cons so decided to continue on this way. We only use constant with scalars so far, therefore the different problems with the constant pragma should not impact us too much. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16746 --- Comment #11 from M. Tompsett <mtompset@hotmail.com> --- Since this touches a lot of { index => ... } stuff, I thought I'd add bug 16746 to the see also, given my counter patch and discussion on the bug regarding elastic vs. zebra calls. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588 --- Comment #12 from M. Tompsett <mtompset@hotmail.com> --- After applying this, there was still Readonly in Koha/Edifact/Order.pm, which is related in part to bug 16703's adding it back in, I think. Does _const really need Readonly for it to work? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588 --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 54477 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54477&action=edit Bug 16588: (follow-up) Remove Readonly from Edifact -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=13767 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53636|0 |1 is obsolete| | --- Comment #14 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 55934 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55934&action=edit Bug 16588: Remove Readonly from Edifact Bug 14066 has removed the Readonly dependency, but in the meanwhile, 2 long standing reports reintroduced it: Edifact and ElasticSearch This patchset will remove it from these 2 modules. Test plan: No idea how to test Edifact, I have not tested this patch Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53637|0 |1 is obsolete| | --- Comment #15 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 55935 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55935&action=edit Bug 16588: Remove Readonly from SearchEngine Test plan: Make sure you are able to reindex and search for records at the OPAC using ElasticSearch Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53638|0 |1 is obsolete| | --- Comment #16 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 55936 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55936&action=edit Bug 16588: Koha::SearchEngine must return a true value Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54477|0 |1 is obsolete| | --- Comment #17 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 55937 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55937&action=edit Bug 16588: (follow-up) Remove Readonly from Edifact Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com --- Comment #18 from Nick Clemens <nick@bywatersolutions.com> --- I did not test Edifact but got Kyle Hall to take a look and he approved -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588 --- Comment #19 from Colin Campbell <colin.campbell@ptfs-europe.com> --- WHY?????? Using constant instead of readonly is more bug prone - If you must remove readonly use simple scalars instead of constant -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588 --- Comment #20 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Colin Campbell from comment #19)
WHY??????
Using constant instead of readonly is more bug prone - If you must remove readonly use simple scalars instead of constant
Because it has been added, then removed because it was not really used 14066, then re-added but not correctly (without the dependency). There are no really advantages (regarding at how we use it) to depend on Readonly, and constant is in the perl code. This bug prevent packages to build correctly in a clean environment. I have already answered you on comment 10 about Readonly vs constant, you can also see bug 14066 comment 2 (more than 2 years ago). A patch was submitted (2 months ago) when nobody wanted to fix it. Feel free to submit a counter patch, but I am out. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588 --- Comment #21 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #20) perl core* -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588 --- Comment #22 from Mirko Tietgen <mirko@abunchofthings.net> --- Can we please not re-discuss this from the beginning now that we are almost there? It was brought up months ago and now it got a lot of work put into it. I need this for packaging (one way or the other) and I'd appreciate if it could come soon. To go back to re-re-add readonly (or how many re-s that are by now) please open a new bug and base your patches on this one. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55934|0 |1 is obsolete| | Attachment #55937|0 |1 is obsolete| | --- Comment #23 from Colin Campbell <colin.campbell@ptfs-europe.com> --- Created attachment 56853 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56853&action=edit Amended Patch Remove the Readonly dependency from Edifact::Order in a way that does not introduce minor logic changes - the readonly variables are now simple scalars and hashes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |katrin.fischer@bsz-bw.de --- Comment #24 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Patch doesn't apply - can we also get a quick sign-off on the last patch from Colin to complete this? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55935|0 |1 is obsolete| | Attachment #55936|0 |1 is obsolete| | Attachment #56853|0 |1 is obsolete| | --- Comment #25 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 57516 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57516&action=edit Bug 16588: Remove Readonly from SearchEngine Test plan: Make sure you are able to reindex and search for records at the OPAC using ElasticSearch Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588 --- Comment #26 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 57517 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57517&action=edit Bug 16588: Koha::SearchEngine must return a true value Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588 --- Comment #27 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 57518 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57518&action=edit Bug 16588 Remove Readonly from Edifact::Order Remove Readonly dependency from Edifact::Order Do not replace with Constant as we want these variables to interpolate and do not wish to change the logic in constructing the service string advice -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588 --- Comment #28 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 57519 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57519&action=edit Bug 16588: Remove Readonly from the dependency list -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |srdjan@catalyst.net.nz --- Comment #29 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- Is there any reason we have BIBLIOS_INDEX and AUTHORITIES_INDEX defined in Koha::SearchEngine::Elasticsearch? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588 --- Comment #30 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Srdjan Jankovic from comment #29)
Is there any reason we have BIBLIOS_INDEX and AUTHORITIES_INDEX defined in Koha::SearchEngine::Elasticsearch?
Where do you want to have them defined? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588 --- Comment #31 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- (In reply to Jonathan Druart from comment #30)
(In reply to Srdjan Jankovic from comment #29)
Is there any reason we have BIBLIOS_INDEX and AUTHORITIES_INDEX defined in Koha::SearchEngine::Elasticsearch?
Where do you want to have them defined?
Well they are already defined with the same values in Koha::SearchEngine. I just wanted to know if they relate to the same thing. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588 --- Comment #32 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Srdjan Jankovic from comment #31)
(In reply to Jonathan Druart from comment #30)
(In reply to Srdjan Jankovic from comment #29)
Is there any reason we have BIBLIOS_INDEX and AUTHORITIES_INDEX defined in Koha::SearchEngine::Elasticsearch?
Where do you want to have them defined?
Well they are already defined with the same values in Koha::SearchEngine. I just wanted to know if they relate to the same thing.
Yes, in my understanding they are. One could be removed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com QA Contact|testopia@bugs.koha-communit |tomascohen@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #33 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- There is a conflict that I tried to fix, but maybe it's better you take a look. Tried to locate other cases that need to be fixed: $ git grep '\$Koha:' Koha/Authorities.pm: my $searcher = Koha::SearchEngine::Search->new({ index => $Koha::SearchEngine::BIBLIOS_INDEX }); Koha/Authorities.pm: my $searcher = Koha::SearchEngine::Search->new({ index => $Koha::SearchEngine::BIBLIOS_INDEX }); Looks suspicious. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588 --- Comment #34 from M. Tompsett <mtompset@hotmail.com> --- The removal of Readonly::XS is actually a separate problem, in that even if we were keeping Readonly, we shouldn't be using or checking for Readonly::XS. See bug 20103 instead. This will conflict with the last patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20103 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jonathan.druart@bugs.koha-c |mtompset@hotmail.com |ommunity.org | --- Comment #35 from M. Tompsett <mtompset@hotmail.com> --- I'm taking this, to bring it back to a state where it can apply. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57516|0 |1 is obsolete| | --- Comment #36 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 73444 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73444&action=edit Bug 16588: Remove Readonly from SearchEngine Test plan: Make sure you are able to reindex and search for records at the OPAC using ElasticSearch Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57517|0 |1 is obsolete| | --- Comment #37 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 73445 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73445&action=edit Bug 16588: Koha::SearchEngine must return a true value Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57518|0 |1 is obsolete| | --- Comment #38 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 73446 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73446&action=edit Bug 16588 Remove Readonly from Edifact::Order Remove Readonly dependency from Edifact::Order Do not replace with Constant as we want these variables to interpolate and do not wish to change the logic in constructing the service string advice -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57519|0 |1 is obsolete| | --- Comment #39 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 73447 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73447&action=edit Bug 16588: Remove Readonly from the dependency list -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588 --- Comment #40 from M. Tompsett <mtompset@hotmail.com> --- Still some issues to work on. Please do not think I am finished. Sorry for being spammy. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73444|0 |1 is obsolete| | --- Comment #41 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 73448 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73448&action=edit Bug 16588: Remove Readonly from SearchEngine Test plan: Make sure you are able to reindex and search for records at the OPAC using ElasticSearch Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73445|0 |1 is obsolete| | --- Comment #42 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 73449 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73449&action=edit Bug 16588: Koha::SearchEngine must return a true value Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73446|0 |1 is obsolete| | --- Comment #43 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 73450 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73450&action=edit Bug 16588 Remove Readonly from Edifact::Order Remove Readonly dependency from Edifact::Order Do not replace with Constant as we want these variables to interpolate and do not wish to change the logic in constructing the service string advice -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73447|0 |1 is obsolete| | --- Comment #44 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 73451 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73451&action=edit Bug 16588: Remove Readonly from the dependency list -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588 --- Comment #45 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 73452 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73452&action=edit Bug 16588: Follow up with more missing changes Hunting for _INDEX and $Koha::SearchEngine provided more places to tweak. Added 'use Koha::SearchEngine;' where the constant was referenced. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|mtompset@hotmail.com |koha-bugs@lists.koha-commun | |ity.org Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart@bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #46 from M. Tompsett <mtompset@hotmail.com> --- I was hoping for a sign off on my follow up. Now this needs a rebase, and it's messy. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jonathan.druart@bugs.koha-c |koha-bugs@lists.koha-commun |ommunity.org |ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588 --- Comment #47 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- It looks like this is still valid: Koha/Edifact/Order.pm:use Readonly qw( Readonly ); Koha/Edifact/Order.pm:Readonly::Scalar my $seg_terminator => q{'}; Koha/Edifact/Order.pm:Readonly::Scalar my $separator => q{+}; Koha/Edifact/Order.pm:Readonly::Scalar my $component_separator => q{:}; Koha/Edifact/Order.pm:Readonly::Scalar my $release_character => q{?}; Koha/Edifact/Order.pm:Readonly::Scalar my $NINES_12 => 999_999_999_999; Koha/Edifact/Order.pm:Readonly::Scalar my $NINES_14 => 99_999_999_999_999; Koha/Edifact/Order.pm:Readonly::Scalar my $CHUNKSIZE => 35; Koha/Edifact/Order.pm: Readonly my %S => { Koha/SearchEngine.pm:use Readonly qw( Readonly ); Koha/SearchEngine.pm:Readonly our $BIBLIOS_INDEX => 'biblios'; Koha/SearchEngine.pm:Readonly our $AUTHORITIES_INDEX => 'authorities'; Koha/SearchEngine/Elasticsearch.pm:use Readonly qw( Readonly ); Koha/SearchEngine/Elasticsearch.pm:Readonly our $BIBLIOS_INDEX => 'biblios'; Koha/SearchEngine/Elasticsearch.pm:Readonly our $AUTHORITIES_INDEX => 'authorities'; cpanfile:requires 'Readonly', '2.00'; -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org