[Bug 12367] New: Import patrons still says "MD5 hash"
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12367 Bug ID: 12367 Summary: Import patrons still says "MD5 hash" Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Tools Assignee: gmcharlt@gmail.com Reporter: magnus@enger.priv.no QA Contact: testopia@bugs.koha-community.org The password hashing algorithm was changed in Bug 9611, but on Tools > Import patrons, in the text on the right hand side, it still says: "'password' should be stored in plaintext, and will be converted to a MD5 hash (if your passwords are already encrypted, talk to your system administrator about options)." This has no practical effect, of course, but to someone evaluating Koha it might give the false impression that password security is lower than it really is. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12367 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12367 --- Comment #1 from Magnus Enger <magnus@enger.priv.no> --- Created attachment 28671 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28671&action=edit Bug 12367 - Import patrons still says "MD5 hash" The password hashing algorithm was changed in Bug 9611, but on Tools > Import patrons, in the text on the right hand side, it still says: "'password' should be stored in plaintext, and will be converted to a MD5 hash" This has no practical effect, of course, but to someone evaluating Koha it might give the false impression that password security is lower than it really is. To test: - Look at Tools > Import patrons and verify that it says "a MD5 hash" - Also look at the help page and see the same text - Apply the patch - Check that both the tool and the help now says "a Bcrypt hash" I'll do a patch for the docs too. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12367 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |magnus@enger.priv.no -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12367 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12367 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28671|0 |1 is obsolete| | --- Comment #2 from David Cook <dcook@prosentient.com.au> --- Created attachment 28693 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28693&action=edit Bug 12367 - Import patrons still says "MD5 hash" The password hashing algorithm was changed in Bug 9611, but on Tools > Import patrons, in the text on the right hand side, it still says: "'password' should be stored in plaintext, and will be converted to a MD5 hash" This has no practical effect, of course, but to someone evaluating Koha it might give the false impression that password security is lower than it really is. To test: - Look at Tools > Import patrons and verify that it says "a MD5 hash" - Also look at the help page and see the same text - Apply the patch - Check that both the tool and the help now says "a Bcrypt hash" I'll do a patch for the docs too. Signed-off-by: David Cook <dcook@prosentient.com.au> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12367 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m Patch complexity|Trivial patch |String patch Depends on| |9611 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12367 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12367 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28693|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 28700 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28700&action=edit Bug 12367 - Import patrons still says "MD5 hash" The password hashing algorithm was changed in Bug 9611, but on Tools > Import patrons, in the text on the right hand side, it still says: "'password' should be stored in plaintext, and will be converted to a MD5 hash" This has no practical effect, of course, but to someone evaluating Koha it might give the false impression that password security is lower than it really is. To test: - Look at Tools > Import patrons and verify that it says "a MD5 hash" - Also look at the help page and see the same text - Apply the patch - Check that both the tool and the help now says "a Bcrypt hash" I'll do a patch for the docs too. Signed-off-by: David Cook <dcook@prosentient.com.au> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12367 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Magnus! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org