[Bug 9624] New: Replace YUI button on reports dictionary page with Bootstrap
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9624 Bug ID: 9624 Summary: Replace YUI button on reports dictionary page with Bootstrap Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/reports/dictionary.pl?phase=View Dictionary OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org The reports dictionary page uses YUI to generate the "New definition" button. It should use Bootstrap instead. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9624 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9624 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 15376 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15376&action=edit Bug 9624 - Replace YUI button on reports dictionary page with Bootstrap This patch removes the toolbar include file used by the reports dictionary and embeds the toolbar markup directly in the main template since it's the only instance where it is used. Toolbar is converted to use Bootstrap, replacing YUI button code with Bootstrap markup. To test, view the reports dictionary and confirm that the "New definition" button looks correct and works correctly. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9624 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15376|0 |1 is obsolete| | --- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 15383 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15383&action=edit [SIGNED-OFF] Bug 9624 - Replace YUI button on reports dictionary page with Bootstrap This patch removes the toolbar include file used by the reports dictionary and embeds the toolbar markup directly in the main template since it's the only instance where it is used. Toolbar is converted to use Bootstrap, replacing YUI button code with Bootstrap markup. To test, view the reports dictionary and confirm that the "New definition" button looks correct and works correctly. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Work as described. No errors. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9624 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9624 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9624 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15383|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 15445 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15445&action=edit [PASSED QA] Bug 9624 - Replace YUI button on reports dictionary page with Bootstrap This patch removes the toolbar include file used by the reports dictionary and embeds the toolbar markup directly in the main template since it's the only instance where it is used. Toolbar is converted to use Bootstrap, replacing YUI button code with Bootstrap markup. To test, view the reports dictionary and confirm that the "New definition" button looks correct and works correctly. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Work as described. No errors. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works nicely, no problems found. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9624 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de QA Contact| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9624 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org