[Bug 20223] New: Merge members-menu and circ-menu inc files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20223 Bug ID: 20223 Summary: Merge members-menu and circ-menu inc files Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: josef.moravec@gmail.com QA Contact: testopia@bugs.koha-community.org We have two similer patron menus in templates, almost everywhere is used circ-menu.inc. Only when editing patron record, the members-menu.inc is used. It means the menu items are not compete, because members-menu is not synchronized with updates of circ-menu. There is also reference to members-menu in member.tt template (the template used in patron search ) which is probably never taken into effect. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20223 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18789 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 [Bug 18789] Send a Koha::Patron object to the templates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20223 Bug 20223 depends on bug 18789, which changed state. Bug 18789 Summary: Send a Koha::Patron object to the templates https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20223 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20223 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 76575 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76575&action=edit Bug 20223: Merge members-menu and circ-menu inc files This patch removes members-menu.inc and replaces the last functional use of it with a call to circ-menu.inc. An invalid use of members-menu.inc has been removed from member.tt. To test, apply the patch and open a patron record for editing. The sidebar menu should look correct and all sidebar links should work correctly. View the patrons home page and confirm that nothing has broken. Search the Koha codebase for references to members-menu.inc. There should be none. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20223 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20223 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20223 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76575|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 78411 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78411&action=edit Bug 20223: Merge members-menu and circ-menu inc files This patch removes members-menu.inc and replaces the last functional use of it with a call to circ-menu.inc. An invalid use of members-menu.inc has been removed from member.tt. To test, apply the patch and open a patron record for editing. The sidebar menu should look correct and all sidebar links should work correctly. View the patrons home page and confirm that nothing has broken. Search the Koha codebase for references to members-menu.inc. There should be none. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20223 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20223 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78411|0 |1 is obsolete| | --- Comment #3 from Michal Denar <black23@gmail.com> --- Created attachment 78647 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78647&action=edit Bug 20223: Merge members-menu and circ-menu inc files This patch removes members-menu.inc and replaces the last functional use of it with a call to circ-menu.inc. An invalid use of members-menu.inc has been removed from member.tt. To test, apply the patch and open a patron record for editing. The sidebar menu should look correct and all sidebar links should work correctly. View the patrons home page and confirm that nothing has broken. Search the Koha codebase for references to members-menu.inc. There should be none. Michal Denar Signed-off-by: <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20223 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20223 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78647|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 79261 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79261&action=edit Bug 20223: Merge members-menu and circ-menu inc files This patch removes members-menu.inc and replaces the last functional use of it with a call to circ-menu.inc. An invalid use of members-menu.inc has been removed from member.tt. To test, apply the patch and open a patron record for editing. The sidebar menu should look correct and all sidebar links should work correctly. View the patrons home page and confirm that nothing has broken. Search the Koha codebase for references to members-menu.inc. There should be none. Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20223 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Changing to bugfix. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20223 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Found bug 21397 while testing. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20223 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick@bywatersolutions.com --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20223 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Pushed to Master |Pushed to Stable --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.05.x for 18.05.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20223 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Resolution|--- |FIXED Status|Pushed to Stable |RESOLVED --- Comment #9 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Depends on Bug 18789 not in 17.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org