[Bug 17381] New: Add system preference SCOUserHTML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17381 Bug ID: 17381 Summary: Add system preference SCOUserHTML Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Self checkout Assignee: koha-bugs@lists.koha-community.org Reporter: veron@veron.ch QA Contact: testopia@bugs.koha-community.org Add a system preference SCOUserHTML to display content on the self checkout page. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17381 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=5250 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17381 Agnes Rivers-Moore <arm@hanover.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arm@hanover.ca --- Comment #1 from Agnes Rivers-Moore <arm@hanover.ca> --- I would love this - just setting up SCO and noted the need for a bit more on screen help. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17381 --- Comment #2 from Agnes Rivers-Moore <arm@hanover.ca> --- I would love this option! Just setting up SCO and noted the need for a bit more user interface on screen help. It could be Library specific, so an HTML section would be very useful. I have help until end March 2017 - if anyone has time to introduce him to the code used we might be able to contribute, or to test. I would also like to change the text of the Print prompt - Cancel or OK is not very helpful in answer to "Do you want to print?" -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17381 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Agnes, maybe sent them to the IRC chat - there is almost always someone around to help out and answer questions. For a development setup, you can point them to https://github.com/digibib/kohadevbox. For other information on the development process the wiki is a helpful resource, especially the pages linked to the Developer handbook: https://wiki.koha-community.org/wiki/Developer_handbook. Good luck! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17381 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add system preference |Add system preference |SCOUserHTML |SCOMainUserBlock -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17381 --- Comment #4 from Marc Véron <veron@veron.ch> --- Created attachment 62295 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62295&action=edit Bug 17381: Add system preference SCOMainUserBlock This patch adds a system preference SCOMainUserBlock to display custom HTML on the self checkout page. To test: - Set up self checkout (see section Self Checkout in Circulaton sysprefs ) - Apply patch - Update db - Add some HTML system preference SCOMainUserBlock - Go to sco page - Verify that HTML displays on page (logged in and not logged in) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17381 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff Assignee|koha-bugs@lists.koha-commun |veron@veron.ch |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17381 --- Comment #5 from Marc Véron <veron@veron.ch> --- Still applies on current master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17381 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17381 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62295|0 |1 is obsolete| | --- Comment #6 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 63611 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63611&action=edit [SIGNED-OFF] Bug 17381: Add system preference SCOMainUserBlock This patch adds a system preference SCOMainUserBlock to display custom HTML on the self checkout page. To test: - Set up self checkout (see section Self Checkout in Circulaton sysprefs ) - Apply patch - Update db - Add some HTML system preference SCOMainUserBlock - Go to sco page - Verify that HTML displays on page (logged in and not logged in) Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17381 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |nick@bywatersolutions.com --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- Hi Marc, 1 - I am not sure where that closing div goes - #newcheckout does seem to close properly unless I missed something 2 - Why not use Koha.Preference TT plugin instead of passing the pref? -Nick -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17381 --- Comment #8 from Marc Véron <veron@veron.ch> --- Hi Nick I have no time ATM - If you like feel free to provide a follow-up. Marc -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17381 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12691 Status|Failed QA |ASSIGNED --- Comment #9 from Marc Véron <veron@veron.ch> --- I was not aware of Bug 12691 - Use Koha.Preference for calls to SCOUserJS, SCOUserCSS, OPACUserCSS, opacuserjs, etc in Self-Checkout Will re-write that 17381 on top of 12691. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12691 [Bug 12691] Use Koha.Preference for calls to SCOUserJS, SCOUserCSS, OPACUserCSS, opacuserjs, etc in Self-Checkout -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17381 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63611|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17381 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63611|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17381 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63611|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17381 --- Comment #10 from Marc Véron <veron@veron.ch> --- Created attachment 66271 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66271&action=edit Bug 17381: Add system preference SCOMainUserBlock This patch adds a system preference SCOMainUserBlock to display custom HTML on the self checkout page. To test: - Set up self checkout (see section Self Checkout in Circulaton sysprefs ) - Apply patch - Update db - Add some HTML system preference SCOMainUserBlock - Go to sco page - Verify that HTML displays on page (logged in and not logged in) New version based on Koha.Preference TT plugin as of comment #7 Depends on Bug 12691 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17381 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17381 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17381 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66271|0 |1 is obsolete| | --- Comment #11 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 66322 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66322&action=edit [SIGNED-OFF] Bug 17381: Add system preference SCOMainUserBlock This patch adds a system preference SCOMainUserBlock to display custom HTML on the self checkout page. To test: - Set up self checkout (see section Self Checkout in Circulaton sysprefs ) - Apply patch - Update db - Add some HTML system preference SCOMainUserBlock - Go to sco page - Verify that HTML displays on page (logged in and not logged in) New version based on Koha.Preference TT plugin as of comment #7 Depends on Bug 12691 Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17381 Bug 17381 depends on bug 12691, which changed state. Bug 12691 Summary: Use Koha.Preference for calls to SCOUserJS, SCOUserCSS, OPACUserCSS, opacuserjs, etc in Self-Checkout https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12691 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17381 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17381 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66322|0 |1 is obsolete| | --- Comment #12 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 68481 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68481&action=edit Bug 17381: Add system preference SCOMainUserBlock This patch adds a system preference SCOMainUserBlock to display custom HTML on the self checkout page. To test: - Set up self checkout (see section Self Checkout in Circulaton sysprefs ) - Apply patch - Update db - Add some HTML system preference SCOMainUserBlock - Go to sco page - Verify that HTML displays on page (logged in and not logged in) New version based on Koha.Preference TT plugin as of comment #7 Depends on Bug 12691 Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17381 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17381 --- Comment #14 from Agnes Rivers-Moore <arm@hanover.ca> --- Thank you everyone! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org