[Bug 24814] New: HTML forms set a minimal width for dropdown combo with empty set.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24814 Bug ID: 24814 Summary: HTML forms set a minimal width for dropdown combo with empty set. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: didier.gautheron@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl Hi, If there's no item, dropdown message "No matches found" is hard to read. Affect: koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tt koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-edit.tt To test: - Select a catalogue notice in Koha intranet. - Open add item form. - Choose a dropdown combo with an empty set, 'j - Shelving control number' is a good candidate. - Apply the patch. - Re select the compo in open add item form. It's a bandaid, a proper solution would be to compute container width on actuel message size. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24814 --- Comment #1 from didier <didier.gautheron@biblibre.com> --- Created attachment 100202 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100202&action=edit Bug 24814: HTML forms set a minimal width for dropdown combo with empty set. If there's no item, dropdown message "No matches found" is hard to read. Affect: koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tt koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-edit.tt To test: - Select a catalogue notice in Koha intranet. - Open add item form. - Choose a dropdown combo with an empty set, 'j - Shelving control number' is a good candidate. - Apply the patch. - Re select the compo in open add item form. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24814 didier <didier.gautheron@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24814 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |didier.gautheron@biblibre.c |ity.org |om -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24814 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24814 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100202|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 100282 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100282&action=edit Bug 24814: HTML forms set a minimal width for dropdown combo with empty set. If there's no item, dropdown message "No matches found" is hard to read. Affect: koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tt koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-edit.tt To test: - Select a catalogue notice in Koha intranet. - Open add item form. - Choose a dropdown combo with an empty set, 'j - Shelving control number' is a good candidate. - Apply the patch. - Re select the compo in open add item form. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24814 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Why 99? Should not this be a min-width CSS attribute instead? That would let us give a value in em. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24814 --- Comment #4 from didier <didier.gautheron@biblibre.com> --- 99 is 100% arbitrary. Using min-width is another option, but I'm not sure it'd be smaller patch/cleaner though. I'll look at it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24814 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de, | |oleonard@myacpl.org Status|Signed Off |Failed QA Summary|HTML forms set a minimal |HTML forms set a minimal |width for dropdown combo |width for dropdown combo |with empty set. |with empty set --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Moving to FQA for now, waiting for feedback from dev. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24814 Didier Gautheron <didier.gautheron@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Failed QA |RESOLVED --- Comment #6 from Didier Gautheron <didier.gautheron@biblibre.com> --- Not anymore an issue with latest bootstrap -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org