[Bug 39636] New: Add options to compare_es_to_db script
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39636 Bug ID: 39636 Summary: Add options to compare_es_to_db script Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org It would be nice to be able to only run the check against a single index Additionally, getting links to the staff side can be useful when library staff need to edit/update bad records -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39636 --- Comment #1 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- (In reply to Nick Clemens (kidclamp) from comment #0)
Additionally, getting links to the staff side can be useful when library staff need to edit/update bad records
Oops - this was already done -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39636 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39636 --- Comment #2 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 180957 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180957&action=edit Bug 39636: Update curl link With the move to the latest ES versions we got rid of 'data' type - we need to use '_doc' To test: 1 - Delete a record from the DB directly DELETE FROM biblio WHERE biblionumber=45; 2 - perl misc/maintenance/compare_es_to_db.pl 3 - Try the curl command - it doesn't work 4 - Apply this patch 5 - perl misc/maintenance/compare_es_to_db.pl 6 - Try the curl command - it now fetches the record -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39636 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180957|0 |1 is obsolete| | --- Comment #3 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 180958 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180958&action=edit Bug 39636: Add option to specify which indexes to check This patch adds --biblios and --authorities options to the script to allow checking only a single index To test: 0 - Apply patch 1 - perl misc/maintenance/compare_es_to_db.pl 2 - biblios and authorities are checked 3 - perl misc/maintenance/compare_es_to_db.pl -b 4 - Only biblios are checked 5 - perl misc/maintenance/compare_es_to_db.pl -a 6 - Only authorities are checked 7 - perl misc/maintenance/compare_es_to_db.pl -a -b 8 - Both indexes are checked -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39636 --- Comment #4 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 180959 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180959&action=edit Bug 39636: Update curl link With the move to the latest ES versions we got rid of 'data' type - we need to use '_doc' To test: 1 - Delete a record from the DB directly DELETE FROM biblio WHERE biblionumber=45; 2 - perl misc/maintenance/compare_es_to_db.pl 3 - Try the curl command - it doesn't work 4 - Apply this patch 5 - perl misc/maintenance/compare_es_to_db.pl 6 - Try the curl command - it now fetches the record -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39636 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39636 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180958|0 |1 is obsolete| | Attachment #180959|0 |1 is obsolete| | --- Comment #5 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 180972 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180972&action=edit Bug 39636: Add option to specify which indexes to check This patch adds --biblios and --authorities options to the script to allow checking only a single index To test: 0 - Apply patch 1 - perl misc/maintenance/compare_es_to_db.pl 2 - biblios and authorities are checked 3 - perl misc/maintenance/compare_es_to_db.pl -b 4 - Only biblios are checked 5 - perl misc/maintenance/compare_es_to_db.pl -a 6 - Only authorities are checked 7 - perl misc/maintenance/compare_es_to_db.pl -a -b 8 - Both indexes are checked Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Edit: tidied -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39636 --- Comment #6 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 180973 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180973&action=edit Bug 39636: Update curl link With the move to the latest ES versions we got rid of 'data' type - we need to use '_doc' To test: 1 - Delete a record from the DB directly DELETE FROM biblio WHERE biblionumber=45; 2 - perl misc/maintenance/compare_es_to_db.pl 3 - Try the curl command - it doesn't work 4 - Apply this patch 5 - perl misc/maintenance/compare_es_to_db.pl 6 - Try the curl command - it now fetches the record Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39636 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | --- Comment #7 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Nice, thank you! QA script happy and works as expected. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39636 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_24_05_candidate, | |rel_24_11_candidate --- Comment #8 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Please backport this helpful maintenance enhancement. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39636 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_24_05_candidate, | |rel_24_11_candidate | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39636 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180972|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 187046 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187046&action=edit Bug 39636: Add option to specify which indexes to check This patch adds --biblios and --authorities options to the script to allow checking only a single index To test: 0 - Apply patch 1 - perl misc/maintenance/compare_es_to_db.pl 2 - biblios and authorities are checked 3 - perl misc/maintenance/compare_es_to_db.pl -b 4 - Only biblios are checked 5 - perl misc/maintenance/compare_es_to_db.pl -a 6 - Only authorities are checked 7 - perl misc/maintenance/compare_es_to_db.pl -a -b 8 - Both indexes are checked Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39636 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180973|0 |1 is obsolete| | --- Comment #10 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 187047 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187047&action=edit Bug 39636: Update curl link With the move to the latest ES versions we got rid of 'data' type - we need to use '_doc' To test: 1 - Delete a record from the DB directly DELETE FROM biblio WHERE biblionumber=45; 2 - perl misc/maintenance/compare_es_to_db.pl 3 - Try the curl command - it doesn't work 4 - Apply this patch 5 - perl misc/maintenance/compare_es_to_db.pl 6 - Try the curl command - it now fetches the record Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39636 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize@openfifth.c | |o.uk QA Contact|testopia@bugs.koha-communit |martin.renvoize@openfifth.c |y.org |o.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39636 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |The `compare_es_to_db.pl` release notes| |script now supports the | |`-b/--biblios` and | |`-a/--authorities` options, | |allowing checks to be | |limited to a single index. | | | |Additionally, the generated | |Elasticsearch curl link has | |been updated to align with | |the latest version | |structure. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39636 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39636 --- Comment #11 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39636 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting CC| |Laura.escamilla@bywatersolu | |tions.com --- Comment #12 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- This is an enhancement and will not be backported to the 25.05.x branch. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org