[Bug 43206] New: cn_browser plugin red background on exact match is hard to read
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43206 Bug ID: 43206 Summary: cn_browser plugin red background on exact match is hard to read Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: andrew@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl Target Milestone: --- In the cn_browser cataloging plugin we put a red background on items with a call number that exactly matches the search term. The black text on red background is hard to read and red implies that there's some sort of problem. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43206 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |accessibility CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43206 --- Comment #1 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- It could also be helpful to add a distinct class to rows that match the search, as that would make local customization easier. But that's maybe a separate bug. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43206 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43206 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Comma delimited| |Athens County Public list of Sponsors| |Libraries Sponsorship status|--- |Sponsored Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43206 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 202751 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202751&action=edit Bug 43206: cn_browser plugin red background on exact match is hard to read This patch updates the cn_browser plugin output so that table rows are highlighted using row classes and in colors which have sufficient contrast. To test, apply the patch and set your 952$o tag to use the cn_browser plugin: - Administration -> MARC bibliographic frameworks -> BKS -> MARC Structure -> Tag 952 -> Edit subfields. - Under the "Full call number" tab (o), set the "Plugin" dropdown to "cn_browser.pl" and save your changes. - Go to Cataloging and locate a bibliographic record using the cataloging search. - Add or edit items. NOTE: In the testing data there is only one item with a callnumber and it is "FIC/kas" - In the "o - Full call number" field, type "FIC" and then click the plugin editor image. - You should see the record with the "FIC/kas" call number and a green row right above it (indicating where an item with the call number "FIC" would be in the results). - Revise your search using the form at the top, entering "FIC/kas". - The record row should now be highlighted in pale yellow. Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43206 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |andrew@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43206 Biblibre Sandboxes <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #202751|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43206 --- Comment #3 from Biblibre Sandboxes <sandboxes@biblibre.com> --- Created attachment 202844 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202844&action=edit Bug 43206: cn_browser plugin red background on exact match is hard to read This patch updates the cn_browser plugin output so that table rows are highlighted using row classes and in colors which have sufficient contrast. To test, apply the patch and set your 952$o tag to use the cn_browser plugin: - Administration -> MARC bibliographic frameworks -> BKS -> MARC Structure -> Tag 952 -> Edit subfields. - Under the "Full call number" tab (o), set the "Plugin" dropdown to "cn_browser.pl" and save your changes. - Go to Cataloging and locate a bibliographic record using the cataloging search. - Add or edit items. NOTE: In the testing data there is only one item with a callnumber and it is "FIC/kas" - In the "o - Full call number" field, type "FIC" and then click the plugin editor image. - You should see the record with the "FIC/kas" call number and a green row right above it (indicating where an item with the call number "FIC" would be in the results). - Revise your search using the form at the top, entering "FIC/kas". - The record row should now be highlighted in pale yellow. Sponsored-by: Athens County Public Libraries Signed-off-by: Gretchen <maxeinergl@gcc.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43206 Gretchen Maxeiner <maxeinergl@gcc.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |maxeinergl@gcc.edu --- Comment #4 from Gretchen Maxeiner <maxeinergl@gcc.edu> --- All works well. In addition to the test plan I also tested on some LCC call numbers I added into test, and the fuller results also looked great. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43206 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43206 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #202844|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43206 --- Comment #5 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 202846 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202846&action=edit Bug 43206: cn_browser plugin red background on exact match is hard to read This patch updates the cn_browser plugin output so that table rows are highlighted using row classes and in colors which have sufficient contrast. To test, apply the patch and set your 952$o tag to use the cn_browser plugin: - Administration -> MARC bibliographic frameworks -> BKS -> MARC Structure -> Tag 952 -> Edit subfields. - Under the "Full call number" tab (o), set the "Plugin" dropdown to "cn_browser.pl" and save your changes. - Go to Cataloging and locate a bibliographic record using the cataloging search. - Add or edit items. NOTE: In the testing data there is only one item with a callnumber and it is "FIC/kas" - In the "o - Full call number" field, type "FIC" and then click the plugin editor image. - You should see the record with the "FIC/kas" call number and a green row right above it (indicating where an item with the call number "FIC" would be in the results). - Revise your search using the form at the top, entering "FIC/kas". - The record row should now be highlighted in pale yellow. Sponsored-by: Athens County Public Libraries Signed-off-by: Gretchen <maxeinergl@gcc.edu> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43206 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |26.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43206 --- Comment #6 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Thanks everyone! Pushed to main for 26.11! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43206 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|26.11.00 |26.11.00,26.05.03 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43206 --- Comment #7 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to 26.05.x for the upcoming 26.05.03 release. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43206 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|26.11.00,26.05.03 |26.11.00,26.05.03,25.11.10 released in| | CC| |baptiste.wojtkowski@biblibr | |e.com --- Comment #8 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Pushed into 25.11.x for 25.11.10 nice work everyone -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org