https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40850 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |40262 Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40262 [Bug 40262] ILL - Save the fact that copyright clearance has been confirmed by the patron -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40850 --- Comment #1 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 186734 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186734&action=edit Bug 40850: Add `Koha::ILL::Request->add_or_update_attributes` Currently, ILL backends and plugins must implement custom logic to update existing extended attributes on ILL requests, as the core extended_attributes() method only supports adding new attributes and throws duplicate key errors when attempting to update existing ones. This has led to code duplication across multiple ILL plugins (Rapido, INNReach, SLNP) that all implement identical add_or_update_attributes() methods, and forces the Standard backend to use error-prone patterns when managing request metadata. This patch adds add_or_update_attributes() method to Koha::ILL::Request that provides a safe, efficient way to add new attributes or update existing ones in a single operation, eliminating duplicate key errors and reducing code duplication. The method: - Accepts a hashref of attribute type => value pairs - Updates existing attributes only when values actually change - Creates new attributes when they don't exist - Skips undefined or empty values to avoid constraint errors - Uses transactions for atomicity - Returns the request object for method chaining Test plan: 1. Apply patch 2. Run: $ ktd --shell k$ prove t/db_dependent/Koha/ILL/Request.t => SUCCESS: Tests pass! New method works correctly 3. Test adding new attributes works 4. Test updating existing attributes works 5. Test mixed add/update operations work 6. Test empty/undefined values are skipped 7. Sign off :-D -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40850 --- Comment #3 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 186736 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186736&action=edit Bug 40850: (follow-up) Use add_or_update_attributes in Standard backend This patch updates the Standard ILL backend to use the new add_or_update_attributes() method instead of the problematic extended_attributes() method that only supports adding new attributes. Changes: - Request creation: Use add_or_update_attributes() for setting metadata - Request migration: Use add_or_update_attributes() for copying attributes Benefits: - Eliminates duplicate key errors when updating existing requests - Cleaner code - removes array-to-hash conversion boilerplate - More efficient - only updates attributes when values change - Consistent with new Koha::ILL::Request API patterns Locations updated: - add_request(): Request creation with metadata (line ~1017) - migrate(): Request migration copying attributes (line ~731) Test plan: 1. Apply patch 2. Test ILL request creation in Standard backend: - Create new ILL request with metadata => SUCCESS: Request created with attributes 3. Test ILL request migration: - Migrate existing request to new request => SUCCESS: Attributes copied correctly 4. Test updating existing request metadata: - Edit request and update metadata fields => SUCCESS: No duplicate key errors 5. Sign off :-D -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40850 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186734|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 186755 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186755&action=edit Bug 40850: Add `Koha::ILL::Request->add_or_update_attributes` Currently, ILL backends and plugins must implement custom logic to update existing extended attributes on ILL requests, as the core extended_attributes() method only supports adding new attributes and throws duplicate key errors when attempting to update existing ones. This has led to code duplication across multiple ILL plugins (Rapido, INNReach, SLNP) that all implement identical add_or_update_attributes() methods, and forces the Standard backend to use error-prone patterns when managing request metadata. This patch adds add_or_update_attributes() method to Koha::ILL::Request that provides a safe, efficient way to add new attributes or update existing ones in a single operation, eliminating duplicate key errors and reducing code duplication. The method: - Accepts a hashref of attribute type => value pairs - Updates existing attributes only when values actually change - Creates new attributes when they don't exist - Skips undefined or empty values to avoid constraint errors - Uses transactions for atomicity - Returns the request object for method chaining Test plan: 1. Apply patch 2. Run: $ ktd --shell k$ prove t/db_dependent/Koha/ILL/Request.t => SUCCESS: Tests pass! New method works correctly 3. Test adding new attributes works 4. Test updating existing attributes works 5. Test mixed add/update operations work 6. Test empty/undefined values are skipped 7. Sign off :-D Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40850 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186736|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 186757 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186757&action=edit Bug 40850: (follow-up) Use add_or_update_attributes in Standard backend This patch updates the Standard ILL backend to use the new add_or_update_attributes() method instead of the problematic extended_attributes() method that only supports adding new attributes. Changes: - Request creation: Use add_or_update_attributes() for setting metadata - Request migration: Use add_or_update_attributes() for copying attributes Benefits: - Eliminates duplicate key errors when updating existing requests - Cleaner code - removes array-to-hash conversion boilerplate - More efficient - only updates attributes when values change - Consistent with new Koha::ILL::Request API patterns Locations updated: - add_request(): Request creation with metadata (line ~1017) - migrate(): Request migration copying attributes (line ~731) Test plan: 1. Apply patch 2. Test ILL request creation in Standard backend: - Create new ILL request with metadata => SUCCESS: Request created with attributes 3. Test ILL request migration: - Migrate existing request to new request => SUCCESS: Attributes copied correctly 4. Test updating existing request metadata: - Edit request and update metadata fields => SUCCESS: No duplicate key errors 5. Sign off :-D Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40850 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40850 --- Comment #8 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40850 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |david@davidnind.com Status|Needs documenting |RESOLVED --- Comment #10 from David Nind <david@davidnind.com> --- Behind the scenes change, no noticeable UI changes, no changes required to the manual. -- You are receiving this mail because: You are watching all bug changes.